diff options
| author | Takashi Kokubun <takashikkbn@gmail.com> | 2022-09-16 17:03:18 +0900 |
|---|---|---|
| committer | Takashi Kokubun <takashikkbn@gmail.com> | 2022-09-16 17:05:59 +0900 |
| commit | 6ad69944572adddaf608aa33e4fdef80100bee08 (patch) | |
| tree | 872f5c540a2d0a0e4a7927bc2836ad8a37a42edc /test/drb | |
| parent | c8d94d2797f798e2666a057bb1940e1ffe41b717 (diff) | |
Omit a DRb test on MinGW
This test seems to leak a thread and let TestIOWait fail:
https://github.com/ruby/ruby/actions/runs/3065426880/jobs/4949517274
DRb almost never seemed to stably work on MinGW. I don't think we intend
to fix it either. We should just omit DRb tests when they fail on MinGW.
Diffstat (limited to 'test/drb')
| -rw-r--r-- | test/drb/test_drb.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/drb/test_drb.rb b/test/drb/test_drb.rb index 1ee1b265d0..11e2219bad 100644 --- a/test/drb/test_drb.rb +++ b/test/drb/test_drb.rb @@ -335,6 +335,7 @@ end class TestDRbTCP < Test::Unit::TestCase def test_immediate_close + omit 'MinGW leaks a thread in this test' if /mingw/ =~ RUBY_PLATFORM server = DRb::DRbServer.new('druby://localhost:0') host, port, = DRb::DRbTCPSocket.send(:parse_uri, server.uri) socket = TCPSocket.open host, port @@ -345,8 +346,8 @@ class TestDRbTCP < Test::Unit::TestCase ensure client&.close socket&.close - server.stop_service - server.thread.join + server&.stop_service + server&.thread&.join DRb::DRbConn.stop_pool end end |