summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorJeremy Evans <code@jeremyevans.net>2019-10-02 07:56:28 -0700
committerGitHub <noreply@github.com>2019-10-02 07:56:28 -0700
commitef697388becedf36966a2edcdcf88baca342b9e2 (patch)
tree816a19ad728f795d71402db947386e7e9dfb6226 /spec
parent9759e3c9f09ec442b2aa0d0cc299ac791e516a01 (diff)
Treat return in block in class/module as LocalJumpError (#2511)
return directly in class/module is an error, so return in proc in class/module should also be an error. I believe the previous behavior was an unintentional oversight during the addition of top-level return in 2.4.
Notes
Notes: Merged-By: jeremyevans <code@jeremyevans.net>
Diffstat (limited to 'spec')
-rw-r--r--spec/ruby/language/return_spec.rb21
1 files changed, 11 insertions, 10 deletions
diff --git a/spec/ruby/language/return_spec.rb b/spec/ruby/language/return_spec.rb
index 7f740be25b..7eef6d06ca 100644
--- a/spec/ruby/language/return_spec.rb
+++ b/spec/ruby/language/return_spec.rb
@@ -443,17 +443,18 @@ describe "The return keyword" do
end
describe "within a block within a class" do
- it "is allowed" do
- File.write(@filename, <<-END_OF_CODE)
- class ReturnSpecs::A
- ScratchPad << "before return"
- 1.times { return }
- ScratchPad << "after return"
- end
- END_OF_CODE
+ ruby_version_is "2.7" do
+ it "is not allowed" do
+ File.write(@filename, <<-END_OF_CODE)
+ class ReturnSpecs::A
+ ScratchPad << "before return"
+ 1.times { return }
+ ScratchPad << "after return"
+ end
+ END_OF_CODE
- load @filename
- ScratchPad.recorded.should == ["before return"]
+ -> { load @filename }.should raise_error(LocalJumpError)
+ end
end
end