diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-06-07 13:23:10 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-06-18 19:14:15 +0900 |
| commit | 94fc709dd19ec6c6396982fef06e9b7d3ce8ae48 (patch) | |
| tree | 63edd3fb3637f37c2e6ab2f957ea1ac9e7d703af /spec | |
| parent | f8f3f11ed580074960e5de1de4552bdf14d7d70d (diff) | |
[rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/
The `rails_fail` name is misleading because there's no specific reason
why such a gem would need to fail. As a matter of fact, `bundle
install`'ing a Genfile with only that dependency like the spec the
previous commit adds is not expected to fail.
https://github.com/rubygems/rubygems/commit/b947f40701
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/bundler/commands/check_spec.rb | 4 | ||||
| -rw-r--r-- | spec/bundler/install/bundler_spec.rb | 10 | ||||
| -rw-r--r-- | spec/bundler/support/builders.rb | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/spec/bundler/commands/check_spec.rb b/spec/bundler/commands/check_spec.rb index c7f887d3e5..db4dadf60f 100644 --- a/spec/bundler/commands/check_spec.rb +++ b/spec/bundler/commands/check_spec.rb @@ -78,13 +78,13 @@ RSpec.describe "bundle check" do G install_gemfile <<-G source "#{file_uri_for(gem_repo1)}" - gem 'rails_fail' + gem 'rails_pinned_to_old_activesupport' G gemfile <<-G source "#{file_uri_for(gem_repo1)}" gem "rails" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" G bundle :check diff --git a/spec/bundler/install/bundler_spec.rb b/spec/bundler/install/bundler_spec.rb index 5e15333ad8..9667f80435 100644 --- a/spec/bundler/install/bundler_spec.rb +++ b/spec/bundler/install/bundler_spec.rb @@ -96,7 +96,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" gem "activemerchant" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" G nice_error = <<-E.strip.gsub(/^ {8}/, "") @@ -105,7 +105,7 @@ RSpec.describe "bundle install" do activemerchant was resolved to 1.0, which depends on activesupport (>= 2.0.0) - rails_fail was resolved to 1.0, which depends on + rails_pinned_to_old_activesupport was resolved to 1.0, which depends on activesupport (= 1.2.3) E expect(err).to include(nice_error) @@ -116,7 +116,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" gem "activesupport", "2.3.5" G @@ -125,7 +125,7 @@ RSpec.describe "bundle install" do In Gemfile: activesupport (= 2.3.5) - rails_fail was resolved to 1.0, which depends on + rails_pinned_to_old_activesupport was resolved to 1.0, which depends on activesupport (= 1.2.3) E expect(err).to include(nice_error) @@ -139,7 +139,7 @@ RSpec.describe "bundle install" do install_gemfile <<-G source "#{file_uri_for(gem_repo2)}" - gem "rails_fail" + gem "rails_pinned_to_old_activesupport" G expect(out).to include("Installing activesupport 1.2.3 (was 2.3.2)") diff --git a/spec/bundler/support/builders.rb b/spec/bundler/support/builders.rb index de71c64b56..98a6500631 100644 --- a/spec/bundler/support/builders.rb +++ b/spec/bundler/support/builders.rb @@ -76,7 +76,7 @@ module Spec s.add_dependency "activesupport", ">= 2.0.0" end - build_gem "rails_fail" do |s| + build_gem "rails_pinned_to_old_activesupport" do |s| s.add_dependency "activesupport", "= 1.2.3" end |