diff options
| author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2025-12-20 16:12:52 +0900 |
|---|---|---|
| committer | Nobuyoshi Nakada <nobu.nakada@gmail.com> | 2025-12-20 16:59:51 +0900 |
| commit | 77c3a9e447ec477be39e00072e1ce3348d0f4533 (patch) | |
| tree | e4c2b37e1c063b73d63d5864f32f573d20ae0653 /spec | |
| parent | 49f9c9bff29bce267b6aa362c6004d98db5c62f3 (diff) | |
Revert pack/unpack support for LEB128
https://bugs.ruby-lang.org/issues/21785#note-10
> It is too late to introduce it in Ruby 4.0, let's aim for 4.1.
This reverts commits:
* d0b72429a93e54f1f956b4aedfc25c57dc7001aa
Add support for signed and unsigned LEB128 to pack/unpack.
* 68a900e30b4ca1537d7975c3a619fd94fca7b084
add news for pack / unpack directives
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/ruby/core/array/pack/r_spec.rb | 23 | ||||
| -rw-r--r-- | spec/ruby/core/array/pack/shared/basic.rb | 4 | ||||
| -rw-r--r-- | spec/ruby/core/string/unpack/shared/basic.rb | 2 |
3 files changed, 3 insertions, 26 deletions
diff --git a/spec/ruby/core/array/pack/r_spec.rb b/spec/ruby/core/array/pack/r_spec.rb deleted file mode 100644 index 22be6fa640..0000000000 --- a/spec/ruby/core/array/pack/r_spec.rb +++ /dev/null @@ -1,23 +0,0 @@ -require_relative '../../../spec_helper' -require_relative '../fixtures/classes' -require_relative 'shared/basic' -require_relative 'shared/numeric_basic' -require_relative 'shared/integer' - -ruby_version_is "4.0" do - describe "Array#pack with format 'R'" do - it_behaves_like :array_pack_basic, 'R' - it_behaves_like :array_pack_basic_non_float, 'R' - it_behaves_like :array_pack_arguments, 'R' - it_behaves_like :array_pack_numeric_basic, 'R' - it_behaves_like :array_pack_integer, 'R' - end - - describe "Array#pack with format 'r'" do - it_behaves_like :array_pack_basic, 'r' - it_behaves_like :array_pack_basic_non_float, 'r' - it_behaves_like :array_pack_arguments, 'r' - it_behaves_like :array_pack_numeric_basic, 'r' - it_behaves_like :array_pack_integer, 'r' - end -end diff --git a/spec/ruby/core/array/pack/shared/basic.rb b/spec/ruby/core/array/pack/shared/basic.rb index 77d7f2f71c..ebd9f75d9d 100644 --- a/spec/ruby/core/array/pack/shared/basic.rb +++ b/spec/ruby/core/array/pack/shared/basic.rb @@ -37,7 +37,7 @@ describe :array_pack_basic_non_float, shared: true do # NOTE: it's just a plan of the Ruby core team it "warns that a directive is unknown" do # additional directive ('a') is required for the X directive - -> { [@obj, @obj].pack("a K" + pack_format) }.should complain(/unknown pack directive 'K'/) + -> { [@obj, @obj].pack("a R" + pack_format) }.should complain(/unknown pack directive 'R'/) -> { [@obj, @obj].pack("a 0" + pack_format) }.should complain(/unknown pack directive '0'/) -> { [@obj, @obj].pack("a :" + pack_format) }.should complain(/unknown pack directive ':'/) end @@ -48,7 +48,7 @@ describe :array_pack_basic_non_float, shared: true do # NOTE: Added this case just to not forget about the decision in the ticket it "raise ArgumentError when a directive is unknown" do # additional directive ('a') is required for the X directive - -> { [@obj, @obj].pack("a K" + pack_format) }.should raise_error(ArgumentError, /unknown pack directive 'K'/) + -> { [@obj, @obj].pack("a R" + pack_format) }.should raise_error(ArgumentError, /unknown pack directive 'R'/) -> { [@obj, @obj].pack("a 0" + pack_format) }.should raise_error(ArgumentError, /unknown pack directive '0'/) -> { [@obj, @obj].pack("a :" + pack_format) }.should raise_error(ArgumentError, /unknown pack directive ':'/) end diff --git a/spec/ruby/core/string/unpack/shared/basic.rb b/spec/ruby/core/string/unpack/shared/basic.rb index 0ac2a951ed..b37a447683 100644 --- a/spec/ruby/core/string/unpack/shared/basic.rb +++ b/spec/ruby/core/string/unpack/shared/basic.rb @@ -12,7 +12,7 @@ describe :string_unpack_basic, shared: true do ruby_version_is "3.3" do # https://bugs.ruby-lang.org/issues/19150 it 'raise ArgumentError when a directive is unknown' do - -> { "abcdefgh".unpack("a K" + unpack_format) }.should raise_error(ArgumentError, /unknown unpack directive 'K'/) + -> { "abcdefgh".unpack("a R" + unpack_format) }.should raise_error(ArgumentError, /unknown unpack directive 'R'/) -> { "abcdefgh".unpack("a 0" + unpack_format) }.should raise_error(ArgumentError, /unknown unpack directive '0'/) -> { "abcdefgh".unpack("a :" + unpack_format) }.should raise_error(ArgumentError, /unknown unpack directive ':'/) end |
