[Feature #19630] Limit the versions with the old behavior

It is already declared as:
> This behavior is slated to be removed in Ruby 4.0

6 files changed, 162 insertions, 154 deletions

diff --git a/spec/ruby/core/io/binread_spec.rb b/spec/ruby/core/io/binread_spec.rb
index 418e89213b..9e36b84da9 100644
--- a/spec/ruby/core/io/binread_spec.rb
+++ b/spec/ruby/core/io/binread_spec.rb
@@ -45,7 +45,7 @@ describe "IO.binread" do
     -> { IO.binread @fname, 0, -1  }.should raise_error(Errno::EINVAL)
   end
 
-  ruby_version_is "3.3" do
+  ruby_version_is "3.3"..."4.0" do
     # https://bugs.ruby-lang.org/issues/19630
     it "warns about deprecation given a path with a pipe" do
       cmd = "|echo ok"
diff --git a/spec/ruby/core/io/foreach_spec.rb b/spec/ruby/core/io/foreach_spec.rb
index c361d27879..6abe8901ba 100644
--- a/spec/ruby/core/io/foreach_spec.rb
+++ b/spec/ruby/core/io/foreach_spec.rb
@@ -14,33 +14,35 @@ describe "IO.foreach" do
     IO.foreach(@name) { $..should == @count += 1 }
   end
 
-  describe "when the filename starts with |" do
-    it "gets data from the standard out of the subprocess" do
-      cmd = "|sh -c 'echo hello;echo line2'"
-      platform_is :windows do
-        cmd = "|cmd.exe /C echo hello&echo line2"
-      end
+  ruby_version_is ""..."4.0" do
+    describe "when the filename starts with |" do
+      it "gets data from the standard out of the subprocess" do
+        cmd = "|sh -c 'echo hello;echo line2'"
+        platform_is :windows do
+          cmd = "|cmd.exe /C echo hello&echo line2"
+        end
 
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        IO.foreach(cmd) { |l| ScratchPad << l }
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          IO.foreach(cmd) { |l| ScratchPad << l }
+        end
+        ScratchPad.recorded.should == ["hello\n", "line2\n"]
       end
-      ScratchPad.recorded.should == ["hello\n", "line2\n"]
-    end
 
-    platform_is_not :windows do
-      it "gets data from a fork when passed -" do
-        parent_pid = $$
+      platform_is_not :windows do
+        it "gets data from a fork when passed -" do
+          parent_pid = $$
 
-        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-          IO.foreach("|-") { |l| ScratchPad << l }
-        end
+          suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+            IO.foreach("|-") { |l| ScratchPad << l }
+          end
 
-        if $$ == parent_pid
-          ScratchPad.recorded.should == ["hello\n", "from a fork\n"]
-        else # child
-          puts "hello"
-          puts "from a fork"
-          exit!
+          if $$ == parent_pid
+            ScratchPad.recorded.should == ["hello\n", "from a fork\n"]
+          else # child
+            puts "hello"
+            puts "from a fork"
+            exit!
+          end
         end
       end
     end
diff --git a/spec/ruby/core/io/read_spec.rb b/spec/ruby/core/io/read_spec.rb
index 567daa55df..988ec2ce30 100644
--- a/spec/ruby/core/io/read_spec.rb
+++ b/spec/ruby/core/io/read_spec.rb
@@ -168,76 +168,78 @@ describe "IO.read" do
   end
 end
 
-describe "IO.read from a pipe" do
-  it "runs the rest as a subprocess and returns the standard output" do
-    cmd = "|sh -c 'echo hello'"
-    platform_is :windows do
-      cmd = "|cmd.exe /C echo hello"
-    end
-
-    suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-      IO.read(cmd).should == "hello\n"
-    end
-  end
-
-  platform_is_not :windows do
-    it "opens a pipe to a fork if the rest is -" do
-      str = nil
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        str = IO.read("|-")
+ruby_version_is ""..."4.0" do
+  describe "IO.read from a pipe" do
+    it "runs the rest as a subprocess and returns the standard output" do
+      cmd = "|sh -c 'echo hello'"
+      platform_is :windows do
+        cmd = "|cmd.exe /C echo hello"
       end
 
-      if str # parent
-        str.should == "hello from child\n"
-      else #child
-        puts "hello from child"
-        exit!
+      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+        IO.read(cmd).should == "hello\n"
       end
     end
-  end
 
-  it "reads only the specified number of bytes requested" do
-    cmd = "|sh -c 'echo hello'"
-    platform_is :windows do
-      cmd = "|cmd.exe /C echo hello"
-    end
+    platform_is_not :windows do
+      it "opens a pipe to a fork if the rest is -" do
+        str = nil
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          str = IO.read("|-")
+        end
 
-    suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-      IO.read(cmd, 1).should == "h"
+        if str # parent
+          str.should == "hello from child\n"
+        else #child
+          puts "hello from child"
+          exit!
+        end
+      end
     end
-  end
 
-  platform_is_not :windows do
-    it "raises Errno::ESPIPE if passed an offset" do
-      -> {
-        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-          IO.read("|sh -c 'echo hello'", 1, 1)
-        end
-      }.should raise_error(Errno::ESPIPE)
+    it "reads only the specified number of bytes requested" do
+      cmd = "|sh -c 'echo hello'"
+      platform_is :windows do
+        cmd = "|cmd.exe /C echo hello"
+      end
+
+      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+        IO.read(cmd, 1).should == "h"
+      end
     end
-  end
 
-  quarantine! do # The process tried to write to a nonexistent pipe.
-    platform_is :windows do
-      # TODO: It should raise Errno::ESPIPE on Windows as well
-      # once https://bugs.ruby-lang.org/issues/12230 is fixed.
-      it "raises Errno::EINVAL if passed an offset" do
+    platform_is_not :windows do
+      it "raises Errno::ESPIPE if passed an offset" do
         -> {
           suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-            IO.read("|cmd.exe /C echo hello", 1, 1)
+            IO.read("|sh -c 'echo hello'", 1, 1)
           end
-        }.should raise_error(Errno::EINVAL)
+        }.should raise_error(Errno::ESPIPE)
       end
     end
-  end
 
-  ruby_version_is "3.3" do
-    # https://bugs.ruby-lang.org/issues/19630
-    it "warns about deprecation given a path with a pipe" do
-      cmd = "|echo ok"
-      -> {
-        IO.read(cmd)
-      }.should complain(/IO process creation with a leading '\|'/)
+    quarantine! do # The process tried to write to a nonexistent pipe.
+      platform_is :windows do
+        # TODO: It should raise Errno::ESPIPE on Windows as well
+        # once https://bugs.ruby-lang.org/issues/12230 is fixed.
+        it "raises Errno::EINVAL if passed an offset" do
+          -> {
+            suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+              IO.read("|cmd.exe /C echo hello", 1, 1)
+            end
+          }.should raise_error(Errno::EINVAL)
+        end
+      end
+    end
+
+    ruby_version_is "3.3" do
+      # https://bugs.ruby-lang.org/issues/19630
+      it "warns about deprecation" do
+        cmd = "|echo ok"
+        -> {
+          IO.read(cmd)
+        }.should complain(/IO process creation with a leading '\|'/)
+      end
     end
   end
 end
diff --git a/spec/ruby/core/io/readlines_spec.rb b/spec/ruby/core/io/readlines_spec.rb
index 3a6ff3d0f3..b4770775d1 100644
--- a/spec/ruby/core/io/readlines_spec.rb
+++ b/spec/ruby/core/io/readlines_spec.rb
@@ -174,45 +174,47 @@ describe "IO.readlines" do
     $_.should == "test"
   end
 
-  describe "when passed a string that starts with a |" do
-    it "gets data from the standard out of the subprocess" do
-      cmd = "|sh -c 'echo hello;echo line2'"
-      platform_is :windows do
-        cmd = "|cmd.exe /C echo hello&echo line2"
-      end
-
-      lines = nil
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        lines = IO.readlines(cmd)
-      end
-      lines.should == ["hello\n", "line2\n"]
-    end
+  ruby_version_is ""..."4.0" do
+    describe "when passed a string that starts with a |" do
+      it "gets data from the standard out of the subprocess" do
+        cmd = "|sh -c 'echo hello;echo line2'"
+        platform_is :windows do
+          cmd = "|cmd.exe /C echo hello&echo line2"
+        end
 
-    platform_is_not :windows do
-      it "gets data from a fork when passed -" do
         lines = nil
         suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-          lines = IO.readlines("|-")
+          lines = IO.readlines(cmd)
         end
+        lines.should == ["hello\n", "line2\n"]
+      end
 
-        if lines # parent
-          lines.should == ["hello\n", "from a fork\n"]
-        else
-          puts "hello"
-          puts "from a fork"
-          exit!
+      platform_is_not :windows do
+        it "gets data from a fork when passed -" do
+          lines = nil
+          suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+            lines = IO.readlines("|-")
+          end
+
+          if lines # parent
+            lines.should == ["hello\n", "from a fork\n"]
+          else
+            puts "hello"
+            puts "from a fork"
+            exit!
+          end
         end
       end
     end
-  end
 
-  ruby_version_is "3.3" do
-    # https://bugs.ruby-lang.org/issues/19630
-    it "warns about deprecation given a path with a pipe" do
-      cmd = "|echo ok"
-      -> {
-        IO.readlines(cmd)
-      }.should complain(/IO process creation with a leading '\|'/)
+    ruby_version_is "3.3" do
+      # https://bugs.ruby-lang.org/issues/19630
+      it "warns about deprecation given a path with a pipe" do
+        cmd = "|echo ok"
+        -> {
+          IO.readlines(cmd)
+        }.should complain(/IO process creation with a leading '\|'/)
+      end
     end
   end
 
diff --git a/spec/ruby/core/io/write_spec.rb b/spec/ruby/core/io/write_spec.rb
index 4a26f8dbaf..e58100f846 100644
--- a/spec/ruby/core/io/write_spec.rb
+++ b/spec/ruby/core/io/write_spec.rb
@@ -220,7 +220,7 @@ describe "IO.write" do
       end
     end
 
-    ruby_version_is "3.3" do
+    ruby_version_is "3.3"..."4.0" do
       # https://bugs.ruby-lang.org/issues/19630
       it "warns about deprecation given a path with a pipe" do
         -> {
diff --git a/spec/ruby/core/kernel/open_spec.rb b/spec/ruby/core/kernel/open_spec.rb
index 6d00af395d..b967d5044b 100644
--- a/spec/ruby/core/kernel/open_spec.rb
+++ b/spec/ruby/core/kernel/open_spec.rb
@@ -27,64 +27,66 @@ describe "Kernel#open" do
     open(@name, "r") { |f| f.gets }.should == @content
   end
 
-  platform_is_not :windows, :wasi do
-    it "opens an io when path starts with a pipe" do
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        @io = open("|date")
+  ruby_version_is ""..."4.0" do
+    platform_is_not :windows, :wasi do
+      it "opens an io when path starts with a pipe" do
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          @io = open("|date")
+        end
+        begin
+          @io.should be_kind_of(IO)
+          @io.read
+        ensure
+          @io.close
+        end
       end
-      begin
-        @io.should be_kind_of(IO)
-        @io.read
-      ensure
-        @io.close
-      end
-    end
 
-    it "opens an io when called with a block" do
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        @output = open("|date") { |f| f.read }
+      it "opens an io when called with a block" do
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          @output = open("|date") { |f| f.read }
+        end
+        @output.should_not == ''
       end
-      @output.should_not == ''
-    end
 
-    it "opens an io for writing" do
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        -> {
-          bytes = open("|cat", "w") { |io| io.write(".") }
-          bytes.should == 1
-        }.should output_to_fd(".")
+      it "opens an io for writing" do
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          -> {
+            bytes = open("|cat", "w") { |io| io.write(".") }
+            bytes.should == 1
+          }.should output_to_fd(".")
+        end
       end
     end
-  end
 
-  platform_is :windows do
-    it "opens an io when path starts with a pipe" do
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        @io = open("|date /t")
+    platform_is :windows do
+      it "opens an io when path starts with a pipe" do
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          @io = open("|date /t")
+        end
+        begin
+          @io.should be_kind_of(IO)
+          @io.read
+        ensure
+          @io.close
+        end
       end
-      begin
-        @io.should be_kind_of(IO)
-        @io.read
-      ensure
-        @io.close
-      end
-    end
 
-    it "opens an io when called with a block" do
-      suppress_warning do # https://bugs.ruby-lang.org/issues/19630
-        @output = open("|date /t") { |f| f.read }
+      it "opens an io when called with a block" do
+        suppress_warning do # https://bugs.ruby-lang.org/issues/19630
+          @output = open("|date /t") { |f| f.read }
+        end
+        @output.should_not == ''
       end
-      @output.should_not == ''
     end
-  end
 
-  ruby_version_is "3.3" do
-    # https://bugs.ruby-lang.org/issues/19630
-    it "warns about deprecation given a path with a pipe" do
-      cmd = "|echo ok"
-      -> {
-        open(cmd) { |f| f.read }
-      }.should complain(/Kernel#open with a leading '\|'/)
+    ruby_version_is "3.3" do
+      # https://bugs.ruby-lang.org/issues/19630
+      it "warns about deprecation given a path with a pipe" do
+        cmd = "|echo ok"
+        -> {
+          open(cmd) { |f| f.read }
+        }.should complain(/Kernel#open with a leading '\|'/)
+      end
     end
   end