summaryrefslogtreecommitdiff
path: root/spec/ruby/language/shared
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2025-07-03 08:53:56 +0200
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2025-07-07 11:53:05 +0900
commite95adbfa68f583c4a67fdc4b0ba4eca85fa44b5e (patch)
tree348ce491b4a4ea851f1406f80ba3ae03b64ceaba /spec/ruby/language/shared
parent9918ca16713765879c6a71106a1cb310f1882c1b (diff)
[rubygems/rubygems] Remove unnecessary nesting from standalone specs
Originally, all the specs in this file were put inside a shared examples block, and since then all specs were run only changing the cwd (either from root, or a subdirectory). This was in https://github.com/rubygems/rubygems/commit/d7291700d016, to cover a fix in the `bundler_path` method. However, reverting that fix does not make any of the specs in either of the main blocks fail! Only an unrelated spec of `bundle install --standalone --local` fails. The reason is that all specs set `path` to an absolute path, making the fix essentially uncovered. In order to simplify the file structure and improve runtime, I completely removed the shared examples block, and only run main specs for the root directory. Then I added a couple of extra specs to cover the original bug fix. This cuts runtime of this spec file in half, from 1m30s to 45s on my laptop. https://github.com/rubygems/rubygems/commit/cc506f17e0
Diffstat (limited to 'spec/ruby/language/shared')
0 files changed, 0 insertions, 0 deletions