diff options
| author | Yusuke Endoh <mame@ruby-lang.org> | 2020-02-09 11:04:53 +0900 |
|---|---|---|
| committer | Yusuke Endoh <mame@ruby-lang.org> | 2020-02-09 11:13:06 +0900 |
| commit | 2173ae7801c90ef5837b388a7b3f832732785aea (patch) | |
| tree | e5ea56ccb33a4bf4531776eaad2fde9e6cf46319 /spec/ruby/core | |
| parent | acb9b73495e7a9b4bf52b33dabf1714834c1d9ae (diff) | |
spec/ruby/core/file/utime_spec.rb: far future timestamp may be trancated
Under some Ext4 filesystem settings, a timestamp is limited up to
0x37fffffff (2446-05-10).
https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps
> Therefore, timestamps should not overflow until May 2446.
Actually the spec fails under one of our CI environments, like:
```
1)
File.utime allows Time instances in the far future to set mtime and atime FAILED
Expected 2446 == 559444
to be truthy but was false
```
https://rubyci.org/logs/rubyci.s3.amazonaws.com/arch/ruby-master/log/20200208T180002Z.fail.html.gz
Diffstat (limited to 'spec/ruby/core')
| -rw-r--r-- | spec/ruby/core/file/utime_spec.rb | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/spec/ruby/core/file/utime_spec.rb b/spec/ruby/core/file/utime_spec.rb index 03adc76efe..9c198af18b 100644 --- a/spec/ruby/core/file/utime_spec.rb +++ b/spec/ruby/core/file/utime_spec.rb @@ -72,11 +72,13 @@ describe "File.utime" do platform_is :linux do platform_is wordsize: 64 do - it "allows Time instances in the far future to set mtime and atime" do + it "allows Time instances in the far future to set mtime and atime (but some filesystems limit it up to 2446-05-10)" do + # https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps + # "Therefore, timestamps should not overflow until May 2446." time = Time.at(1<<44) File.utime(time, time, @file1) - File.atime(@file1).year.should == 559444 - File.mtime(@file1).year.should == 559444 + [559444, 2446].should.include? File.atime(@file1).year + [559444, 2446].should.include? File.mtime(@file1).year end end end |