summaryrefslogtreecommitdiff
path: root/spec/ruby/core/io/reopen_spec.rb
diff options
context:
space:
mode:
authornormal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-12-03 09:34:49 +0000
committernormal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-12-03 09:34:49 +0000
commit07a5db2c3223e5fa706c5b7040ca28e2bca44ca0 (patch)
tree365f2dd01fb336007c794a80b43f895dd5a540b6 /spec/ruby/core/io/reopen_spec.rb
parent89455ff2ba973f2a9ee7b79657e0e6f1f31501f9 (diff)
spec/ruby/core/io/*_spec.rb: explain MJIT failures
These random failures happen because FD number allocation is not predictable when multiple threads are running (since MJIT thread is opening/closing files all the time). Real-world code practically never relies on predictable FD number allocation (because much real-world code is multi-threaded); so it's highly unlikely there'll be any breakage to the user. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'spec/ruby/core/io/reopen_spec.rb')
-rw-r--r--spec/ruby/core/io/reopen_spec.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/spec/ruby/core/io/reopen_spec.rb b/spec/ruby/core/io/reopen_spec.rb
index 60dda72689..e769991554 100644
--- a/spec/ruby/core/io/reopen_spec.rb
+++ b/spec/ruby/core/io/reopen_spec.rb
@@ -145,9 +145,9 @@ describe "IO#reopen with a String" do
File.read(@other_name).should == "new data"
end
- # http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1461550
- # http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1448152
- without_feature :mjit do # with RubyVM::MJIT.enabled?, this randomly fails for now
+ # File descriptor numbers are not predictable in multi-threaded code;
+ # MJIT will be opening/closing files the background
+ without_feature :mjit do
it "closes the file descriptor obtained by opening the new file" do
@io = new_io @name, "w"