diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-06-24 19:52:14 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
commit | 16823d4a05580e041ff514122de5f3a3fbcef409 (patch) | |
tree | 56b01b2c04e7b89e4e7437db1e4abcc9ad7fde94 /spec/bundler/install/gemfile | |
parent | e2837a77be2164fa17be046eabb93cbb63f77311 (diff) |
[rubygems/rubygems] Remove unnecessary assertions on exitstatus
Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
Diffstat (limited to 'spec/bundler/install/gemfile')
-rw-r--r-- | spec/bundler/install/gemfile/git_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/path_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/platform_spec.rb | 1 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/ruby_spec.rb | 1 |
4 files changed, 0 insertions, 6 deletions
diff --git a/spec/bundler/install/gemfile/git_spec.rb b/spec/bundler/install/gemfile/git_spec.rb index 81d234e101..aaef839c0a 100644 --- a/spec/bundler/install/gemfile/git_spec.rb +++ b/spec/bundler/install/gemfile/git_spec.rb @@ -912,7 +912,6 @@ RSpec.describe "bundle install with git sources" do bundle "install" bundle "install" - expect(exitstatus).to eq(0) if exitstatus end it "prints a friendly error if a file blocks the git repo" do @@ -1358,7 +1357,6 @@ In Gemfile: end G - expect(exitstatus).to eq(0) if exitstatus expect(ENV["GIT_DIR"]).to eq("bar") expect(ENV["GIT_WORK_TREE"]).to eq("bar") end diff --git a/spec/bundler/install/gemfile/path_spec.rb b/spec/bundler/install/gemfile/path_spec.rb index 29cbb291a4..84ece3d699 100644 --- a/spec/bundler/install/gemfile/path_spec.rb +++ b/spec/bundler/install/gemfile/path_spec.rb @@ -133,7 +133,6 @@ RSpec.describe "bundle install with explicit source paths" do bundle "config --local frozen true" bundle :install - expect(exitstatus).to eq(0) if exitstatus end it "installs dependencies from the path even if a newer gem is available elsewhere" do @@ -421,7 +420,6 @@ RSpec.describe "bundle install with explicit source paths" do install_gemfile <<-G gem "bar", "1.0.0", path: "vendor/bar", require: "bar/nyard" G - expect(exitstatus).to eq(0) if exitstatus end context "existing lockfile" do diff --git a/spec/bundler/install/gemfile/platform_spec.rb b/spec/bundler/install/gemfile/platform_spec.rb index 13b3e47163..dd58aef29b 100644 --- a/spec/bundler/install/gemfile/platform_spec.rb +++ b/spec/bundler/install/gemfile/platform_spec.rb @@ -349,7 +349,6 @@ RSpec.describe "bundle install with platform conditionals" do G bundle :list - expect(exitstatus).to eq(0) if exitstatus end it "does not attempt to install gems from :rbx when using --local" do diff --git a/spec/bundler/install/gemfile/ruby_spec.rb b/spec/bundler/install/gemfile/ruby_spec.rb index cdb3960089..fd4300c042 100644 --- a/spec/bundler/install/gemfile/ruby_spec.rb +++ b/spec/bundler/install/gemfile/ruby_spec.rb @@ -22,7 +22,6 @@ RSpec.describe "ruby requirement" do gem "rack-obama" G - expect(exitstatus).to eq(0) if exitstatus expect(the_bundle).to include_gems "rack-obama 1.0" end |