summaryrefslogtreecommitdiff
path: root/spec/bundler/bundler/fetcher/index_spec.rb
diff options
context:
space:
mode:
authorSamuel Giddins <segiddins@segiddins.me>2023-10-22 13:25:07 -0700
committergit <svn-admin@ruby-lang.org>2023-11-15 08:33:14 +0000
commitb69bbf588a3dd167d62dbb89f0cef25ebae4a7ea (patch)
tree613203d44c4b91ee854e006b5f1cae705df75403 /spec/bundler/bundler/fetcher/index_spec.rb
parent536649f819ed8f2bb0f8f44b1a0ca5c6d1753b24 (diff)
[rubygems/rubygems] User bundler UA when downloading gems
Gem::RemoteFetcher uses Gem::Request, which adds the RubyGems UA. Gem::RemoteFetcher is used to download gems, as well as the full index. We would like the bundler UA to be used whenever bundler is making requests. This PR also avoids unsafely mutating the headers hash on the shared `Gem::RemoteFetcher.fetcher` instance, which could cause corruption or incorrect headers when making parallel requests. Instead, we create one remote fetcher per rubygems remote, which is similar to the connection segregation bundler is already doing https://github.com/rubygems/rubygems/commit/f0e8dacdec
Diffstat (limited to 'spec/bundler/bundler/fetcher/index_spec.rb')
-rw-r--r--spec/bundler/bundler/fetcher/index_spec.rb3
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/bundler/bundler/fetcher/index_spec.rb b/spec/bundler/bundler/fetcher/index_spec.rb
index 971b64ce8f..f3cdc235ba 100644
--- a/spec/bundler/bundler/fetcher/index_spec.rb
+++ b/spec/bundler/bundler/fetcher/index_spec.rb
@@ -8,8 +8,9 @@ RSpec.describe Bundler::Fetcher::Index do
let(:display_uri) { "http://sample_uri.com" }
let(:rubygems) { double(:rubygems) }
let(:gem_names) { %w[foo bar] }
+ let(:gem_remote_fetcher) { nil }
- subject { described_class.new(downloader, remote, display_uri) }
+ subject { described_class.new(downloader, remote, display_uri, gem_remote_fetcher) }
before { allow(Bundler).to receive(:rubygems).and_return(rubygems) }