diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-07-08 18:38:01 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-31 21:07:19 +0900 |
| commit | d5b5a7ab31099a14b5933696991dfc55c37005cc (patch) | |
| tree | f1485f8c7efdea5e922eaf9353961474bde7e7d4 /lib | |
| parent | 76722c4928d92fa6cc4a927203eab8a036516e23 (diff) | |
[rubygems/rubygems] Remove very old TODO note
It was added 10 years ago on a "146 additions, 170 deletions" commit
named "Deprecation removals and minor cleanup." that didn't explain much
other than that.
This TODO doesn't necessarily apply nowadays. I don't see how anyways.
TODO notes, if useful at all, should include a clear explanation of what
should be done either via the note itself or the commit message. This
note doens't meet any of these.
So I want to remove it because it distracts me every time I go through
it.
https://github.com/rubygems/rubygems/commit/58d81e8a32
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3379
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/rubygems/specification.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb index ddcd0aa327..a2b982cd74 100644 --- a/lib/rubygems/specification.rb +++ b/lib/rubygems/specification.rb @@ -1006,7 +1006,6 @@ class Gem::Specification < Gem::BasicSpecification # Return currently unresolved specs that contain the file matching +path+. def self.find_in_unresolved(path) - # TODO: do we need these?? Kill it specs = unresolved_deps.values.map {|dep| dep.to_specs }.flatten specs.find_all {|spec| spec.contains_requirable_file? path } |