diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-05-02 12:37:57 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-05-08 14:13:29 +0900 |
| commit | 0d7e0eb2faa282e0c15faa60c62992ca5452e228 (patch) | |
| tree | 39fa24ce79ba33b42514150a3ad1c169ed8b2cd1 /lib | |
| parent | de57d3895ef6eb681c12a27720e7c185a22023d7 (diff) | |
[rubygems/rubygems] Prefer `tr` to `gsub` when replacing path separators
This is not detected by the `Performance/StringReplacement` cop, I guess
because of using constants. But still seems like a good change.
Co-authored-by: MSP-Greg <MSP-Greg@users.noreply.github.com>
https://github.com/rubygems/rubygems/commit/f862103133
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3092
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/rubygems/installer.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/rubygems/installer.rb b/lib/rubygems/installer.rb index 343037ebf5..cf676854dc 100644 --- a/lib/rubygems/installer.rb +++ b/lib/rubygems/installer.rb @@ -709,7 +709,7 @@ class Gem::Installer return if self.class.path_warning user_bin_dir = @bin_dir || Gem.bindir(gem_home) - user_bin_dir = user_bin_dir.gsub(File::SEPARATOR, File::ALT_SEPARATOR) if + user_bin_dir = user_bin_dir.tr(File::SEPARATOR, File::ALT_SEPARATOR) if File::ALT_SEPARATOR path = ENV['PATH'] |