diff options
| author | HASUMI Hitoshi <hasumikin@gmail.com> | 2022-11-29 10:06:50 +0900 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2022-12-02 10:47:18 +0000 |
| commit | 11871e49c4fe493d6b958046969bc863f7fb6627 (patch) | |
| tree | 74cde4f02639652ee262f9fa2f4817d7f92a7697 /lib/reline | |
| parent | 21ed929e157f1b859534de421a9e3641a2ec22c8 (diff) | |
[ruby/reline] Fix misuse of kwarg in IO#raw
- Obviously, `tim` is a typo for `time`
- This didn't cause an exception because IO#raw is implemented in C and it doesn't check the keyword of the parameters
- Though this typo doesn't produce any problems for now, I think it should be fixed just in case for the future
- I've used this fixed version of Reline with IRB for several days and didn't find any new problems due to the fix
- But I myself am not sure how to make sure this fix is completely robust
https://github.com/ruby/reline/commit/e66a9696a1
Diffstat (limited to 'lib/reline')
| -rw-r--r-- | lib/reline/ansi.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/reline/ansi.rb b/lib/reline/ansi.rb index ab147a6185..c40085e50d 100644 --- a/lib/reline/ansi.rb +++ b/lib/reline/ansi.rb @@ -150,7 +150,7 @@ class Reline::ANSI until c = @@input.raw(intr: true) { @@input.wait_readable(0.1) && @@input.getbyte } Reline.core.line_editor.resize end - (c == 0x16 && @@input.raw(min: 0, tim: 0, &:getbyte)) || c + (c == 0x16 && @@input.raw(min: 0, time: 0, &:getbyte)) || c rescue Errno::EIO # Maybe the I/O has been closed. nil |