diff options
| author | Martin Emde <martin.emde@gmail.com> | 2023-09-01 15:15:49 -0700 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2023-10-23 13:59:01 +0900 |
| commit | c667de72ff9de195e1cab4b1937973e841ff89ae (patch) | |
| tree | 6dc6a88dbf8c44109593352055c8e798d562a83f /lib/bundler/endpoint_specification.rb | |
| parent | 6362bfdc337c1929a381734ded417b796f9767bf (diff) | |
[rubygems/rubygems] Improve errors and register checksums reliably
Improve error reporting for checksums, raises a new error class.
Solve for multi-source checksum errors.
Add CHECKSUMS to tool/bundler/(dev|standard|rubocop)26_gems.rb
https://github.com/rubygems/rubygems/commit/26ceee0e76
Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
Diffstat (limited to 'lib/bundler/endpoint_specification.rb')
| -rw-r--r-- | lib/bundler/endpoint_specification.rb | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/lib/bundler/endpoint_specification.rb b/lib/bundler/endpoint_specification.rb index 11c71d1ae7..0bb0e9c7fa 100644 --- a/lib/bundler/endpoint_specification.rb +++ b/lib/bundler/endpoint_specification.rb @@ -126,16 +126,11 @@ module Bundler case k.to_s when "checksum" next if Bundler.settings[:disable_checksum_validation] - digest = v.last - if digest.length == 64 - # nothing to do, it's a hexdigest - elsif digest.length == 44 - # transform the bytes from base64 to hex - digest = digest.unpack("m0").first.unpack("H*").first - else - raise ArgumentError, "The given checksum for #{full_name} (#{digest.inspect}) is not a valid SHA256 hexdigest nor base64digest" + begin + @checksum = Checksum.from_api(v.last, @spec_fetcher.uri) + rescue ArgumentError => e + raise ArgumentError, "Invalid checksum for #{full_name}: #{e.message}" end - @checksum = Checksum.new("sha256", digest, "API response from #{@spec_fetcher.uri}") when "rubygems" @required_rubygems_version = Gem::Requirement.new(v) when "ruby" |