diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2022-03-25 20:29:09 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-25 20:29:09 +0900 |
commit | 69967ee64eac9ce65b83533a566d69d12a6046d0 (patch) | |
tree | b7012ba8b7ad5b1c99d7b1f9b2345ecd8117f433 /insns.def | |
parent | 7ee26740e41f99d3da37df36b956237fbf36868e (diff) |
Revert "Finer-grained inline constant cache invalidation"
This reverts commits for [Feature #18589]:
* 8008fb7352abc6fba433b99bf20763cf0d4adb38
"Update formatting per feedback"
* 8f6eaca2e19828e92ecdb28b0fe693d606a03f96
"Delete ID from constant cache table if it becomes empty on ISEQ free"
* 629908586b4bead1103267652f8b96b1083573a8
"Finer-grained inline constant cache invalidation"
MSWin builds on AppVeyor have been crashing since the merger.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/5715
Merged-By: nobu <nobu@ruby-lang.org>
Diffstat (limited to 'insns.def')
-rw-r--r-- | insns.def | 13 |
1 files changed, 1 insertions, 12 deletions
@@ -1028,23 +1028,12 @@ opt_getinlinecache (VALUE val) { struct iseq_inline_constant_cache_entry *ice = ic->entry; - - // If there isn't an entry, then we're going to walk through the ISEQ - // starting at this instruction until we get to the associated - // opt_setinlinecache and associate this inline cache with every getconstant - // listed in between. We're doing this here instead of when the instructions - // are first compiled because it's possible to turn off inline caches and we - // want this to work in either case. - if (!ice) { - vm_ic_compile(GET_CFP(), ic); - } - if (ice && vm_ic_hit_p(ice, GET_EP())) { val = ice->value; JUMP(dst); } else { - val = Qnil; + val = Qnil; } } |