summaryrefslogtreecommitdiff
path: root/include/ruby
diff options
context:
space:
mode:
authorJob Snijders <job@sobornost.net>2024-03-25 12:20:13 +0000
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2024-11-11 13:43:58 +0900
commitbcc3ad7ff0400308bc63b177ecc39efff9bbf3f4 (patch)
tree0aaff35b0979cac7d26cd05a06bdf5c26fb23dbc /include/ruby
parent5d10d1f348145316fa0b84e5c458b41337c46789 (diff)
[ruby/openssl] Only CSR version 1 (encoded as 0) is allowed by PKIX standards
RFC 2986, section 4.1 only defines version 1 for CSRs. This version is encoded as a 0. Starting with OpenSSL 3.3, setting the CSR version to anything but 1 fails. Do not attempt to generate a CSR with invalid version (which now fails) and invalidate the CSR in test_sign_and_verify_rsa_sha1 by changing its subject rather than using an invalid version. This commit fixes the following error. ``` 2) Error: test_version(OpenSSL::TestX509Request): OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument /home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:18:in `version=' /home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:18:in `issue_csr' /home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:43:in `test_version' 40: req = OpenSSL::X509::Request.new(req.to_der) 41: assert_equal(0, req.version) 42: => 43: req = issue_csr(1, @dn, @rsa1024, OpenSSL::Digest.new('SHA256')) 44: assert_equal(1, req.version) 45: req = OpenSSL::X509::Request.new(req.to_der) 46: assert_equal(1, req.version) ``` https://github.com/ruby/openssl/commit/c06fdeb091
Diffstat (limited to 'include/ruby')
0 files changed, 0 insertions, 0 deletions