summaryrefslogtreecommitdiff
path: root/include/ruby
diff options
context:
space:
mode:
authorEdouard CHIN <chin.edouard@gmail.com>2025-02-20 21:15:27 +0100
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2025-02-25 15:36:46 +0900
commit71f0c37473224580d7c67091588f1a32e64c9a53 (patch)
treeb1c4d324d8ae4187f7c847a283fc4d3d376a9f69 /include/ruby
parentb7c87ccd79ce14df3b95f413a527be95ac16ff10 (diff)
[rubygems/rubygems] Modify `bundle doctor` to not report issue when files aren't writable:
- ### Problem Running `bundle doctor` warn about files that aren't writable. This makes the output of `bundle doctor` very verbose for something I believe isn't really an issue. ### Context Rubygems keeps the files original permission at the time the gem is packaged. Many gem maintainers have decided that the permissions of the files in their bundled would be 0444, this includes amongst others: minitest, selenium, brakeman... Any git gems that had a 0444 permissions at some point in its git history would also be reported (as bundle doctor look in the `cache/bundler/git/<gem>/object` path). While it completely make sense to report when files aren't readable, maybe it's worth questioning the usefulness of reporting files that can't be written and what problem this causes to the user (if any). ### Solution Removed the check for unwritable file. ### Side note I also tweaked the "No issues ..." message logic as it was doing the opposite (reporting an issue when there is none and vice versa). This wasn't caught in tests because as a stub on `Bundler.ui.info` was missing. https://github.com/rubygems/rubygems/commit/9a426b9495
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/12804
Diffstat (limited to 'include/ruby')
0 files changed, 0 insertions, 0 deletions