summaryrefslogtreecommitdiff
path: root/gc.c
diff options
context:
space:
mode:
authorJean Boussier <byroot@ruby-lang.org>2023-02-06 23:27:12 +0100
committerJean Boussier <jean.boussier@gmail.com>2023-02-07 11:48:49 +0100
commit6e4c242130965de1cf00703c99f8821b0bd19e5b (patch)
tree613b82007b324aa43021f0eafebf7fe581ef10a4 /gc.c
parent8623c81220541cb05e793e3e9aec8a561e2c57e2 (diff)
Consider DATA objects without a mark function as protected
It's not uncommon for simple binding to wrap structs without any Ruby object references. Hence with no `mark` function. Might as well mark them as protected by a write barrier.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/7255
Diffstat (limited to 'gc.c')
-rw-r--r--gc.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/gc.c b/gc.c
index 3baed251f4..cf87a74bdb 100644
--- a/gc.c
+++ b/gc.c
@@ -3110,7 +3110,7 @@ rb_data_object_wrap(VALUE klass, void *datap, RUBY_DATA_FUNC dmark, RUBY_DATA_FU
{
RUBY_ASSERT_ALWAYS(dfree != (RUBY_DATA_FUNC)1);
if (klass) rb_data_object_check(klass);
- return newobj_of(klass, T_DATA, (VALUE)dmark, (VALUE)dfree, (VALUE)datap, FALSE, sizeof(struct RTypedData));
+ return newobj_of(klass, T_DATA, (VALUE)dmark, (VALUE)dfree, (VALUE)datap, !dmark, sizeof(struct RTypedData));
}
VALUE
@@ -3126,7 +3126,8 @@ rb_data_typed_object_wrap(VALUE klass, void *datap, const rb_data_type_t *type)
{
RBIMPL_NONNULL_ARG(type);
if (klass) rb_data_object_check(klass);
- return newobj_of(klass, T_DATA, (VALUE)type, (VALUE)1, (VALUE)datap, type->flags & RUBY_FL_WB_PROTECTED, sizeof(struct RTypedData));
+ bool wb_protected = (type->flags & RUBY_FL_WB_PROTECTED) || !type->function.dmark;
+ return newobj_of(klass, T_DATA, (VALUE)type, (VALUE)1, (VALUE)datap, wb_protected, sizeof(struct RTypedData));
}
VALUE