diff options
author | Yusuke Endoh <mame@ruby-lang.org> | 2021-04-26 18:11:46 +0900 |
---|---|---|
committer | Yusuke Endoh <mame@ruby-lang.org> | 2021-04-26 22:46:51 +0900 |
commit | 2c7d3b3a722c4636ab1e9d289cbca47ddd168d3e (patch) | |
tree | cb21ba7bca3f68e93587d3e75e07990c443c9a51 /gc.c | |
parent | 5219b4ddb4b89dfe8a951da75f5ab78431781d7f (diff) |
node.c (rb_ast_new): imemo_ast is WB-unprotected
Previously imemo_ast was handled as WB-protected which caused a segfault
of the following code:
# shareable_constant_value: literal
M0 = {}
M1 = {}
...
M100000 = {}
My analysis is here: `shareable_constant_value: literal` creates many
Hash instances during parsing, and add them to node_buffer of imemo_ast.
However, the contents are missed because imemo_ast is incorrectly
WB-protected.
This changeset makes imemo_ast as WB-unprotected.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/4416
Diffstat (limited to 'gc.c')
-rw-r--r-- | gc.c | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -2435,6 +2435,13 @@ rb_imemo_new(enum imemo_type type, VALUE v1, VALUE v2, VALUE v3, VALUE v0) return newobj_of(v0, flags, v1, v2, v3, TRUE); } +rb_ast_t * +rb_imemo_ast_new(VALUE node_buffer) +{ + VALUE flags = T_IMEMO | (imemo_ast << FL_USHIFT); + return (rb_ast_t *)newobj_of(node_buffer, flags, 0, 0, 0, FALSE); +} + static VALUE rb_imemo_tmpbuf_new(VALUE v1, VALUE v2, VALUE v3, VALUE v0) { |