[ruby/json] Fix non-portable code

A plain `char` may be `signed` or `unsigned` depending on the
implementation.  Also, bitwise ORing of `signed` values ​​is not
guaranteed to be `signed`.  To ensure portability, should logical-OR
each comparison, but casting to `signed char` is usually sufficient.

https://github.com/ruby/json/commit/8ad744c532

1 files changed, 5 insertions, 5 deletions

diff --git a/ext/json/parser/parser.c b/ext/json/parser/parser.c
index 60ed689fde..0ac16918f8 100644
--- a/ext/json/parser/parser.c
+++ b/ext/json/parser/parser.c
@@ -485,12 +485,12 @@ static uint32_t unescape_unicode(JSON_ParserState *state, const char *sp, const
 
     const unsigned char *p = (const unsigned char *)sp;
 
-    const char b0 = digit_values[p[0]];
-    const char b1 = digit_values[p[1]];
-    const char b2 = digit_values[p[2]];
-    const char b3 = digit_values[p[3]];
+    const signed char b0 = digit_values[p[0]];
+    const signed char b1 = digit_values[p[1]];
+    const signed char b2 = digit_values[p[2]];
+    const signed char b3 = digit_values[p[3]];
 
-    if (RB_UNLIKELY((b0 | b1 | b2 | b3) < 0)) {
+    if (RB_UNLIKELY((signed char)(b0 | b1 | b2 | b3) < 0)) {
         raise_parse_error_at("incomplete unicode character escape sequence at %s", state, sp - 2);
     }