summaryrefslogtreecommitdiff
path: root/ext/psych/lib/psych/visitors/visitor.rb
diff options
context:
space:
mode:
authorMarc-Andre Lafortune <github@marc-andre.ca>2020-12-20 21:42:25 -0500
committerMarc-André Lafortune <github@marc-andre.ca>2020-12-23 01:08:38 -0500
commitc5a445d577b786e31c420b5857ad05b954b420ec (patch)
tree3aa3ed924d9cd166364f18469a5945dbbe441792 /ext/psych/lib/psych/visitors/visitor.rb
parent3ee0ad919034fbc098939979c872d041a82c4334 (diff)
[ruby/psych] Make Ractor-ready.
Config is Ractor-local. Benchmarking reveals that using `Ractor.local_storage` for storing cache is similar to accessing a constant (~15% slower).
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3953
Diffstat (limited to 'ext/psych/lib/psych/visitors/visitor.rb')
-rw-r--r--ext/psych/lib/psych/visitors/visitor.rb20
1 files changed, 17 insertions, 3 deletions
diff --git a/ext/psych/lib/psych/visitors/visitor.rb b/ext/psych/lib/psych/visitors/visitor.rb
index 3f4ba64e57d..35f8f81f184 100644
--- a/ext/psych/lib/psych/visitors/visitor.rb
+++ b/ext/psych/lib/psych/visitors/visitor.rb
@@ -8,12 +8,26 @@ module Psych
private
- DISPATCH = Hash.new do |hash, klass|
- hash[klass] = "visit_#{klass.name.gsub('::', '_')}"
+ # @api private
+ def self.dispatch_cache
+ Hash.new do |hash, klass|
+ hash[klass] = :"visit_#{klass.name.gsub('::', '_')}"
+ end
+ end
+
+ if defined?(Ractor)
+ def dispatch
+ Ractor.current[:Psych_Visitors_Visitor] ||= Visitor.dispatch_cache
+ end
+ else
+ DISPATCH = dispatch_cache
+ def dispatch
+ DISPATCH
+ end
end
def visit target
- send DISPATCH[target.class], target
+ send dispatch[target.class], target
end
end
end