diff options
| author | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-04-19 01:08:16 +0000 |
|---|---|---|
| committer | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-04-19 01:08:16 +0000 |
| commit | c32fc82d0ed8bcf0d6e4de8518bbb7bd808a69b8 (patch) | |
| tree | a92b3b9275d623968562e7e984375e80a67ff8b8 /NEWS | |
| parent | 0013fdaaa5145f2003d96b6e54a5f16f16f3678b (diff) | |
socket: avoid fcntl for read/write_nonblock on Linux
On platforms where MSG_DONTWAIT works reliably on all sockets
(so far, I know of Linux), we can avoid fcntl syscalls and
implement IO#write_nonblock and IO#read_nonblock in terms of the
socket-specific send and recv family of syscalls.
This avoids side effects on the socket, and also encourages
generic code to be written in cases where IO wrappers like
OpenSSL::SSL::SSLSocket are used.
Perhaps in the future, side-effect-free non-blocking I/O can
be standard on all files and OSes: https://cr.yp.to/unix/nonblock.html
* ext/socket/lib/socket.rb (read_nonblock, write_nonblock):
Linux-specific wrapper without side effects
[ruby-core:80780] [Feature #13362]
* test/socket/test_basicsocket.rb (test_read_write_nonblock):
new test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -64,6 +64,10 @@ with all sufficient information, see the ChangeLog file or Redmine * Random.raw_seed renamed to become Random.urandom. It is now applicable to non-seeding purposes due to [Bug #9569]. +* BasicSocket#read_nonblock and BasicSocket#write_nonblock no + longer sets the O_NONBLOCK file description flag as side effect + [Feature #13362] + === Stdlib compatibility issues (excluding feature bug fixes) === C API updates |