diff options
author | Yusuke Endoh <mame@ruby-lang.org> | 2020-06-19 00:53:33 +0900 |
---|---|---|
committer | Yusuke Endoh <mame@ruby-lang.org> | 2020-06-19 00:57:18 +0900 |
commit | 26c1cf6a6066f90c0c2be7e84e68f75fb920b0d9 (patch) | |
tree | 49659b76064867e1ed544ec5d2f2df4a8a0ea9b4 /NEWS.md | |
parent | c0591b8477edfa59bba566acbb8e0550fa31caff (diff) |
test/webrick/test_httpresponse.rb: Use a longer indicator for crack
"hack" was too short. The tests checks the error html, which includes
hostname. GitHub Actions hostname seems randomly generated, and it may
include the indicator string.
https://github.com/ruby/ruby/runs/784896235
```
1) Failure:
WEBrick::TestHTTPResponse#test_prevent_response_splitting_cookie_headers_cr [/home/runner/work/ruby/ruby/src/test/webrick/test_httpresponse.rb:71]:
Expected /hack/ to not match "HTTP/1.1 500 Internal Server Error\r\nContent-Type: text/html; charset=ISO-8859-1\r\n\r\n<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.0//EN\">\n<HTML>\n <HEAD><TITLE>Internal Server Error</TITLE></HEAD>\n <BODY>\n <H1>Internal Server Error</H1>\n WEBrick::HTTPResponse::InvalidHeader\n <HR>\n <ADDRESS>\n WEBrick/1.6.0 (Ruby/2.8.0/2020-06-18) at\n fv-az89.dddawhu1s14uzpjkiz5fhackre.cx.internal.cloudapp.net:80\n </ADDRESS>\n </BODY>\n</HTML>\n".
```
This change uses longer indicator "cracked_indicator_for_test" instead.
Diffstat (limited to 'NEWS.md')
0 files changed, 0 insertions, 0 deletions