diff options
| author | Benoit Daloze <eregontp@gmail.com> | 2019-09-28 11:45:23 +0200 |
|---|---|---|
| committer | Benoit Daloze <eregontp@gmail.com> | 2019-09-29 13:57:54 +0200 |
| commit | e3b11566bfbb6ddcdd9f3483a6bdeb501a610fa9 (patch) | |
| tree | a8e76e5627c5727e9e5f8e0c783d6063098255dd /.github | |
| parent | f6f03dcad60d38868d345172ad5c5d2ce44bd004 (diff) | |
Remove continue-on-error for test-bundled-gems
* Otherwise, it takes a very long time to notice those tests broke.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/2503
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/macos.yml | 2 | ||||
| -rw-r--r-- | .github/workflows/ubuntu.yml | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index de05e217bb..6911f87385 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -46,13 +46,11 @@ jobs: env: MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests (test-bundled-gems) # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved run: make -s ${{ matrix.test_task }} TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest env: RUBY_TESTOPTS: "-q --tty=no" - continue-on-error: true if: matrix.test_task == 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - name: Leaked Globals run: make -s leaked-globals diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 7e860dc181..71fbdf2ecc 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -74,13 +74,11 @@ jobs: env: MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests (test-bundled-gems) # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved run: make -s ${{ matrix.test_task }} TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest env: RUBY_TESTOPTS: "-q --tty=no" - continue-on-error: true if: matrix.test_task == 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - name: Leaked Globals run: make -s leaked-globals |