Age | Commit message (Collapse) | Author |
|
https://github.com/ruby/csv/commit/68461aead5
Notes:
Merged: https://github.com/ruby/ruby/pull/5336
|
|
unexpectedly"
This reverts commit https://github.com/ruby/csv/commit/5c6523da0a61.
This introduces another pbolem. We should try again later.
https://github.com/ruby/csv/commit/43a1d6fff1
Notes:
Merged: https://github.com/ruby/ruby/pull/5336
|
|
Ruby: [Bug #18245] [ruby-core:105587]
Reported by Hassan Abdul Rehman.
https://github.com/ruby/csv/commit/5c6523da0a
Notes:
Merged: https://github.com/ruby/ruby/pull/5336
|
|
(https://github.com/ruby/csv/pull/226)
GitHub: fix GH-225
With Ruby 3.0.2 and csv 3.2.1, the file
```ruby
require "csv"
File.open("example.tsv", "w") { |f| f.puts("foo\t\tbar") }
CSV.read("example.tsv", col_sep: "\t", strip: true)
```
produces the error
```
lib/csv/parser.rb:935:in `parse_quotable_robust': TODO: Meaningful
message in line 1. (CSV::MalformedCSVError)
```
However, the CSV in this example is not malformed; instead, ambiguous
options were provided to the parser. It is not obvious (to me) whether
the string should be parsed as
- `["foo\t\tbar"]`,
- `["foo", "bar"]`,
- `["foo", "", "bar"]`, or
- `["foo", nil, "bar"]`.
This commit adds code that raises an exception when this situation is
encountered. Specifically, it checks if the column separator either ends
with or starts with the characters that would be stripped away.
This commit also adds unit tests and updates the documentation.
https://github.com/ruby/csv/commit/cc317dd42d
Notes:
Merged: https://github.com/ruby/ruby/pull/5336
|
|
https://github.com/ruby/csv/commit/27c0b66c8f
Notes:
Merged: https://github.com/ruby/ruby/pull/5336
|
|
Notes:
Merged-By: k0kubun <takashikkbn@gmail.com>
|
|
https://github.com/ruby/csv/commit/a802690e11
Notes:
Merged: https://github.com/ruby/ruby/pull/5010
|
|
The implementation of the `CSV` shortcut method is broken in Ruby 3
for calls that look like this:
```ruby
CSV(write_stream, col_sep: "|", headers: headers, write_headers: true) do |csv|
...
end
```
The above will result in the following error when the `CSV` method attempts to pass
on arguments to `CSV#instance`:
```
ArgumentError: wrong number of arguments (given 2, expected 0..1)
```
The issue is due to the changes in Ruby 3 relating to positional & keyword arguments.
This commit updates the `CSV()` shortcut implementation to work with Ruby 3, and also
updates the documentation for the shortcut method.
https://github.com/ruby/csv/commit/310dee45fa
Notes:
Merged: https://github.com/ruby/ruby/pull/5010
|
|
a single entry when row is faulty (https://github.com/ruby/csv/pull/220)
https://github.com/ruby/csv/commit/29cef9ea9d
Notes:
Merged: https://github.com/ruby/ruby/pull/5010
|
|
because the name "MJIT" is an internal code name, it's inconsistent with
--jit while they are related to each other, and I want to discourage future
JIT implementation-specific (e.g. MJIT-specific) APIs by this rename.
[Feature #17490]
|
|
GitHub: fix GH-194
Reported by Josef Šimánek. Thanks!!!
https://github.com/ruby/csv/commit/fd86afe081
Notes:
Merged: https://github.com/ruby/ruby/pull/3804
|
|
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
https://github.com/ruby/csv/commit/203c5e0574
Notes:
Merged: https://github.com/ruby/ruby/pull/3804
|
|
as the expected encoding
See also: https://github.com/ruby/stringio/issues/13#issuecomment-660543554
https://github.com/ruby/csv/commit/004cf49d18
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
GitHub: fix GH-153
Reported by Aleksandr. Thanks!!!
https://github.com/ruby/csv/commit/8812c58a26
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to #129.
https://github.com/ruby/csv/commit/5bf687341c
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
Follow up to https://github.com/ruby/csv/pull/130/files#r434885191.
This PR fixes `ArgumentError` for `CSV.open` when processing
invalid byte sequence in UTF-8.
https://github.com/ruby/csv/commit/a4b528c209
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This PR adds `undef: :replace` option for `CSV.open`.
`File.open` has `undef: :replace` option, but `CSV.open` does not.
It would be convenient if `CSV.open` could have a shortcut by having
`undef: :replace` option.
https://github.com/ruby/csv/commit/cff8b18480
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
with non String
GitHub: fix GH-123
Reported by asm256. Thanks!!!
https://github.com/ruby/csv/commit/b4492139be
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This reverts commit 736174d28413a4c36630b0daf2f170c8d2fc9abe.
It doesn't solve anything.
https://github.com/ruby/csv/commit/0ee3bdd0d3
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/736174d284
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
GitHub: fix #115
Reported by TOMITA Masahiro. Thanks!!!
https://github.com/ruby/csv/commit/398b3564c5
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/dbf55ef008
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
with anchors (#110)
* Do not loop forever when skip_lines regexp matches zero length with anchors
* Remove needless white spaces
* Add missing eos check in skip_needless_lines
* Simplify test
https://github.com/ruby/csv/commit/3b15d4a3e8
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
* Make CSV::Row#dup return a usable Row
Previously, calling `dup` on a `CSV::Row` object yielded an object whose
copy was too shallow. Changing the clone's fields would also change the
fields on the source. This change makes the clone more distinct from the
source, so that changes can be made to its fields without affecting the
source.
* Simplify
https://github.com/ruby/csv/commit/64a1ea06fc
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/b37df55f46
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This reverts commit 375cf129189f32f7be76ac525035bcde691a63e7, to
sync csv from the upstream.
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
|
|
Fix up 66d1900423e6fb9774c2fe72dba8c2968b54d7ab, `RubyVM::MJIT` is
available since ruby 2.6.
|
|
To prevent CI failures like
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2739995
|
|
I noticed that some files in rubygems were executable, and I could think
of no reason why they should be.
In general, I think ruby files should never have the executable bit set
unless they include a shebang, so I run the following command over the
whole repo:
```bash
find . -name '*.rb' -type f -executable -exec bash -c 'grep -L "^#!" $1 || chmod -x $1' _ {} \;
```
Notes:
Merged: https://github.com/ruby/ruby/pull/2662
|
|
of "setting Encoding.default_internal".
|
|
Notes:
Merged-By: kou <kou@clear-code.com>
|
|
This were previously hidden because calls from C were not warned.
Notes:
Merged: https://github.com/ruby/ruby/pull/2432
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/2395
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/2395
|
|
|
|
https://github.com/ruby/csv/commit/5540d35a30
|
|
GitHub: fix #86
Reported by krororo. Thanks!!!
https://github.com/ruby/csv/commit/5a8d9d9297
|
|
|
|
|
|
|
|
This fixes test failures on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67561 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
This includes performance improvements and backward incompatibility
fixes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
This includes performance improvement especially writing. Writing is
about 2 times faster.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
CSV.new does not yield the instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
test/csv/test_features.rb:357: warning: assigned but unused variable - csv
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|