summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2020-06-18[rubygems/rubygems] Remove unnecessary `bundle install`David Rodríguez
These specs doesn't really need an installed bundle, they only need a `Gemfile`. https://github.com/rubygems/rubygems/commit/06c85683ae Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Make helpers raise by defaultDavid Rodríguez
https://github.com/rubygems/rubygems/commit/ade0c441d5 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix a couple of specs that were loading an incorrect bundlerDavid Rodríguez
We have a check on an `at_exit` hook that checks that system bundler is never loaded instead of our development copy. The check was failing in these cases, but in a silent way because the errors were being swallowed. This commit changes these specs to make sure they load the right bundler. https://github.com/rubygems/rubygems/commit/cd1c1bc297 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Change spec to do the right thing on bundler 3David Rodríguez
On bundler 3, the `--deployment` flag doesn't exist, so the `bundle install --deployment` command was failing silently and the spec was verifying a different scenario. Change the spec to work the same regardless of bundler's major version. Also, from the spec description it was not apparently that a specific case involving deployment mode was being tested, so I reworded it to make it more apparent. https://github.com/rubygems/rubygems/commit/3e33e2b927 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix some sudo specs to do the right thing on bundler 3David Rodríguez
On bundler 3, where the default install path is `.bundle`, these specs were trying to change permissions of the `.bundle/ruby/<ruby_abi_version>` folder, which didn't exist yet,so the permission changing command was failing and the spec was not testing the right thing. Change the specs so that the permissions are correctly changed, by first configuring the local path to be `.bundle` (which creates the `.bundle` folder), and then changing permissions of the `.bundle` folder explicitly, which exists already. https://github.com/rubygems/rubygems/commit/2833162fb0 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix spec to test the right thing on bundler 3David Rodríguez
Bundler 3 installs by default to `.bundle`. That means that, because the `bar` gem was not previously available at this location but as a system gem, the initial `bundle install` was silently failing. As a consequence, the spec was not testing the exact scenario it meant to test. https://github.com/rubygems/rubygems/commit/202399521c Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Remove bad `bundle install`David Rodríguez
This spec is specifically testing for the case where there's no `Gemfile.lock` file and it's only doing the expected thing because the `bundle install` command is silently failing. Remove the `bundle install` to reduce confusion. https://github.com/rubygems/rubygems/commit/ec39fbde0e Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Simplify `bundle update --ruby` specsDavid Rodríguez
They don't need to run that many commands, and the new version is also more readable in my opinion. https://github.com/rubygems/rubygems/commit/efff3e3210 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix redundant commandsDavid Rodríguez
They are preceded by `install_gemfile` calls, which mean `bundle install` is being run twice for no reason. https://github.com/rubygems/rubygems/commit/d2b2d10862 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix unintended Gemfile installationDavid Rodríguez
This command is failing because of the same reason that the subsequent `bundle exec` is failing: the gemspec is invalid. The `bundle install` here deviates the `bundle exec` focus from the test and is unnecessary: all we need is a `Gemfile` that will trigger the `bundle exec`, so let's create and avoid the extra command. https://github.com/rubygems/rubygems/commit/eb83cf6cf1 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Remove failing command that doesn't affect the specDavid Rodríguez
This command was silently failing but doesn't really affect the outcome of the spec. https://github.com/rubygems/rubygems/commit/7880d08146 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Remove broken testDavid Rodríguez
It turns out that this test is checking essentially nothing useful. The paperclip gem doesn't exist in our setup, so initial install is failing and the test is only checking that calling `bundle check` 3 times on a broken setup always returns the same thing. I went to the history of this test: * https://github.com/rubygems/bundler/commit/105654a31e07e9b0a198f1a5a5ec94e365854edf * https://github.com/rubygems/bundler/commit/ae53be1f8748bfc41bc6565dc4922a1c0ac80998 * https://github.com/rubygems/bundler/commit/d19f4a7b32ccf4ec4ecda5c7c0354adc81e1efb6 * https://github.com/rubygems/bundler/commit/092f169d01472336598e29b32550399991940d63 * https://github.com/rubygems/bundler/commit/36878435b5f0be75fc6f2e07cebd7f15aaddadf0 And have finally decided to remove it since I'm not sure changing it to something else will lead to testing something useful and not already tested. https://github.com/rubygems/rubygems/commit/6184322967 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix silently broken specDavid Rodríguez
This spec was broken. The second `bundle install` was silently failing. This means that the spec was actually checking an scenario completely different from the one that was supposed to be tested. And also a very dummy one: that running `bundle cache` twice doesn't cache a completely unrelated gem. https://github.com/rubygems/rubygems/commit/f11a5d2df9 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Remove incorrect tagsDavid Rodríguez
The inner specs have separated specs for the `< 3` and `= 2` cases, so this outer tag is incorrect. https://github.com/rubygems/rubygems/commit/61e905ca27 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Migrate some specs to use "the new way"David Rodríguez
The commands these specs run were throwing warnings in bundler 2, and failing on bundler 3, effectively testing a different scenario to what they were supposed to. https://github.com/rubygems/rubygems/commit/97ac1ced49 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/David Rodríguez
The `rails_fail` name is misleading because there's no specific reason why such a gem would need to fail. As a matter of fact, `bundle install`'ing a Genfile with only that dependency like the spec the previous commit adds is not expected to fail. https://github.com/rubygems/rubygems/commit/b947f40701 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-18[rubygems/rubygems] Fix `only_update_to_newer_versions` regressionDavid Rodríguez
The `only_update_to_newer_versions` feature flag will enable some new behaviour in bundler 3 (or maybe earlier if we decide to consider it a bug fix) that prevents `bundle update` from unexpectedly downgrading direct dependencies. This seems reasonable, but the current implementation is adding additional requirements for all locked dependencies, not only from the ones in the `Gemfile`. That causes some situations where the `Gemfile` is edited and will resolve to older versions to start failing. This commit fixes the problem by making sure extra requirements are added exclusively for direct dependencies in the `Gemfile`, not for all direct dependencies in the lock file. https://github.com/rubygems/rubygems/commit/128b4596e1 Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-15Accommodate process title spec to ruby-core setupDavid Rodríguez
I'm guessing the commands under ruby-core setup are very long, so the title gets truncated. Use a shorter title, since the test doesn't really care. Notes: Merged: https://github.com/ruby/ruby/pull/3225
2020-06-15Fix most exec specsDavid Rodríguez
The `gem_command` helper was failing to require `support/hax.rb`, which takes care of making sure rubygems actually picks up the right `ruby` executable under ruby-core setup (`ENV["RUBY"]`). This caused binstubs to be generated with a wrong shebang, and that caused `bundle exec` to not work. The error message was pretty confusing though due to https://bugs.ruby-lang.org/issues/16952. Notes: Merged: https://github.com/ruby/ruby/pull/3225
2020-06-13Suppress warnings [Feature #15973]Nobuyoshi Nakada
2020-06-11Refined ioctl error descriptionNobuyoshi Nakada
2020-06-10Make proc/Proc.new without block an error instead of warningJeremy Evans
The warning for these was added in 2.7. Notes: Merged: https://github.com/ruby/ruby/pull/3208
2020-06-10ENV.delete should return the result of block on non-existing keyNobuyoshi Nakada
Fixes [Bug #16173] Co-Authored-By: Burdette Lamar <burdettelamar@yahoo.com> Co-Authored-By: Jeremy Evans <code@jeremyevans.net> Notes: Merged: https://github.com/ruby/ruby/pull/3206
2020-06-06Fix build failuresYuki Nishijima
Notes: Merged: https://github.com/ruby/ruby/pull/3135
2020-06-05Manually pick from rubygems/rubygems changes atHiroshi SHIBATA
https://github.com/rubygems/rubygems/pull/3666/commits/ca5bf584026c9fd3a288eb10c65493e9f01ccc44 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05Re-record all cassettesDavid Rodríguez
I had to pin `redis-namespace` in our spec to 1.6.0 because on ruby 2.3.0 the spec no longer resolved to that version, so the cached `.gem` file was missing there. Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05Fix `bin/rake spec:realworld:record`David Rodríguez
Previously it was failing and not recording. Also, the `BUNDLER_SPEC_FORCE_RECORD` environment variable was forcing every request to be recorded, including duplicated requests to the same endpoint. That meant the recorded `versions` file would be incorrect because it would contain the result of the last request, which would be `304 NOT MODIFIED`. So, to rerecord, delete cassettes and let them be recorded when needed. Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Remove multiline gem specifications correctlyCarsten Wirth
https://github.com/rubygems/rubygems/commit/8dca0ad56e Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Fix `bundle info` not indicating a gem which has been ↵DEVRAJ KUMAR
deleted, unlike `bundle show` Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/rubygems/rubygems/commit/2851b40ffb Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Tag test framework hint specs and use out helperFrank Lam
https://github.com/rubygems/rubygems/commit/1db61b5b5e Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Add user hint specs for bundle gem --testFrank Lam
https://github.com/rubygems/rubygems/commit/1d2292a88f Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Fix bundle gem ignoring global gem.test configFrank Lam
* bundle gem previously ignored gem.test when passed empty -t flag, defaulting to RSpec * bundle gem will now ask user for test framework when passed empty -t flag and gem.test is set to false, but will not overwrite gem.test * thor option parsing for String types falls back to human name for nil, so setting lazy_default to nil won't work * https://github.com/erikhuda/thor/blob/c5161501e0cfac7a8c5b838a9c6084c275f03c0d/lib/thor/parser/options.rb#L224 Default to Bundler.settings["gem.test"] for empty --test Add shared examples for test framework to newgem spec Add examples for empty --test flag to newgem spec Simplify conditional for prompting test framework Follow naming conventions for bundler settings Add more descriptive test framework help text for bundle gem Update man pages for bundler https://github.com/rubygems/rubygems/commit/ab0785a09f Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Remove `forgotten_command_line_usages` from specsDavid Rodríguez
Instead, use the non-deprecated option except when specifically testing deprecated CLI flags. In that case, pass the flag directly and limit the specs to `bundler < 3`. https://github.com/rubygems/rubygems/commit/3d5e186241 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Reword specs to not mention deprecated flagsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/f878a81f22 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Rewrite dependency API specs to use new deployment modeDavid Rodríguez
Some of them were passing "by chance" because they used a `bundle install` command that failed, but the assertion was using the result of the previous. Others were skipped on bundler 3. Now they all pass in all versions. https://github.com/rubygems/rubygems/commit/cedf611e11 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Make `forgotten_command_line_options` always "forget" ↵David Rodríguez
options https://github.com/rubygems/rubygems/commit/4d39338670 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Improve specs testing option remembering behaviorDavid Rodríguez
By making them more explicit. https://github.com/rubygems/rubygems/commit/9979c5a811 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Fix `bundle install` unintentionally saving configurationDavid Rodríguez
Even if no explicit flags were passed to it. https://github.com/rubygems/rubygems/commit/0598cbb68c Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Change descriptions to not mention deprecated flagsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/731b3783f1 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Fix flag name in spec descriptionsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/6395392b83 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Improve wording of some specsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/3372b21553 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Remove old no longer meaningful specDavid Rodríguez
This spec was originally written many years ago to verity gems were properly "remembered" in the lock file. At this point, the test feels a bit dummy since the first `bundle install` already runs on a "clean machine". https://github.com/rubygems/rubygems/commit/dbfefb3f5a Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Revert multi ruby{,gems} version requirement fixDavid Rodríguez
This reverts commit 20f06d9e178211a3016133852b72d21ac7bb93ad, reversing changes made to f2b30cb70df8a518bef0e8a64bbceb86234d922d. https://github.com/rubygems/rubygems/commit/40802bdb18 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Support running specs against a tarballDavid Rodríguez
When bundler specs are run from a ruby tarball (ruby-core does this), there's no git folder, so `git ls-files` fails. Support this case by making specs rely on the list of files from the bundler gemspec instead, and invert the spec that makes sure we ship the right set of files. As per the other quality specs, skip them in this case. https://github.com/rubygems/rubygems/commit/b28d5ec931 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Remove unintended extra spaceDavid Rodríguez
https://github.com/rubygems/rubygems/commit/1cc02930f3 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05Revert "Fix a error in a `before(:suite)` hook"Hiroshi SHIBATA
This reverts commit 67d2a715ca35090fbb3ab13df5b7348b1807dd47. Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05Revert "Fix a failure in bundle version with version outputs the version ↵Hiroshi SHIBATA
with build metadata" This reverts commit fcc8be0198a16cc5fa7d4827be0c781209b70f98. Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Deprecate the `--no-deployment` flagDavid Rodríguez
And never recommend it inside CLI messages. This flag represents the default behaviour of `bundle install`, and the only reason it exists is to "override" previous `--deployment` flag usages which were silently remembered. So it should be deprecated just like all the other flags the rely on remembering their values across invocations. https://github.com/rubygems/rubygems/commit/40e50b7190 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Pass `--deployment` flag directlyDavid Rodríguez
This spec is run only in bundler 2 mode, and it's testing the `--deployment` flag specifically. https://github.com/rubygems/rubygems/commit/a5d91c68b6 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-06-05[rubygems/rubygems] Unskip "monorepo issues"David Rodríguez
They seem to be passing? https://github.com/rubygems/rubygems/commit/a00d1e6896 Notes: Merged: https://github.com/ruby/ruby/pull/3184
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-19 07:52:34 +0000