summaryrefslogtreecommitdiff
path: root/spec/bundler
AgeCommit message (Collapse)Author
2022-06-01[rubygems/rubygems] Fix `bundle remove` by invalidating cached ↵Ellen Marie Dash
`Bundle.defintion`. Prior to this commit, `bundle add GEM_NAME` updated the lockfile, but `bundle remove GEM_NAME` left GEM_NAME in the lockfile. By invalidating the cached `Bundle.definition`, the existing code handles that without a problem. https://github.com/rubygems/rubygems/commit/aa0794d6a9
2022-06-01[rubygems/rubygems] Fix generated standalone script for default gemsDavid Rodríguez
The installer is actually rewriting the spec's full gem path to be the one of the newly installed gem, however the accessor was not properly working for `StubSpecification` instances, and default gems are always of this type, because they are always present locally. Fix the accessor to properly update the underlying full specification. https://github.com/rubygems/rubygems/commit/efa41babfa
2022-06-01[rubygems/rubygems] Skip duplicated dependency warning for gemspec dev depsDavid Rodríguez
Generally this warning is skipped for gemspec development dependencies. I think because it's common to override them in the Gemfile to change the source, for example. But the order of conditions was not correct and the warning was still being printed in one case. https://github.com/rubygems/rubygems/commit/da9d1d6a3f
2022-05-31[rubygems/rubygems] Give better conflict resolution adviceDavid Rodríguez
This alternative really uses only the Gemfile, and can never end up being absurd, because it will never be suggested when there's no lockfile, and it suggests deleting the lockfile. https://github.com/rubygems/rubygems/commit/5d154dd50e
2022-05-30[rubygems/rubygems] Fix crash when commenting out a mirror in configurationDavid Rodríguez
https://github.com/rubygems/rubygems/commit/2d99277328
2022-05-30[rubygems/rubygems] Fix crash when installing gems with symlinksDavid Rodríguez
If BUNDLE_PATH is configured to a symlinked path, installing gems with symlinks would crash with an error like this: ``` Gem::Package::SymlinkError: installing symlink 'man/man0/README.markdown' pointing to parent path /usr/home/stevewi/srv/mail/lib/tools/.vendor/ruby/3.1.0/gems/binman-5.1.0/README.markdown of /srv/mail/lib/tools/.vendor/ruby/3.1.0/gems/binman-5.1.0 is not allowed ``` This commit fixes the problem by changing the bundle path to be the realpath of the configured value, right after we're sure the path has been created. https://github.com/rubygems/rubygems/commit/3cd3dd142a
2022-05-30[rubygems/rubygems] No need to use `FileUtils` to create symlinksDavid Rodríguez
https://github.com/rubygems/rubygems/commit/70ff7cee9f
2022-05-30[rubygems/rubygems] Fix failing spec on WindowsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/8e68c57457
2022-05-30[rubygems/rubygems] Ignore `Errno::EROFS` errors when creating `bundler.lock`David Rodríguez
Apparently old versions of MacOS would set `GEM_HOME` to a `/System` folder, and trying to create a file there raises `Errno::EROFS`. We ignore the error. Any permission issues should be better handled further down the line. https://github.com/rubygems/rubygems/commit/ef90c071d0
2022-05-29[rubygems/rubygems] Ignore `Errno::EPERM` errors when creating `bundler.lock`David Rodríguez
This kind of error can happen when setting `GEM_HOME` to a path under MacOS System Integrity Protection. We ignore the error. Any permission issues should be better handled further down the line. https://github.com/rubygems/rubygems/commit/174cb66863
2022-05-27[rubygems/rubygems] Show better error when previous installation fails to be ↵David Rodríguez
removed Instead of guessing on the culprit. We actually have a helper, `Bundler.rm_rf`, with exactly the behavior that we want: * Allow the passed folder to not exist. * No exception swallowing other than that. https://github.com/rubygems/rubygems/commit/5fa3e6f04a
2022-05-24[rubygems/rubygems] Fix crash when printing resolution conflicts on metadata ↵David Rodríguez
requirements https://github.com/rubygems/rubygems/commit/b69e1e9374
2022-05-20Merge RubyGems and Bundler HEADHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/125415593ead9ab69a9f0bb5392c9d7ec61b1f51
2022-05-20[rubygems/rubygems] Fix locale dependent spec failureDavid Rodríguez
https://github.com/rubygems/rubygems/commit/1fd818743e
2022-05-13[rubygems/rubygems] Fix `Gemfile.lock` versions leaking to `bundler/inline` ↵David Rodríguez
install output The lockfile is completely ignored in inline mode, yet the previous output would suggest it wasn't. https://github.com/rubygems/rubygems/commit/763125a745
2022-05-11[rubygems/rubygems] Fix error message on metadata mismatchesDavid Rodríguez
Previously we were removing not installable specs. However, if those are the only ones, that would result in a bad error message. If we still choose them as a last resort, Bundler will later check metadata right before installing a give a proper error. This is a regression of https://github.com/rubygems/rubygems/commit/565549260be5 and the fix is to revert that commit. https://github.com/rubygems/rubygems/commit/bc18912257
2022-05-11[rubygems/rubygems] Tweak negative expectationsDavid Rodríguez
The follow a tweak on the yank message. https://github.com/rubygems/rubygems/commit/f6817bfe58
2022-05-11[rubygems/rubygems] Extract a `next_ruby_minor` helper method for specsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/66eae0ef1d
2022-05-09[rubygems/rubygems] Cleanup old legacy codeDavid Rodríguez
https://github.com/rubygems/rubygems/commit/531d6b5fee
2022-05-04[rubygems/rubygems] Fix missing space in specDavid Rodríguez
https://github.com/rubygems/rubygems/commit/fabc357e70
2022-04-28Merge ↵Hiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/3f7d0352e84b29d4a2d4cd93b31e5ebdb5f79cc6 Notes: Merged: https://github.com/ruby/ruby/pull/5669
2022-04-28Merge rubygems master 1e4eda741d732ca1bd7031aef0a16c7348adf7a5Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/5669
2022-04-28[rubygems/rubygems] Fix missing required rubygems version when using old APIsDavid Rodríguez
A while ago, we fixed resolution when using old dependency endpoints to also consider metadata dependencies, by requesting the full gemspec from the marsahaled index, which includes this information as opposed to these old APIs. This has made resolution slower, but correct, but also introduced the issue that some old marshaled gemspecs don't include the `required_rubygems_version` field because they were created with a RubyGems version that predates its addition. Use a default value in this case. https://github.com/rubygems/rubygems/commit/5dc94afcc0 Co-authored-by: Ilya Dudarenko <i.dudarenko@tinkoff.ru>
2022-04-16[rubygems/rubygems] Add modern rubies to the platformsBobby McDonald
https://github.com/rubygems/rubygems/commit/5462322f8f
2022-03-24[rubygems/rubygems] Maybe this is now fixedDavid Rodríguez
https://github.com/rubygems/rubygems/commit/d9c442e54c
2022-03-23[rubygems/rubygems] Fix a test for `bin/bundle update --bundler` to pass on ↵Jun Aruga
ruby/ruby. Consider the case that the latest Bundler version on RubyGems is higher than the `system_bundler_version` (= `Bundler::VERSION`) in `make test-bundler` on ruby/ruby. See <https://bugs.ruby-lang.org/issues/18643>. https://github.com/rubygems/rubygems/commit/bfa2f72cfa
2022-03-08[rubygems/rubygems] Add newline to validate_platforms! message when platform ↵Alex Gittemeier
is missing When I run bundle install with BUNDLE_DEPLOYMENT=true in the environment on a different platform than I usually do development, I get the following output to the console (wrapped exactly as shown): Your bundle only supports platforms ["x86_64-darwin-19"] but your local platform is x86_64-linux. Add the current platform to the lockfile with `bundle lock --add-platform x86_64-linux` and try again. Because the way the message wraps, its not as simple as copying the suggested command to the clipboard because it contains a newline: $ bundle lock Writing lockfile to [...]/Gemfile.lock $ --add-platform x86_64-linux Adding a newline right before the command forces the command in the error message to be on the same line, which facilitates copy-pasting the command in the message. https://github.com/rubygems/rubygems/commit/4cf6989b11
2022-03-06[rubygems/rubygems] Make `--strict` flag of `update` and `outdated` commands ↵David Rodríguez
consistent Previously they had slightly different behavior when combined with conservative updating flags. The correct behavior is the `--update-strict` option, so `--script` now does that, The `--update-strict` option is left there for now but I will deprecate it later. https://github.com/rubygems/rubygems/commit/ab42046229
2022-02-28Merge RubyGems and Bundler masterHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/5606
2022-02-11[rubygems/rubygems] Fix corrupted lockfile when using `gemspec` and multiple ↵David Rodríguez
sources https://github.com/rubygems/rubygems/commit/9712262d90
2022-02-10[rubygems/rubygems] Fix typo in multiple gemfiles warningSven Schwyn
https://github.com/rubygems/rubygems/commit/bc69d19097
2022-02-01[rubygems/rubygems] Skip "seller shipped" notification after deliveryDan Jensen
If a Shipment has been delivered, there is no point in notifying the buyer that the seller shipped. Instead, we should simply notify the buyer that the shipment was delivered. This is relevant in cases where the seller is late to mark a Shipment as shipped, so the first EasyPost Tracker update marks it as delivered, or in cases where the seller fails to mark as shipped and the buyer marks it as delivered. This fixes a Shipment event handler so the buyer notification for shipment is no longer invoked if the Shipment is already delivered. https://github.com/rubygems/rubygems/commit/09c2cadc86
2022-02-01Sync latest Bundler & RubyGemsDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/5512
2022-01-26[rubygems/rubygems] Fix `force_ruby_platform` ignored when lockfile includes ↵David Rodríguez
the current specific platform https://github.com/rubygems/rubygems/commit/9ca371adf8
2022-01-26[rubygems/rubygems] Use Gem::Platform.local instead of RUBY_PLATFORMNgan Pham
In certain places, we want to display the platform name with `Gem::Platform.local` instead of `RUBY_PLATFORM`. Fixes https://github.com/rubygems/rubygems/issues/5264 https://github.com/rubygems/rubygems/commit/bdd1848ae8
2022-01-25[rubygems/rubygems] Fix spec to not touch the networkDavid Rodríguez
And not depend on the state of rack's master branch, in particular, on their Ruby support range. https://github.com/rubygems/rubygems/commit/9ea4baffac
2022-01-25[rubygems/rubygems] Remove unnecessary commentDavid Rodríguez
https://github.com/rubygems/rubygems/commit/ef4e5c6169
2022-01-20[rubygems/rubygems] Change generated namespaced test class name in minitestYusuke Nakamura
* `foo` => `TestFoo` * `foo_bar` => `TestFooBar` * `foo-bar` => `Foo::TestBar` https://github.com/rubygems/rubygems/commit/353cdd61c3
2022-01-20[rubygems/rubygems] Add spec to class name definition in newgem specYusuke Nakamura
https://github.com/rubygems/rubygems/commit/5f698fc4a0
2022-01-20[rubygems/rubygems] Update generated minitest file styleYusuke Nakamura
foo => test/test_foo.rb foo-bar => test/foo/test_bar.rb foo_bar => test/test_foo_bar.rb https://github.com/rubygems/rubygems/commit/c795e5d40d
2022-01-20[rubygems/rubygems] Create minitest file to underscored path in "bundle gem" ↵Yusuke Nakamura
command ...with dashed gem name In "bundle gem" command with dashed name gem (e.g. foo-bar) generates `test/test_foo/bar.rb`, but this file contains undefined class `TestFoo` and moreover, does not include in "bundle exec rake test" target. Therefore, intentially the first test after gem created is fail, but in case of gem name contains dash character is not. The change doings... (when "bundle gem foo-bar" called) * create `test/test_foo_bar.rb` * define `TestFooBar` class in `test/test_foo_bar.rb` https://github.com/rubygems/rubygems/commit/5d9a69fc0f
2022-01-19Merge rubygems/rubygems HEAD.Hiroshi SHIBATA
Picked at 12aeef6ba9a3be0022be9934c1a3e4c46a03ed3a Notes: Merged: https://github.com/ruby/ruby/pull/5462
2022-01-19[rubygems/rubygems] Fix regression with old marshaled specs having null ↵David Rodríguez
required_rubygems_version https://github.com/rubygems/rubygems/commit/91f07a0208
2022-01-19[rubygems/rubygems] Fix skipped spec on WindowsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/bf0f4b98ee
2022-01-13[rubygems/rubygems] Use `Fiddle` in `bundle doctor` to check for dynamic ↵Vyacheslav Alexeev
library presence https://github.com/rubygems/rubygems/commit/ecd495ce1b
2022-01-04[rubygems/rubygems] Test the actual checksums of the mock gemsNobuyoshi Nakada
https://github.com/rubygems/rubygems/commit/2b42630959
2022-01-04[rubygems/rubygems] Fix the test to use the mock gem pathNobuyoshi Nakada
"NUL.*" means the NUL device on Windows, as well as mere "NUL", and no data is read. https://github.com/rubygems/rubygems/commit/e2c7d22745
2022-01-04[rubygems/rubygems] Append a newline to the checksum fileNobuyoshi Nakada
https://github.com/rubygems/rubygems/commit/48ea2778e9
2022-01-04[rubygems/rubygems] Fix checksumNobuyoshi Nakada
Calculate the checksum of the content, not the given pathname at the build time itself. https://github.com/rubygems/rubygems/commit/b60ee97ee9
2021-12-30[rubygems/rubygems] Better way to join path componentsDavid Rodríguez
The current way works, but error messages show duplicate "/" in paths, which is weird. https://github.com/rubygems/rubygems/commit/9123deb4fa