summaryrefslogtreecommitdiff
path: root/spec/bundler/quality_spec.rb
AgeCommit message (Collapse)Author
2025-11-19[ruby/rubygems] Add `--ext=go` to `bundle gem`Go Sueyoshi
(https://github.com/ruby/rubygems/pull/8183) * Add new gem templates * Add `--ext=go` in `bundle gem` * Add setup-go to .github/workflows/main.yml * Embed go version in go.mod * Use go in bundler CI * Add example method to template * Install Go in .circleci/config.yml * Install Go in .gitlab-ci.yml * Allow hard tabs in go template * Run `rake update_manifest` * Fix test * Move go_gem to gemspec Respect to 9b0ec80 * nits: :golf: * includes valid module name in go.mod * generate header file * Run `go mod tidy` to create `go.sum` * Check if `go.sum` is generated only when Go is installed To avoid test failure in environments where Go is not installed * Run CI * Workaround for hung up c.f. https://github.com/rubygems/rubygems/actions/runs/11639408044/job/32415545422 * Write man for --ext=go * Re-generate man with `./bin/rake man:build` * pinning :pushpin: * Update with `./bin/rake man:build` * nits: Extract to method * nits: Use `sys_exec` instead of `system` * Clean go module cache after test Workaround following error ``` 1) bundle gem gem naming with underscore --ext parameter set with go includes go_gem extension in extconf.rb Failure/Error: FileUtils.rm_r(dir) Errno::EACCES: Permission denied @ apply2files - /home/runner/work/rubygems/rubygems/bundler/tmp/2.2/home/go/pkg/mod/gopkg.in/yaml.v3@v3.0.1/decode_test.go # ./spec/support/helpers.rb:37:in `block in reset!' # ./spec/support/helpers.rb:21:in `each' # ./spec/support/helpers.rb:21:in `reset!' # ./spec/spec_helper.rb:130:in `block (2 levels) in <top (required)>' # /home/runner/work/rubygems/rubygems/lib/rubygems.rb:303:in `load' # /home/runner/work/rubygems/rubygems/lib/rubygems.rb:303:in `activate_and_load_bin_path' ``` Files installed with `go get` have permissions set to 444 ref. https://github.com/golang/go/issues/35615 ``` $ ls -l /home/runner/work/rubygems/rubygems/bundler/tmp/2.2/home/go/pkg/mod/gopkg.in/yaml.v3@v3.0.1/decode_test.go -r--r--r-- 1 runner runner 42320 Nov 15 06:38 /home/runner/work/rubygems/rubygems/bundler/tmp/2.2/home/go/pkg/mod/gopkg.in/yaml.v3@v3.0.1/decode_test.go ``` So they cannot be deleted by `FileUtils.rm_r`. Therefore, this is necessary to execute `go clean -modcache` separately from `FileUtils.rm_r` to circumvent it. * Remove needless changes ref. https://github.com/ruby/rubygems/pull/8183#discussion_r2532902051 * ci: setup-go is needless * Don't run go command in `bundle gem` ref. https://github.com/ruby/rubygems/pull/8183#discussion_r2532765470 * Revert unrelated date changes --------- https://github.com/ruby/rubygems/commit/260d7d60b3 Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org>
2025-11-11[ruby/rubygems] build gems directly instead of shelling outAaron Patterson
I'm trying to speed up the bundler tests. The tests shell out a lot in order to build gems. We can build gems without creating a sub-process. This change reduced the test suite time from ~24 minutes, to about ~21 minutes on my machine. Once we have more of these "asset generation" routines done in the same process, I think we can start caching the outputs for further improvements https://github.com/ruby/rubygems/commit/ebf27056c6
2025-09-11[rubygems/rubygems] Complete remembered options removalDavid Rodríguez
https://github.com/rubygems/rubygems/commit/573ffad3ea
2025-08-18Merge specs checking CLI flags and subcommands are documentedDavid Rodríguez
We had them duplicated, but with slightly different features: * The ones in `other/cli_man_pages.rb` enforced a specific structure to document CLI options, so were less likely to have false positives. * The ones in `quality_spec.rb` were able to check subcommands and their flags. This commit merges both and preserves the best of both.
2025-07-25[rubygems/rubygems] Document missing options from man pages:Edouard CHIN
- The `bundle plugin uninstall --all` was missing. - The `bundle plugin install --local-git` was missing due to being deprecated. We decided to reintroduce the doc for more clarity. https://github.com/rubygems/rubygems/commit/4da252945c
2025-07-25[rubygems/rubygems] Add a quality spec to ensure man pages are up to date:Edouard CHIN
- Ref #8802 - ### Problem Whenever a bundler command options is added, we want to make sure that the associated command man page is updated to reflect the new option (e.g. this mistake was made in #8624) ### Solution In #8802 we discussed a bit on the implementation which would rely on parsing ronn files and introduce some conventions on how options documented in man pages should be written. I figured I would try a simpler approach by just checking if the man page of a command list options using a simple regex. Pros: - Simpler as we don't have to parse ronn files. - No need to modify all existing man pages. Cons: - We can only verify one way (CLI options -> man pages). If a CLI option get removed, we won't be able to warn that the existing document man page option needs to be removed. https://github.com/rubygems/rubygems/commit/e10e60bd33
2025-07-25[rubygems/rubygems] Fix language quality spec no longer getting run properlyDavid Rodríguez
https://github.com/rubygems/rubygems/commit/c65e34a904
2025-06-30[rubygems/rubygems] Use Bundler.settings[gem.bundle]Hiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/b16511598e
2025-06-06[rubygems/rubygems] Extract stdboth spec helperDavid Rodríguez
https://github.com/rubygems/rubygems/commit/bb13f4e702
2025-06-03[rubygems/rubygems] Moved the REMEMBERING OPTIONS section to be after ↵Matthew Hively
CONFIGURATION KEYS Since the remembering options are discouraged, the preferred method should be explained first. Slight tweak to wording Fix documentation spec test as per suggested patch https://github.com/rubygems/rubygems/commit/9f082ccf31
2024-06-28Synchronize Bundler & RubyGems (#11071)David Rodríguez
2023-12-13Normalize bundler bindirDavid Rodríguez
This makes bundler consistent with all other gems, and makes the default installation of Bundler in the release package look like any other bundler installation. Before (on preview3, for example), Bundler executable is installed at: lib/ruby/gems/3.3.0+0/gems/bundler-2.5.0.dev/libexec/bundle Now it's installed in the standard location: lib/ruby/gems/3.3.0+0/gems/bundler-2.5.0.dev/exe/bundle
2023-12-07[rubygems/rubygems] Use modern hashes consistentlyDavid Rodríguez
https://github.com/rubygems/rubygems/commit/bb66253f2c
2023-11-08Escape the target string to be checkedNobuyoshi Nakada
Comparing file paths as strings may not work well for some reasons, symlink, relative `__FILE__`, etc. Some alternatives are possible: comparing with `File.realpath`, or with `File.identical?`, it should be most robust to escape the target string contained within this file itself.
2023-10-22[rubygems/rubygems] Fix spelling of extraneousMartin Emde
https://github.com/rubygems/rubygems/commit/af61829432
2023-02-21Merge rubygems/bundler masterHiroshi SHIBATA
Pick from https://github.com/rubygems/rubygems/commit/e9304aed7e43308b99e70c2f7b92028315fee8a5 Notes: Merged: https://github.com/ruby/ruby/pull/7345
2022-12-13[rubygems/rubygems] Use better matcherDavid Rodríguez
Hopefully it gives a better error. https://github.com/rubygems/rubygems/commit/5bc9ff64b6 Notes: Merged: https://github.com/ruby/ruby/pull/6914
2022-12-12Merge RubyGems/Bundler masterHiroshi SHIBATA
from https://github.com/rubygems/rubygems/commit/bfb0ae69776069155d2092702bfbb5a12617d85a Notes: Merged: https://github.com/ruby/ruby/pull/6906
2022-09-05Merge ↵Hiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/16c3535413afebcdbab7582c6017c27b5da8a8dc Notes: Merged: https://github.com/ruby/ruby/pull/6326
2022-08-03Merge rubygems/bundler HEADHiroshi SHIBATA
Pick from https://github.com/rubygems/rubygems/commit/8331e63263081a6aa690d8025d2957f30c4e814a Notes: Merged: https://github.com/ruby/ruby/pull/6209
2021-10-29[rubygems/rubygems] use Rubocop Lint/Debugger check rather than custom specFrederik Dudzik
We have a quality spec that check for debugger statements. Rubocop has a cop that tests for the same thing. As such it makes sense to remove the spec and activate the cop. https://github.com/rubygems/rubygems/commit/dc1eb6eec5
2021-05-11Sync bundler & rubygemsDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/4367
2021-04-15Merge the master branch of BundlerHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/4383
2021-03-08Sync latest development version of bundler & rubygemsDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/4143
2021-01-04Track Bundler master(2.3.0.dev) branch at ↵Hiroshi SHIBATA
55634a8af18a52df86c4275d70fa1179118bcc20 Notes: Merged: https://github.com/ruby/ruby/pull/4021
2020-12-08Merge prepare version of Bundler 2.2.0Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3864
2020-10-15Merge bundler-2.2.0.rc.2Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3659
2020-06-18s/sys_exec!/sys_execDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-06-05[rubygems/rubygems] Support running specs against a tarballDavid Rodríguez
When bundler specs are run from a ruby tarball (ruby-core does this), there's no git folder, so `git ls-files` fails. Support this case by making specs rely on the list of files from the bundler gemspec instead, and invert the spec that makes sure we ship the right set of files. As per the other quality specs, skip them in this case. https://github.com/rubygems/rubygems/commit/b28d5ec931 Notes: Merged: https://github.com/ruby/ruby/pull/3184
2020-05-25Fix failures in ./spec/bundler/quality_spec.rbKazuhiro NISHIYAMA
``` Failures: 1) The library itself does not contain any warnings Failure/Error: raise "Invoking #{method}!(#{args.map(&:inspect).join(", ")}) failed:\n#{last_command.stdboth}" RuntimeError: Invoking sys_exec!("ruby -w") failed: /home/user/snapshot-master/lib/bundler/cli/add.rb:4:in `<module:Bundler>': uninitialized constant Bundler::CLI (NameError) from /home/user/snapshot-master/lib/bundler/cli/add.rb:3:in `<top (required)>' from /home/user/snapshot-master/lib/rubygems/core_ext/kernel_require.rb:91:in `require' from /home/user/snapshot-master/lib/rubygems/core_ext/kernel_require.rb:91:in `require' from -:2:in `<main>' Commands: $ ruby -w /home/user/snapshot-master/lib/bundler/cli/add.rb:4:in `<module:Bundler>': uninitialized constant Bundler::CLI (NameError) from /home/user/snapshot-master/lib/bundler/cli/add.rb:3:in `<top (required)>' from /home/user/snapshot-master/lib/rubygems/core_ext/kernel_require.rb:91:in `require' from /home/user/snapshot-master/lib/rubygems/core_ext/kernel_require.rb:91:in `require' from -:2:in `<main>' # $? => 1 ```
2020-05-22Sync Bundler PR #3624Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3114
2020-05-13Use relative path in ruby core repositoryHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3086
2020-05-13Update the bundler version with master branchHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3086
2019-08-20Fix some bundler specs (#2380)David Rodríguez
* These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
2019-08-17[bundler/bundler] Extract yet another helper methodDavid Rodríguez
https://github.com/bundler/bundler/commit/948a863bd8
2019-08-17[bundler/bundler] Extract a `with_root_gemspec` helperDavid Rodríguez
https://github.com/bundler/bundler/commit/f20c2bdf6a
2019-08-17[bundler/bundler] Only chdir when necessaryDavid Rodríguez
https://github.com/bundler/bundler/commit/07161ebc1a
2019-08-17[bundler/bundler] Make sure gem has been built before deleteng itDavid Rodríguez
https://github.com/bundler/bundler/commit/32520c7020
2019-08-17[bundler/bundler] Cleanup in a location independent wayDavid Rodríguez
https://github.com/bundler/bundler/commit/5b503a4bf1
2019-08-17[bundler/bundler] Remove obvious commentDavid Rodríguez
https://github.com/bundler/bundler/commit/91e7fe1b2f
2019-08-17[bundler/bundler] Remve another unneeded `to_s`David Rodríguez
`FileUtils.rm` supports a `Pathname` argument. https://github.com/bundler/bundler/commit/7d982a5be9
2019-08-17[bundler/bundler] Remove unneeded `to_s` callsDavid Rodríguez
They are implicit inside `gem_command!`. https://github.com/bundler/bundler/commit/6bdb13c899
2019-08-17[bundler/bundler] Extract a `lib_tracked_files` path helperDavid Rodríguez
https://github.com/bundler/bundler/commit/028dc46f5a
2019-08-17[bundler/bundler] Rename a variableDavid Rodríguez
Otherwise I get conflicts when extracting the helper. https://github.com/bundler/bundler/commit/314c64cd07
2019-08-17[bundler/bundler] Extract a `tracked_files` path helperDavid Rodríguez
https://github.com/bundler/bundler/commit/d35e31d2e0
2019-08-17[bundler/bundler] Rename some variablesDavid Rodríguez
I want to extract these to path helper methods, but the name `files` conflict with some builder methods that are also available at the same level. https://github.com/bundler/bundler/commit/7844096af0
2019-08-16[bundler/bundler] Remove unexistent folder from exemptionsDavid Rodríguez
https://github.com/bundler/bundler/commit/0b6d973543 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Commit man pages to source controlDavid Rodríguez
This has the benefit that: * Allows the installation of bundler as a default gem from rubygems to include man pages. * Removes the need to build man pages during our tests. * Makes working with the manifest easier, because we only have source controlled files, and not a mix of source control and generated files. To make sure they never fall out of sync, we replace the previous `man:build` CI task with a `man:check` task that makes sure the generated man pages are up to date. https://github.com/bundler/bundler/commit/23de1d0177 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Remove unexistent file from exemptionsDavid Rodríguez
https://github.com/bundler/bundler/commit/8601575490 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-03[bundler/bundler] Check for straneous quotesDavid Rodríguez
And use single quotes consistenly. https://github.com/bundler/bundler/commit/8b9fbbb2df
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-14 16:37:46 +0000