summaryrefslogtreecommitdiff
path: root/spec/bundler/commands
AgeCommit message (Collapse)Author
2020-03-27Merge bundler-2.1.4Hiroshi SHIBATA
2019-12-18Merge bundler-2.1.1 from bundler/bundlerHiroshi SHIBATA
2019-12-15Fixed test failures with gem command path on ruby core repo.Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/2753
2019-12-15Prepare to release bundler-2.1.0Hiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/2753
2019-11-19Allow unknown if ruby coreKazuhiro NISHIYAMA
Notes: Merged: https://github.com/ruby/ruby/pull/2683
2019-11-13Merge Bundler 2.1.0.pre3 released versionHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/2674
2019-11-11Merge Bundler 2.1.0.pre.3Hiroshi SHIBATA
Features: - Add caller information to some deprecation messages to make them easier to fix [#7361](https://github.com/bundler/bundler/pull/7361) - Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](https://github.com/bundler/bundler/pull/7389) - Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](https://github.com/bundler/bundler/pull/7394) Bugfixes: - Fix typos deprecation message and upgrading docs [#7374](https://github.com/bundler/bundler/pull/7374) - Deprecation warnings about `taint` usage on ruby 2.7 [#7385](https://github.com/bundler/bundler/pull/7385) - Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](https://github.com/bundler/bundler/pull/7388) - `bundle add` should cache newly added gems if an application cache exists [#7393](https://github.com/bundler/bundler/pull/7393) - Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](https://github.com/bundler/bundler/pull/7416) - Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](https://github.com/bundler/bundler/pull/7417) Notes: Merged: https://github.com/ruby/ruby/pull/2668
2019-09-18[bundler/bundler] Merge all `bundle check --path` specsDavid Rodríguez
And skip them all for bundler 3. https://github.com/bundler/bundler/commit/b88936cdc2
2019-09-18[bundler/bundler] Merge #7340Bundlerbot
7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that `bundle clean` is crashing under some conditions. ### What was your diagnosis of the problem? My diagnosis was that sometimes (when the bundle includes git sourced gems with extensions), it assumes that some paths exist, but they don't. ### What is your fix for the problem, implemented in this PR? My fix is to ignore those paths. ### Why did you choose this fix out of the possible options? I chose this fix because it fixes the issue. Fixes #7338. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit b007fde67c77c1f15f13b97eda186644c2a2be04) https://github.com/bundler/bundler/commit/3766053507
2019-09-18[bundler/bundler] Remove duplicated spec filterDavid Rodríguez
https://github.com/bundler/bundler/commit/b7fc6f4187
2019-08-23Remove github_action_linux tag from bundler examples.Hiroshi SHIBATA
Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa Notes: Merged: https://github.com/ruby/ruby/pull/2399
2019-08-21[bundler/bundler] Fix a couple of typosDavid Rodríguez
https://github.com/bundler/bundler/commit/52b6b94068
2019-08-20Fix some bundler specs (#2380)David Rodríguez
* These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
2019-08-18Skip open_spec.rb:L95 because ruby repo doesn't have json as default gems.Hiroshi SHIBATA
2019-08-18[bundler/bundler] Remove unnecessary rubygems monkeypatchDavid Rodríguez
Instead, make sure we always load the local copy of bundler during specs, and never end up using the default copy. https://github.com/bundler/bundler/commit/ac655ffeda
2019-08-18[bundler/bundler] Don't use system bundler on this specDavid Rodríguez
If we use system bundler, when booting the "outermost" bundler process, bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and use it again when booting the "innermost" bundler process (`bundle exec echo foo`). That means that second process will use the system bundler path again. However, we have `-rsupport/hax` in RUBYOPT, so that file will load from the local copy of bundler, and that file will load `bundler/version` from the project (not from system), because -Ilib is in the LOAD_PATH. That will end up causing redefinition errors because the same constant will be loaded from two different locations. In general, this is expected behavior, normally you will wrap the process with `Bundler.with_original_env` to reset the environment. However, the easiest fix here is to not use system bundler, because it's not really necessary and thus doesn't help the readability of the spec. https://github.com/bundler/bundler/commit/a3d72a34ab
2019-08-18[bundler/bundler] Fix spec using the deprecated `bundle config` modeDavid Rodríguez
https://github.com/bundler/bundler/commit/789dd1864f
2019-08-18[bundler/bundler] Fix open default gem errorZehan Zhao
https://github.com/bundler/bundler/commit/792d724752
2019-08-18[bundler/bundler] Wrap `open` specs with a contextDavid Rodríguez
So I can add another context that doesn't run the `before` block. https://github.com/bundler/bundler/commit/06d0acc45a
2019-08-18[bundler/bundler] Prefer `before` to `before :each`David Rodríguez
https://github.com/bundler/bundler/commit/6678747fae
2019-08-18[bundler/bundler] Fix `bundle doctor` commandDavid Rodríguez
Previously `bundle doctor` would fail on any bundle that does not include git gems or plugins. This is because the previously used `Bundler.home` does not exist unless the bundle includes git gems or plugins. For example, with `bundle config set path .bundle`, it points to which does not exist unless this kind of gems exist in the Gemfile. The name `Bundler.home` is really unfortunate, it should probably be have more descriptive name, and be private. But for now I just want to make `bundle doctor` usable. https://github.com/bundler/bundler/commit/5531a18c1e
2019-08-18[bundler/bundler] Bundler displays a duplicate gem entries warning even if ↵David Stosik
gems only appear once per group https://github.com/bundler/bundler/commit/d18a83109e
2019-08-17[bundler/bundler] Extract a `gemspec_dir` helperDavid Rodríguez
https://github.com/bundler/bundler/commit/71a29e286a
2019-08-17[bundler/bundler] Reconcile testDavid Rodríguez
The `:bundler` gem is not needed in the regular repo either. https://github.com/bundler/bundler/commit/ca5ce01a9b
2019-08-17[bundler/bundler] Reuse `gem_command!` helperDavid Rodríguez
https://github.com/bundler/bundler/commit/37d5dedffe
2019-08-17[bundler/bundler] Reuse more shared path helpersDavid Rodríguez
https://github.com/bundler/bundler/commit/79fdebd868
2019-08-17[bundler/bundler] Remove duplicated methodDavid Rodríguez
https://github.com/bundler/bundler/commit/afdacd62ac
2019-08-16[bundler/bundler] Add `--[no-]git` option to `bundle gem`David Rodríguez
I think using `--no-git` can be useful when creating gems inside monorepos. https://github.com/bundler/bundler/commit/154c687310 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Revert "make system_bundle_bin_path helper and resolve ↵David Rodríguez
failing tests for ruby < 2.6" This reverts commit e63e844bc7444c6a489fcde0dc7011c6c4807edd. It was introduced to resolve some failing tests at the cost of making the intention of the spec much less clear. Thanks to the previous fixes we have added to this spec, we can revert that patch now. https://github.com/bundler/bundler/commit/b29a40820f Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Make sure spec fails if `bundle install` failsDavid Rodríguez
https://github.com/bundler/bundler/commit/2ed2bbfdec Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Fix installation of system bundlerDavid Rodríguez
Previously it was being installed to the :bundle_path (`/tmp/bundled_app/.bundle`), but the `bundle` helper uses the `system_gem_path("bin/bundle")`. That means the first `bundle install`in the spec was actually failing, but not affecting the test status because of not being called as `bundle!`. https://github.com/bundler/bundler/commit/ad75f75539 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Use non deprecated way of setting bundler pathDavid Rodríguez
https://github.com/bundler/bundler/commit/6013c93e81 Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-16[bundler/bundler] Clarify spec descriptionDavid Rodríguez
https://github.com/bundler/bundler/commit/b2abde04aa Notes: Merged: https://github.com/ruby/ruby/pull/2366
2019-08-12Added example filter for Linux of GitHub Actions.Hiroshi SHIBATA
2019-08-09Fix typo: duplicated the [skip-ci]ohbarye
2019-08-03Fixed up 365ee22d73ec73c119a842de271504e04bed6f45Hiroshi SHIBATA
2019-08-03Fixed the broken example with ruby core structure.Hiroshi SHIBATA
2019-08-03[bundler/bundler] Always set `cache_all` via config during testsDavid Rodríguez
So that the behavior is the same regardless of the tested bundler version. https://github.com/bundler/bundler/commit/664549427a
2019-08-03[bundler/bundler] Enable `Style/UnneededInterpolation` copDavid Rodríguez
https://github.com/bundler/bundler/commit/4c6a3c3cf7
2019-08-03[bundler/bundler] Move duplicated code to `before` blocksGuillermo Guerrero
https://github.com/bundler/bundler/commit/69bee117fb
2019-08-03[bundler/bundler] Remove unnecessary indirectionsDavid Rodríguez
These specs are only run on bundler 2, so the compatibility method is not needed. https://github.com/bundler/bundler/commit/6cb28e3aeb
2019-08-03[bundler/bundler] Try make some specs platform independentDavid Rodríguez
https://github.com/bundler/bundler/commit/b5900e57a4
2019-08-03[bundler/bundler] Update error messages to be more preciseDavid Rodríguez
https://github.com/bundler/bundler/commit/9ddeeb1fe1
2019-08-03[bundler/bundler] Use a consistent requirement in binstubDavid Rodríguez
https://github.com/bundler/bundler/commit/50ccdb32c2
2019-08-03[bundler/bundler] Drop rubygems 2.5.0 and 2.5.1 supportDavid Rodríguez
https://github.com/bundler/bundler/commit/8ecd722b9f
2019-08-03[bundler/bundler] Correct a rubygems test filterDavid Rodríguez
It seems to pass under rubygems 2.5.2. https://github.com/bundler/bundler/commit/062cd2be7c
2019-08-03[bundler/bundler] Remove unnecessary test filterDavid Rodríguez
Since it covers the whole range we support. https://github.com/bundler/bundler/commit/c0b9d4e6c6
2019-08-03[bundler/bundler] Refactor some specsDavid Rodríguez
https://github.com/bundler/bundler/commit/785c7af1f3
2019-08-03[bundler/bundler] Reuse `lockfile` spec helperDavid Rodríguez
https://github.com/bundler/bundler/commit/e6a03f1102
2019-08-03[bundler/bundler] Reuse `gemfile` spec helperDavid Rodríguez
https://github.com/bundler/bundler/commit/22de94d3b4