summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2025-02-28[rubygems/rubygems] Retry gracefully on blank partial response in compact indexMartin Emde
https://github.com/rubygems/rubygems/commit/fafb9ae090
2025-02-27[ruby/cgi] Bump up v0.4.2Hiroshi SHIBATA
https://github.com/ruby/cgi/commit/ab84b7fe66
2025-02-27[ruby/cgi] Bump up 0.4.2.beta2Hiroshi SHIBATA
https://github.com/ruby/cgi/commit/8e6fb1041b
2025-02-27[rubygems/rubygems] Remove MD5 digesting of compact index responsesMartin Emde
It has been over a year since the release, so let's stop MD5ing everything https://github.com/rubygems/rubygems/commit/29ef4ca30b
2025-02-27[rubygems/rubygems] Improve error message when on read-only filesystemsDavid Rodríguez
If we fail to write the lockfile, give a better error. https://github.com/rubygems/rubygems/commit/81a08d6eda
2025-02-27[ruby/uri] Use a fully qualified name in warning messagesyuuji.yaginuma
Currently, some warning messages don't contain a `URI` like the following. ```ruby warning: URI::ABS_URI is obsolete. Use RFC2396_PARSER.regexp[:ABS_URI] explicitly. ``` But, without `URI` prefix, the suggested value doesn't work. So I think we should use a fully qualified name to avoid confusion. https://github.com/ruby/uri/commit/428eb10e44
2025-02-27[ruby/uri] Fix the mention to removed `URI.escape/URI::Escape`Yuji Yaginuma
This was removed by #9. https://github.com/ruby/uri/commit/fec924238f
2025-02-26[ruby/cgi] Escape/unescape unclosed tags as wellHiroshi SHIBATA
https://github.com/ruby/cgi/commit/cd1eb08076 Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2025-02-26[ruby/cgi] Use String#concat instead of String#+ for reducing cpu usageHiroshi SHIBATA
https://github.com/ruby/cgi/commit/9907b76dad Co-authored-by: "Yusuke Endoh" <mame@ruby-lang.org>
2025-02-26[ruby/uri] Bump up v1.0.3Hiroshi SHIBATA
https://github.com/ruby/uri/commit/3213f4a0f8
2025-02-26[ruby/uri] Fix merger of URI with authority componentHiroshi SHIBATA
https://hackerone.com/reports/2957667 https://github.com/ruby/uri/commit/2789182478 Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2025-02-26[ruby/uri] Truncate userinfo with URI#join, URI#merge and URI#+Hiroshi SHIBATA
https://github.com/ruby/uri/commit/3675494839
2025-02-26[ruby/cgi] Bump up 0.4.2.beta1Hiroshi SHIBATA
https://github.com/ruby/cgi/commit/3f5b4ed9e9
2025-02-25[ruby/prism] Restore a comment for `Prism::Translation::Parser#initialize`Koichi ITO
This restores the missing method comments in https://github.com/ruby/prism/pull/3479. https://github.com/ruby/prism/commit/78b8f67dee
2025-02-25[ruby/prism] Fix merge mishapEarlopain
Caused by https://github.com/ruby/prism/pull/3478 and https://github.com/ruby/prism/pull/3443 I also made the builder reference more explicit to clearly distinquish between `::Parser` and `Prism::Translation::Parser` https://github.com/ruby/prism/commit/d52aaa75b6
2025-02-25[ruby/prism] Add a custom builder class for the parser translatorEarlopain
I want to add new node types to the parser translator, for example `itblock`. The bulk of the work is already done by prism itself. In the `parser` builder, this would be a 5-line change at most but we don't control that here. Instead, we can add our own builder and either overwrite the few methods we need, or just inline the complete builder. I'm not sure yet which would be better. `rubocop-ast` uses its own builder for `parser`. For this to correctly work, it must explicitly choose to extend the prism builder and use it, same as it currently chooses to use a different parser when prism is used. I'd like to enforce that the builder for prism extends its custom one since it will lead to some pretty weird issues otherwise. But first, I'd like to change `rubocop-ast` to make use of this. https://github.com/ruby/prism/commit/b080e608a8
2025-02-25[ruby/prism] Support custom parser in `Prism::Translation::Parser`Koichi ITO
Follow-up to https://github.com/Shopify/ruby-lsp/pull/1849. This is an extension of `Prism::Translation::Parser` to implement https://github.com/Shopify/ruby-lsp/pull/1849. It is based on the comments in https://github.com/Shopify/ruby-lsp/pull/1849#pullrequestreview-1966020868, but also adds a default argument for delegation to `Parser::Base` super class. Using this API, https://github.com/rubocop/rubocop-ast/pull/359 has been implemented in RuboCop AST. As detailed in https://github.com/rubocop/rubocop-ast/pull/359, this change is expected to improve performance by 1.3x for some source code. Achieving a 1.3x speedup with such this simple modification is a significant improvement for Ruby LSP and its users. https://github.com/ruby/prism/commit/925725291c
2025-02-25[rubygems/rubygems] Improve log message about adding a new platformDavid Rodríguez
This message is printed when running `bundle lock --add-platform`. This command affects the lockfile, not the gemfile, and I think it's better to use "You are adding" rather than "You added", because the addition is happening during the current invocation (as opposed to other log messages that talk about a change made to the Gemfile prior to running the command). https://github.com/rubygems/rubygems/commit/aba1e55f5b Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[rubygems/rubygems] Refactor handling platform removalsDavid Rodríguez
And make it consistent with platform additions. https://github.com/rubygems/rubygems/commit/64342ae404 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[rubygems/rubygems] Improve log message when resolving due to local platform ↵David Rodríguez
not in lockfile Current it says "you added a new platform to your gemfile", but that's not actually the case here. https://github.com/rubygems/rubygems/commit/1e39527a38 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[rubygems/rubygems] Modify `bundle doctor` to not report issue when files ↵Edouard CHIN
aren't writable: - ### Problem Running `bundle doctor` warn about files that aren't writable. This makes the output of `bundle doctor` very verbose for something I believe isn't really an issue. ### Context Rubygems keeps the files original permission at the time the gem is packaged. Many gem maintainers have decided that the permissions of the files in their bundled would be 0444, this includes amongst others: minitest, selenium, brakeman... Any git gems that had a 0444 permissions at some point in its git history would also be reported (as bundle doctor look in the `cache/bundler/git/<gem>/object` path). While it completely make sense to report when files aren't readable, maybe it's worth questioning the usefulness of reporting files that can't be written and what problem this causes to the user (if any). ### Solution Removed the check for unwritable file. ### Side note I also tweaked the "No issues ..." message logic as it was doing the opposite (reporting an issue when there is none and vice versa). This wasn't caught in tests because as a stub on `Bundler.ui.info` was missing. https://github.com/rubygems/rubygems/commit/9a426b9495 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[ruby/pp] Ensure the thread local state is always set up.Samuel Williams
(https://github.com/ruby/pp/pull/38) https://github.com/ruby/pp/commit/5b5d483ac2
2025-02-21[ruby/cgi] Use license files same as ruby/rubyHiroshi SHIBATA
https://github.com/ruby/cgi/commit/defbdf9a30
2025-02-21[rubygems/rubygems] Allow noop `bundle install` to work on read-only or ↵David Rodríguez
protected folders As long as there's nothing new to install and gems are already there. If not, give a meaningful error about what happened. This was how things already worked until https://github.com/rubygems/rubygems/commit/345ec45f5a87, so this commit partially reverts that change. https://github.com/rubygems/rubygems/commit/794b0ecb39
2025-02-21[rubygems/rubygems] bin/rubocop -a --only Style/MultipleComparisonHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/677e17aa2e
2025-02-21[rubygems/rubygems] Fix resolver issue due to ill-defined version ranges ↵David Rodríguez
being created https://github.com/rubygems/rubygems/commit/f2f2ac9680
2025-02-20[rubygems/rubygems] gem server command is extracted from rubygems core ↵Hiroshi SHIBATA
feature now https://github.com/rubygems/rubygems/commit/b29f8d6a37
2025-02-20[rubygems/rubygems] Fix lockfile platforms inconveniently added on JRubyDavid Rodríguez
When working with our repository on JRuby locally, I get the following changes when running `bin/rake setup` in all of our lockfiles ```diff diff --git a/tool/bundler/dev_gems.rb.lock b/tool/bundler/dev_gems.rb.lock index https://github.com/rubygems/rubygems/commit/362bf25690d..https://github.com/rubygems/rubygems/commit/74550b2a408 100644 --- a/tool/bundler/dev_gems.rb.lock +++ b/tool/bundler/dev_gems.rb.lock @@ -66,6 +66,7 @@ PLATFORMS java ruby universal-java + universal-java-22 x64-mingw-ucrt x86-linux x86_64-darwin ``` This is inconvenient, so I applied the same strategy we already use on non JRuby implementations to not add the current platform to the lockfile if a less specific platform is already there. https://github.com/rubygems/rubygems/commit/812b9cd1e8
2025-02-19[rubygems/rubygems] Make sure empty gems are not reinstalled every timeDavid Rodríguez
Unfortunately this requires reverting a previous enhancement of reinstalling gems if they incorrectly ship with an empty installation dir. However, there's no way to distinguish this kind of bad state from a gem that's empty for real, for example, sorbet-static-and-runtime. This reverts commit https://github.com/rubygems/rubygems/commit/9720a9b980d2, and adds a spec to make sure empty gems are not reinstalled every time. https://github.com/rubygems/rubygems/commit/7c102394af
2025-02-18[rubygems/rubygems] Fix Bundler incorrectly downgrading direct dependenciesDavid Rodríguez
There's no reason to call `converge_specs` when adding additional lower bound requirements to prevent downgrades, and it actually causes the extra requirements to be missed sometimes. Loop over the originally locked specs directly, adding the additional precaution of not adding the requirement if the Gemfile dependency has changed and it no longer matches the locked spec. https://github.com/rubygems/rubygems/commit/5154506912
2025-02-18[rubygems/rubygems] Don't try to skip requirements to prevent downgradesDavid Rodríguez
These don't really hurt, so I'm not sure why I introduced it. https://github.com/rubygems/rubygems/commit/85b6b405ac
2025-02-18[rubygems/rubygems] Fix locked gems being upgraded when locked dependencies ↵David Rodríguez
are incorrect Resolver had internal logic to prioritize locked versions when sorting versions, however part of it was not being actually hit because of how unlocking worked in the resolver: a package was allow to be unlocked when that was explicit requested or when the list of unlocks was empty. That did not make a lot of sense and other cases were working because the explicit list of unlocks was getting "artificially filled". Now we consider a package unlocked when explicitly requested (`bundle update <package>`), or when everything is being unlocked (`bundle install` with no lockfile or `bundle update`). This makes things simpler and gets the edge case added as a test case working as expected. https://github.com/rubygems/rubygems/commit/b8e55087f0
2025-02-18[rubygems/rubygems] Refactor finding dependency changesDavid Rodríguez
https://github.com/rubygems/rubygems/commit/d8c4754d8f
2025-02-18[rubygems/rubygems] Improve processing and categorizing unlock informationDavid Rodríguez
https://github.com/rubygems/rubygems/commit/516430c3ec
2025-02-17[rubygems/rubygems] Make Bundler never instantiate development dependenciesDavid Rodríguez
Bundler does not really have a concept of "development dependencies", like RubyGems has. Bundler has the more generic concept of "groups". Under the hood, the `gemspec` DSL will put gemspec development dependencies under a `:development` Gemfile group, but there's no reason to instantiate these as development dependencies, they are regular runtime dependencies, except that they belong in a group named :development. By never instantiating development dependencies at all, we avoid having to introduce hacks to "undo" the type Bundler does not know about, and I also think the error messages read better. https://github.com/rubygems/rubygems/commit/9a06fa5bda
2025-02-14[rubygems/rubygems] Reset existing specs when using `Bundler::SpecSet#[]=`David Rodríguez
We have a flaky failure where to equal Bundler specs sneak into the same SpecSet. This seems like a vector where that could happen so trying this in case it fixes the flaky. https://github.com/rubygems/rubygems/commit/a33aeb3c4d
2025-02-14[rubygems/rubygems] Refactor SpecSet to not need resetDavid Rodríguez
https://github.com/rubygems/rubygems/commit/55af558124
2025-02-14[rubygems/rubygems] Simplify hacks to integrate with RubyGemsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/33d91de732
2025-02-14[rubygems/rubygems] Simplify SpecSet#sortedDavid Rodríguez
https://github.com/rubygems/rubygems/commit/a3f365bbaa
2025-02-14[rubygems/rubygems] Raise error when lockfile is missing deps in frozen modeDavid Rodríguez
And avoid installing any gems. https://github.com/rubygems/rubygems/commit/c12700c7e4
2025-02-14[rubygems/rubygems] Deprecate legacy windows platforms (mswin, mingw) in the ↵johnnyshields
Bundler DSL, in favor of using `platform :windows` This commit is only deprecation and does not change/remove any actual functionality. https://github.com/rubygems/rubygems/commit/0ca6dc3984
2025-02-14[rubygems/rubygems] Fix legacy windows platform values no longer workingDavid Rodríguez
https://github.com/rubygems/rubygems/commit/de8b3016db
2025-02-13[ruby/prism] No writing to numbered parametersKevin Newton
Fixes [Bug #21117] https://github.com/ruby/prism/commit/19d4bab5a0
2025-02-13[Feature #21116] Extract RJIT as a third-party gemNobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/12740
2025-02-13[rubygems/rubygems] `--prefer-local` should resolve to latest version if no ↵David Rodríguez
gems are available locally Filtering out remote specs should only apply where there are locally installed specs. Otherwise they should always be considered. https://github.com/rubygems/rubygems/commit/118f8389a1
2025-02-13[rubygems/rubygems] Fix incorrect error message in frozen modeDavid Rodríguez
When Bundler refuses to install in frozen mode, sometimes it would incorrectly claim that some dependencies have been added to the Gemfile when that's not really the case. Fix that by making sure `locked_dependencies` always has all locked dependencies, even when unlocking, Additionally, the suggestion to run `bundle install` is also confusing when unlocking, since `bundle update` is what has been run. So skip that part as well when unlocking. https://github.com/rubygems/rubygems/commit/64d84ad7d8
2025-02-13[rubygems/rubygems] Fix `type` and `gemfile` not getting reported as invalid ↵David Rodríguez
options https://github.com/rubygems/rubygems/commit/5b6077a1e8
2025-02-13[rubygems/rubygems] Materializing specs for vendor/cache should not be strictDavid Rodríguez
Platforms specific gems not compatible with the current Ruby should not make `bundle cache` fail and should not get removed from the cache since they still may be useful in other rubies. https://github.com/rubygems/rubygems/commit/717b43f565
2025-02-13[rubygems/rubygems] Move logic to materialize gems for cache to a new methodDavid Rodríguez
And make the current `materialize_strictly` private. https://github.com/rubygems/rubygems/commit/3fc2129147
2025-02-13[rubygems/rubygems] Remove unnecessary source changeDavid Rodríguez
We materializing for installation, we already do this, and we materializing for cache, it does not seem necessary. https://github.com/rubygems/rubygems/commit/1a983c6cbc