Age | Commit message (Collapse) | Author |
|
Closes https://github.com/rubygems/rubygems/issues/4889
https://github.com/rubygems/rubygems/commit/2b1754479c
|
|
https://github.com/rubygems/rubygems/commit/9978b787a0
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Same reason as in the previous commit.
https://github.com/rubygems/rubygems/commit/f00a6c8516
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/95326f827c
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/2ee3e78a7a
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags
Running jobs with only branch name, without `branches:`, CI fails
https://github.com/rubygems/rubygems/commit/fcec167d61
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
values returned
https://github.com/rubygems/rubygems/commit/601b5553bb
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
versions
https://github.com/rubygems/rubygems/commit/9c88db949d
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
The error had not be caught be specs because `bundle install` was
returning a zero exit code when plugin installation errors happened. So
I fixed that issue too.
https://github.com/rubygems/rubygems/commit/90cde87856
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/9620bee2a5
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/290b6ab078
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
If the lockfile contains multiple platforms, `bundle check` would show
duplicated missing gems.
https://github.com/rubygems/rubygems/commit/6ac5931783
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
local mode
https://github.com/rubygems/rubygems/commit/1b8139e9d3
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
As part of a recent bug fix where bundler was accidentally hitting the
network when not supposed to, I made some refactoring, and the commit I'm
reverting here
(https://github.com/rubygems/rubygems/commit/d74830d00bb541883377992f56818620a78930b0)
was some cleanup that those refactorings allowed according to "past me".
That was completely wrong, `bundle check` should never consider cached
gems, only installed gems, so the code that was removed was necessary.
https://github.com/rubygems/rubygems/commit/5483e98305
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/58da501e5d
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/0822e1c260
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/58fc31442f
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
When setting the `RUBYGEMS_GEMDEPS` environment variable to allow
skipping `bundle exec`, `bundler` will print a warning about potential
incompatibility.
Initially the `RUBYGEMS_GEMDEPS` variable used a completely different
(re)implementation of `bundler` functionality. That implementation was
not battle tested and could potentially differ in behaviour from what
`bundler` does. That's why print a warning.
However, these days, all `rubygems` does when `RUBYGEMS_GEMDEPS` is set
is to require `bundler/setup`, so there's no risk of any
incompatibility, since that's just plain `bundler`.
https://github.com/rubygems/rubygems/commit/bbddc27016
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
generated config
Even if it only has one entry at the moment, it makes it easier to add
new entries by doing it this way.
https://github.com/rubygems/rubygems/commit/46232fe265
Co-authored-by: NeimadTL <damientalbot26@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
config
Otherwise CI will run once for every pull request update and once for
every push.
The disavantage is that people working on a non default branch without
creating pull requests won't get CI run at all.
I think the advantages are greater than the disadvantages, it's also my
personal workflow, and it's something desired enough so that someone
opened an issue about it.
So let's do it!
https://github.com/rubygems/rubygems/commit/924d916a73
Co-authored-by: NeimadTL <damientalbot26@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/c31b8cd232
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/a2d6e10192
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/591466d512
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/ed845d861c
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/88b7a3e7e2
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
The processed YML data is included as metadata, the source gemspec
file is unused and just confusing.
https://github.com/rubygems/rubygems/commit/f444478eac
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
between sentence breaks
https://github.com/rubygems/rubygems/commit/5cdda53382
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/d74830d00b
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
network
If the cache was missing, `bundler` would try to re-fetch it. With the
`--local` flag, it should just look at installed gems.
https://github.com/rubygems/rubygems/commit/630d29c69e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/06f5efce02
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
When printing sources inside these error messages, it's useful to only
consider the current state of the source. For example, when requiring
`bundler/setup`, the source shouldn't be configured to be able to hit
the network, so the error message should only mention "locally installed
gems" to make that more clear.
https://github.com/rubygems/rubygems/commit/30eb14f853
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/9fd39bd5a3
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Since all requirements have an explicit source now (even if it's the
default source).
https://github.com/rubygems/rubygems/commit/2c341cfc22
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
It doesn't really add much, in my opinion. We want to be helpful, but
also concise when possible.
https://github.com/rubygems/rubygems/commit/9d56009cf7
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
In the case of path sources, the path the source is pointing to should
be added directly to the `$LOAD_PATH` without any modifications.
https://github.com/rubygems/rubygems/commit/d3bba936f0
Co-authored-by: Daniel Niknam <mhmd.niknam@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Under some case, this variable might not end up being used, in which
case running the script would print unused variable warnings.
https://github.com/rubygems/rubygems/commit/bf96030362
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/fcb8c3d188
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Under some case, this variable might not end up being used, in which
case running the script would print unused variable warnings.
https://github.com/rubygems/rubygems/commit/a2d6392ada
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
We can use `__dir__` directly.
https://github.com/rubygems/rubygems/commit/0e6083ca94
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Due to the `bundler` gem itself being ignored from `$LOAD_PATHS`, a
`nil` value is being introduced here, resulting in the current folder
being added to the `$LOAD_PATH` by the standalone script.
I'm pretty sure this is unintentional.
https://github.com/rubygems/rubygems/commit/df54b07b5e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
This should fix a weird flaky spec failure, given that the code
producing the error will be no longer run.
https://github.com/rubygems/rubygems/commit/a171965409
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/f28ab141af
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
No need to fill up missing names from sources anymore since they should
now be properly set up correctly from the beginning.
https://github.com/rubygems/rubygems/commit/706fd28681
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
compatibility mode
Since this mode is only enabled in frozen mode, it's fine to use the
lockfile and means we don't have to "prepare" the replacement for
materialization.
https://github.com/rubygems/rubygems/commit/dda01b288e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Rubygems source replacement was broken.
https://github.com/rubygems/rubygems/commit/3549c122f6
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/98f5087e34
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Bundler formatters already take care of this.
https://github.com/rubygems/rubygems/commit/c24415fdd5
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
If we have succeeded to materialize the bundle, all specs should be
loaded.
https://github.com/rubygems/rubygems/commit/bd3712d824
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
installing it
Not only the first one that's missing.
This also allows us to simplify things.
https://github.com/rubygems/rubygems/commit/69718a9509
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/c7e3c092e1
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|