| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3864
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3659
|
|
In an executable script, the shebang line should be the first line (the
file needs to start with the bytes 0x23 0x21). Putting a comment above
it will break the script.
(Regression test included per @deivid-rodriguez)
https://github.com/rubygems/rubygems/commit/962e669feb
Notes:
Merged: https://github.com/ruby/ruby/pull/3599
|
|
As splitting by NUL means to allow the file names to contain
newlines, path names should match at beginning-of-string instead
of beginning-of-line.
https://github.com/rubygems/rubygems/commit/8a81183236
Notes:
Merged: https://github.com/ruby/ruby/pull/3599
|
|
The Gemfile wasn't properly put in the last commit.
As a result, Layout/EmptyLines inspected an offense
in the Gemfile.
This also fixes the spec w.r.t change in the task
default.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/d1418fddd3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
If the blank lines aren't used, then rubocop tries to
sort them in alphabetical order within their section.
Thus, adding lines so rubocop considers them as
different sections and doesn't try to sort them.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/cf44b18f0f
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
In case of multiple Rake tasks, the default tasks would
look something like this:
`task default: [:spec, :rubocop]`
Instead, they should use %i and look something like this:
`task default: %i[spec rubocop]`
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/487ecd59ce
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With #3731 and #3740 merged, this covers up the
remaining part of the issues.
This was discovered when one tries to create a gem
with a different framework.
Could be reproduced with:
`bundle gem foo --ext --test=test-unit`
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/51b6457150
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Right now, we're not specifying the version constraints
on RuboCop that is shipped when a new gem is created.
This can break specs which runs rubocop on a new
skeleton gem as the newer versions of RuboCop are
released.
This commit ensures that the specs don't break by
constraining the RuboCop version.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/0b47243edd
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.
And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` to 120, which
is the current standard. Without this, rubocop
will throw the line length offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/46d0a800a2
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Previously, we were using the old syntax like:
`task :default => :spec`, but now this commit
uses the new Ruby 1.9 hash syntax.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/b41d0fdb56
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
since without that, evaluating the gemspec from
outside `File.expand_path( __dir__)` won't work.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9e5e52a1d9
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
These offenses appear when you create a gem with
`bundle gem foo` and run `rubocop` over it.
Initially, there were around 45 offenses detected,
but with #3731 and this, the number of offenses
have been reduced to 2.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/fe9dcaa1b4
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Currently, there is no `.rubocop.yml` shipped by default.
So when a user runs `rubocop` after creating a new gem via
`bundle gem foo`, it throws a bunch of offenses.
With the default `.rubocop.yml` present, the number of those
offenses significantly reduce by 25.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Because they don't play nice with ruby-core's gitignore and cause issues
with ruby-core integration.
Also, because it's consistent with other templates such as `gitignore.tt`.
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
* https://github.com/ruby/setup-ruby is now the more recommended action
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
* Next version of Bundler will auto choose jobs by default
* --retry 3 is already default
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/rubygems/rubygems/commit/851f8afad1
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/80260b3496e357bf96ffe6f381e29bf25b6749cb
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3132
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3086
|
|
https://github.com/bundler/bundler/commit/a86b49f1b9
|
|
https://github.com/bundler/bundler/commit/a94f74682e
|
|
And use single quotes consistenly.
https://github.com/bundler/bundler/commit/8b9fbbb2df
|
|
In these versions, the `approximate_recommendation` method doesn't
include the prerelease logic.
https://github.com/bundler/bundler/commit/caf13e9e4f
|
|
https://github.com/bundler/bundler/commit/9ddeeb1fe1
|
|
https://github.com/bundler/bundler/commit/72194d1aac
|
|
https://github.com/bundler/bundler/commit/50ccdb32c2
|
|
https://github.com/bundler/bundler/commit/1d017c3f36
|
|
https://github.com/bundler/bundler/commit/7ca4d4e83c
|
|
https://github.com/bundler/bundler/commit/f8584fb864
|
|
https://github.com/bundler/bundler/commit/02177d0e10
|
|
https://github.com/bundler/bundler/commit/f47421f92d
|