summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-07* 2020-02-07 [ci skip]git
2020-02-07Removed useless empty linesNobuyoshi Nakada
2020-02-07Stop auto runnerNobuyoshi Nakada
Auto runner should not run in forked processes in separated tests.
2020-02-07No crafted backtrace for SystemExitNobuyoshi Nakada
As SystemExit is ignored, it is just useless.
2020-02-06Revert "[rubygems/rubygems] Fix require issue with file extension priority"Hiroshi SHIBATA
This reverts commit d767da428c28b7b9fec56b383bb32f6f76c6ad26. It fails with spec/ruby/core/kernel/require_spec.rb:5
2020-02-06Revert to remove the query command of rubygems.Hiroshi SHIBATA
The original commit was https://github.com/rubygems/rubygems/pull/3119
2020-02-06[rubygems/rubygems] Fix require issue with file extension priorityDavid Rodríguez
If `require "a"` is run when two folders have been specified in the -I option including a "a.rb" file and a "a.so" file respectively, the ruby spec says that the ".rb" file should always be preferred. However, the logic we added in https://github.com/rubygems/rubygems/commit/6b81076d9 to make the -I option always beat default gems does not respect this spec, creating a difference from the original ruby-core's require. [the ruby spec says]: https://github.com/ruby/spec/blob/d80a6e2b221d4f17a8cadcac75ef950c59cba901/core/kernel/shared/require.rb#L234-L246 https://github.com/rubygems/rubygems/commit/b3944384f4
2020-02-06[rubygems/rubygems] Make non "test_" method privateDavid Rodríguez
https://github.com/rubygems/rubygems/commit/912d141a35
2020-02-06[rubygems/rubygems] Allow releasing with a rubygems pre versionDavid Rodríguez
This condition is too restrictive in my opinion. If a user has a pre version of rubygems installed, she should be fully responsible for it, and we shouldn't restrict any functionality. Also, why is a new prerelease disallowed but an old prelease allowed, or why is 2.0.0.rc2 explictly whitelisted? I believe this kind of exceptions are one more reason to actually permit this. https://github.com/rubygems/rubygems/commit/7f77a77620
2020-02-06Fix readline-ext syncaycabta
2020-02-06Fixed the output from separated test in parallel testNobuyoshi Nakada
Redirect the output of separated child process to `MiniTest::Unit.output`.
2020-02-06Add separated assertion countNobuyoshi Nakada
2020-02-06[ruby/spec] Don't care about return valuesNobuyoshi Nakada
RDoc says nothing about them. Added an example that ConditionVariable#wait can be woken up by ConditionVariable#signal, instead.
2020-02-06[ruby/spec] Just test that sleep completesNobuyoshi Nakada
2020-02-06[ruby/spec] Check by Thread#stop?Nobuyoshi Nakada
Check if threads are stopped by Thread#stop? instead of the status name.
2020-02-06rb_vm_t::postponed_job_index shall be rb_atomic_t卜部昌平
Pointer to this field is passed to ATOMIC_CAS. We have to use rb_atomic_t for that purpose. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06function pointers are not void*卜部昌平
The same as 8427fca49bd85205f5a8766292dd893f003c0e48. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06this ternary operator is an undefined behaviour卜部昌平
Let me quote ISO/IEC 9899:2018 section 6.5.15: > Constraints > > The first operand shall have scalar type. > One of the following shall hold for the second and third operands: > — both operands have arithmetic type; > — both operands have the same structure or union type; > — both operands have void type; (snip) Here, `*option` is a const struct rb_compile_option_struct. OTOH `COMPILE_OPTION_DEFAULT` is a struct rb_compile_option_struct, without const. These two are _not_ the "same structure or union type". Hence the expression renders undefined behaviour. COMPILE_OPTION_DEFAULT is not a const because `RubyVM::InstructionSequence.compile_option=` touches its internals on-the-fly. There is no way to meet the constraints quoted above. Using ternary operator here was a mistake at the first place. Let's just replace it with a normal `if` statement. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06fine-grained #ifdef guard for Sparc systems卜部昌平
There are cases when sizeof(int) == sizeof(long) == sizeof(size_t). On such cases however int and long are incompatible types in theory. We should not assume typedef long size_t, because on Solaris size_t is actually a typedef of int. This reduces compiler warnings on such situations. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06do not assume GCC for __builtin_setjmp卜部昌平
Namely recent Sun C compiler has this function, and is not a GCC. Meanwhile the code without RUBY_JMP_BUF assumes GCC. We have to define the macro when we detect __builtin_setjmp for non-GCC compilers. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06add predefined macros for Doxygen卜部昌平
Predefined macros are practices not very well recommended, but can be better than having no documents at all. Without those predefined macros, Doxygen confused for instace PUREFUNC(int foo()) to be a declaration of PUREFUNC, not foo. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06emacs mode addition卜部昌平
Now that we have C++ header files, why not let their indents follow our way. Notes: Merged: https://github.com/ruby/ruby/pull/2885
2020-02-06* 2020-02-06 [ci skip]git
2020-02-06Increase the frozen_strings table initial sizeJean Boussier
It was set to 1000 in a4a2b9be7a55bb61d17cf9673ed0d2a93bb52d31. However on ruby-2.7.0p0, there are much more than 1k frozen string right after boot: ``` $ ruby -robjspace -e 'p ObjectSpace.each_object(String).select { |s| s.frozen? && ObjectSpace.dump(s).include?(%{"fstring":true})}.uniq.count' 5948 ``` Notes: Merged: https://github.com/ruby/ruby/pull/2841
2020-02-05* 2020-02-05 [ci skip]git
2020-02-05Fixed the output from separated test in parallel testNobuyoshi Nakada
To output to the STDOUT of the parent process according to the parallel test protocol, should send to the `MiniTest::Unit.output` instead of each own STDOUT.
2020-02-05Fixed FD leaksNobuyoshi Nakada
2020-02-05Get rid of nested string interpolations to be editor-friendlyNobuyoshi Nakada
2020-02-04just use STDOUTNARUSE, Yui
2020-02-04Add call-seq to Pathname#open from File.openKazuhiro NISHIYAMA
before: ``` open(p1 = v1, p2 = v2, p3 = v3) ```
2020-02-04On Windows it cannot receive fd except 0..2NARUSE, Yui
2020-02-04assert_separately uses their own pipe instead of stdoutNARUSE, Yui
2020-02-04Add the loaded feature after no exception raisedNobuyoshi Nakada
Retrying after rescued `require` should try to load the same library again. [Bug #16607] Notes: Merged: https://github.com/ruby/ruby/pull/2879
2020-02-04Do not warn CR inside string literalNobuyoshi Nakada
2020-02-04Fix inaccuracy in encoding testsLars Kanis
These tests assume Encoding.find('locale') == Encoding.find('external') and fail if they are distinct.
2020-02-04Fix linkage of popen_deadlock testMikhail Novosyolov
DEBUG: BUILDSTDERR: /usr/bin/ld: infinite_loop_dlsym.o: in function `native_loop_dlsym': DEBUG: BUILDSTDERR: /builddir/build/BUILD/ruby-2.7.0/ext/-test-/popen_deadlock/infinite_loop_dlsym.c:16: undefined reference to `dlsym' DEBUG: BUILDSTDERR: collect2: error: ld returned 1 exit status Ruby was built with LibreSSL. Notes: Merged: https://github.com/ruby/ruby/pull/2862
2020-02-03Fix description of Encoding.default_(in|ex)ternalLars Kanis
Data written to files is not transcoded per default, but only when default_internal is set. The default for default_internal is nil and doesn't depend on the source file encoding. Notes: Merged: https://github.com/ruby/ruby/pull/2878
2020-02-04* 2020-02-04 [ci skip]git
2020-02-03Fix SimpleDelegator respond_to? regressionJean Boussier
In 2.6, SimpleDelegator would always use the target `respond_to?` In 2.7.0 it doesn't if the target does not inherit from Object. This breaks compatibility for delegated objects that inherit from BasicObject and redefine `respond_to?`. Notes: Merged: https://github.com/ruby/ruby/pull/2875
2020-02-03Check type of empty keyword [Bug #16603]Seiei Miyagi
Co-authored-by: Yusuke Endoh <mame@ruby-lang.org> Notes: Merged: https://github.com/ruby/ruby/pull/2874
2020-02-03support MJIT with debug option.Koichi Sasada
VM_CHECK_MODE > 0 with optflags=-O0 can not run JIT tests because of link problems. This patch fix them.
2020-02-03Parenthesized macro argumentsNobuyoshi Nakada
2020-02-03Make `rb_scan_args_kw` inline tooNobuyoshi Nakada
2020-02-03Moved runtime assignemntsNobuyoshi Nakada
Separate assignemnts of dynamically given runtime values in `rb_scan_args_assign` from parsing statically given format in `rb_scan_args_parse`.
2020-02-03test/rubygems/test_gem_remote_fetcher.rb: Remove a duplicated testYusuke Endoh
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu1604/ruby-master/log/20200203T003005Z.log.html.gz ``` /home/hsbt/chkbuild/tmp/build/20200203T003005Z/ruby/test/rubygems/test_gem_remote_fetcher.rb:485: warning: method redefined; discarding old test_fetch_path_socket_error /home/hsbt/chkbuild/tmp/build/20200203T003005Z/ruby/test/rubygems/test_gem_remote_fetcher.rb:167: warning: previous definition of test_fetch_path_socket_error was here ```
2020-02-03* 2020-02-03 [ci skip]git
2020-02-03`struct rb_scan_args_t::vargs` is never usedNobuyoshi Nakada
2020-02-02Removed no longer used variable `last_hash`Nobuyoshi Nakada
1. By substituting `n_var` with its initializer, `0 < n_var` is equivalent to `argc > argi + n_trail`. 2. As `argi` is non-negative, so `argi + n_trail >= n_trail`, and the above expression is equivalent to `argc > n_trail`. 3. Therefore, `f_last` is always false, and `last_hash` is no longer used. Notes: Merged: https://github.com/ruby/ruby/pull/2873 Merged-By: nobu <nobu@ruby-lang.org>
2020-02-02* 2020-02-02 [ci skip]git
2020-02-02[ruby/reline] Bypass cursor down when a char is rendered at eol on Windowsaycabta
A newline is automatically inserted if a character is rendered at eol on Windows command prompt. https://github.com/ruby/reline/commit/4bfea07e4a