summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-08[rubygems/rubygems] Extract an `install_file_list` helperDavid Rodríguez
https://github.com/rubygems/rubygems/commit/5106ea4582 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Move helper to private sectionDavid Rodríguez
https://github.com/rubygems/rubygems/commit/fb824b7a81 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Refactor dummy file creationDavid Rodríguez
https://github.com/rubygems/rubygems/commit/665099fe53 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix super weird code styleDavid Rodríguez
https://github.com/rubygems/rubygems/commit/f1a5815896 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Follow the pattern of other test files for foo.pemDavid Rodríguez
https://github.com/rubygems/rubygems/commit/a43cffddad Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Move helper methods to private section of the test fileDavid Rodríguez
https://github.com/rubygems/rubygems/commit/b85db66e2d Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Rename method to clarifyDavid Rodríguez
https://github.com/rubygems/rubygems/commit/6dc76146ad Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Install existing gems as regular gemsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/a0880d78a8 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove misleading commentsDavid Rodríguez
`site_dir`, or `vendor_dir`, is the location where the default version of bundler & rubygems gets installed. These folders are placed directly in the LOAD_PATH, so they cannot hold any nested gem directory structure. So a single copy of either rubygems or bundler can be placed in these folders. What the tests are actually testing is the TODO comment that I'm removing: that installing the default copy of bundler doesn't affect any already installed copies of bundler as regular gems. https://github.com/rubygems/rubygems/commit/7ca8831d72 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unnecessary lineDavid Rodríguez
https://github.com/rubygems/rubygems/commit/1d0981809a Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Prefer `tr` to `gsub` when replacing path separatorsDavid Rodríguez
This is not detected by the `Performance/StringReplacement` cop, I guess because of using constants. But still seems like a good change. Co-authored-by: MSP-Greg <MSP-Greg@users.noreply.github.com> https://github.com/rubygems/rubygems/commit/f862103133 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Shortcuit method earlierDavid Rodríguez
If the class variable is set, we can skip the whole thing from the beginning. Co-authored-by: MSP-Greg <MSP-Greg@users.noreply.github.com> https://github.com/rubygems/rubygems/commit/83abf3a3d4 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Condense some artificially broken linesDavid Rodríguez
Co-authored-by: MSP-Greg <MSP-Greg@users.noreply.github.com> https://github.com/rubygems/rubygems/commit/5f390478c7 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Extract `gem_make_out` contents to a variableDavid Rodríguez
Co-authored-by: MSP-Greg <MSP-Greg@users.noreply.github.com> https://github.com/rubygems/rubygems/commit/5f2b7474eb Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix incorrect `gem uninstall --all` messageDavid Rodríguez
Currently `gem uninstall --all` shows the following incorrect message after completion: ``` INFO: Uninstalled all gems in ``` Now it shows something that actually makes sense like: ``` INFO: Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome ``` https://github.com/rubygems/rubygems/commit/8fa05e8f8c Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Refactor duplicate metadata logicThomas McDonald
https://github.com/rubygems/rubygems/commit/1e5ef177ac Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unnecessary codeThomas McDonald
`@host` _could_ be `nil` at this point, but only if all the conditions above for setting `@host` were `nil`. In that case, it is guaranteed to `default_gem_server` metadata is `nil` since it's one of the branches in that condition. So this code would just be setting an already `nil` variable to `nil`. Hence, not needed. https://github.com/rubygems/rubygems/commit/e3ccff3c5c Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Simplify host switching logicThomas McDonald
This block was a branch and variable heavy way of saying use the user-provided host if available, or fall-back to the default host if none of the other options match. IMO the resultant single-if condition is clearer in intentions https://github.com/rubygems/rubygems/commit/42dbb71cfa Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Make cmake tests less verbose on jrubyDavid Rodríguez
These tests work on jruby, but the flags to the system command used to detect whether `cmake` is present seem to be ignored on jruby and the output is printed to screen instead of being sent to /dev/null. This results in very verbose tests, like this: ``` $ rake TESTOPTS=--name=TestGemExtCmakeBuilder#test_self_build (... warnings skipped ...) Skipping `gem cert` tests on jruby. Skipping Gem::Security tests on jruby. Run options: --name=TestGemExtCmakeBuilder#test_self_build --seed 16839 # Running: /home/deivid/Code/rubygems/test/rubygems/test_gem_ext_cmake_builder.rb:13: warning: system does not support options in JRuby yet: {:out=>"/dev/null", :err=>[:child, :out]} Usage cmake [options] <path-to-source> cmake [options] <path-to-existing-build> Specify a source directory to (re-)generate a build system for it in the current working directory. Specify an existing build directory to re-generate its build system. Run 'cmake --help' for more information. . Finished in 0.387301s, 2.5820 runs/s, 20.6558 assertions/s. 1 runs, 8 assertions, 0 failures, 0 errors, 0 skips Coverage report generated for Unit Tests to /home/deivid/Code/rubygems/coverage. 2258 / 8832 LOC (25.57%) covered. ``` By using `Open3`, we get the test output clean: ``` $ rake TESTOPTS=--name=TestGemExtCmakeBuilder#test_self_build (... warnings skipped ...) Skipping `gem cert` tests on jruby. Skipping Gem::Security tests on jruby. Run options: --name=TestGemExtCmakeBuilder#test_self_build --seed 22605 # Running: . Finished in 0.381959s, 2.6181 runs/s, 20.9446 assertions/s. 1 runs, 8 assertions, 0 failures, 0 errors, 0 skips Coverage report generated for Unit Tests to /home/deivid/Code/rubygems/coverage. 2258 / 8832 LOC (25.57%) covered. ``` https://github.com/rubygems/rubygems/commit/531ce37ea3 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Refactor ruby command line building for testsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/43819b6973 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Update test_realworld_default_gem to use rubygems ↵Brandon Fish
project sources https://github.com/rubygems/rubygems/commit/7506f7eb07 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unnecessary `@@ruby` variableDavid Rodríguez
https://github.com/rubygems/rubygems/commit/5f20647ec1 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unneeded explicit requiresDavid Rodríguez
https://github.com/rubygems/rubygems/commit/583316bf49 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unneeded dupsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/2f072e3dc7 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Remove unneeded untaintingDavid Rodríguez
https://github.com/rubygems/rubygems/commit/ff223d8489 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Simplify nested require exceptionsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/7fbef2f0e3 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix ruby warning about unused local variablesDavid Rodríguez
https://github.com/rubygems/rubygems/commit/cca2fccd95 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix ruby warnings about a shadowed variableDavid Rodríguez
https://github.com/rubygems/rubygems/commit/5cfb3252d9 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix symlink RubyGems test problems for non-admin user.Josef Šimánek
https://github.com/rubygems/rubygems/commit/75f672ff0e Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Fix race condition on bundler's parallel installerDavid Rodríguez
When installing in parallel, bundler creates several `Gem::Installer` instances that run in parallel. These installers access the `@@all` class variable of `Gem::Specification` concurrently. If a concurrent thread calls `Gem::Specification.reset` (resetting `@all` to `nil`) while another thread is running `Gem::Specification._all` or another method that expects `@@all` to be loaded and not `nil`, that can result in `Enumerable` methods being called on `nil`, resulting in crashes. I fix it by protecting the other concurrent access to the `@all` variable. https://github.com/rubygems/rubygems/commit/58b343c530 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-08[rubygems/rubygems] Allow spaces in file headers during octal checkDmytro Shyrshov
https://github.com/rubygems/rubygems/commit/e9e25731d8 Notes: Merged: https://github.com/ruby/ruby/pull/3092
2020-05-07Add T_IMEMO support to lldbAaron Patterson
I'm trying to find why a reference to an IMEMO object isn't being updated
2020-05-08Fix typo in test namePeter Zhu
Notes: Merged: https://github.com/ruby/ruby/pull/3091
2020-05-08[rubygems/rubygems] Remove unnecessary DIR constantDavid Rodríguez
We have `__dir__` which is the same thing. https://github.com/rubygems/rubygems/commit/f89776427f Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Move stuff to the instance levelDavid Rodríguez
I don't know why it was living at the class level. At first I thought it would be to reuse some server instances between tests, but they seem to be cleaned up after every test anyways, so I don't think any of it is needed. https://github.com/rubygems/rubygems/commit/04bee71216 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08Normalize heredoc case in rubygems code baseDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08Normalize heredoc delimitersDavid Rodríguez
Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] These specs seem to work just fine on jrubyBenoit Daloze
https://github.com/rubygems/rubygems/commit/a0219b9f27 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Fix platform comparison bug in #contains_requirable_file?Benoit Daloze
* One should not compare RUBY_ENGINE and Gem::Platform. * Introduced in https://github.com/rubygems/rubygems/pull/2672 https://github.com/rubygems/rubygems/commit/0e62c3be91 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Only run the $SAFE test on MRI < 2.7Benoit Daloze
* Other Ruby implementations don't support $SAFE. https://github.com/rubygems/rubygems/commit/9a4ba16efa Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Autoload name_tuple.rb before useOlle Jonsson
- Resolver asked Molinillo to resolve-then-activate, which led to using Gem::NameTuple before any require had been passed Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/rubygems/rubygems/commit/e11782b0c8 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Do not use set.Josef Šimánek
https://github.com/rubygems/rubygems/commit/1a72c8796f Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Add gem build test to check for removed methods.Josef Šimánek
https://github.com/rubygems/rubygems/commit/c07b9cf4f1 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Track removed methods calls and warn during build time.Josef Šimánek
move rubyforge_project= to removed methods https://github.com/rubygems/rubygems/commit/223f7fd470 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Deprecate rubyforge_project attribute only during build ↵Josef Šimánek
time. https://github.com/rubygems/rubygems/commit/c44eb21648 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Revert deprecation of deprecate method for now.Josef Šimánek
https://github.com/rubygems/rubygems/commit/965eee1741 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Restore and deprecate old deprecate methodbronzdoc
https://github.com/rubygems/rubygems/commit/024267fa60 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Rename version horizon deprecation methodsbronzdoc
https://github.com/rubygems/rubygems/commit/6afd914fda Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Avoid "ambiguous first argument" warningbronzdoc
https://github.com/rubygems/rubygems/commit/984bb9b815 Notes: Merged: https://github.com/ruby/ruby/pull/3087
2020-05-08[rubygems/rubygems] Add next_rubygems_major_version methodbronzdoc
https://github.com/rubygems/rubygems/commit/db5bb65baf Notes: Merged: https://github.com/ruby/ruby/pull/3087
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-17 15:34:05 +0000