Age | Commit message (Collapse) | Author |
|
Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Right now, we're not specifying the version constraints
on RuboCop that is shipped when a new gem is created.
This can break specs which runs rubocop on a new
skeleton gem as the newer versions of RuboCop are
released.
This commit ensures that the specs don't break by
constraining the RuboCop version.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/0b47243edd
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Everything is already fetched locally.
https://github.com/rubygems/rubygems/commit/9c304639b1
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/6e0c28d3ab
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
It simplifies things and should avoid issues like the one we had where
the master branch had a bad `.gitattributes` file and changing it on a
PR would be disregarded.
In order for this to work, we need to make sure to fetch all tags from
the repository, so that they can properly be checked out later. This
does not apply to the case of testing against `RGV=..`, since no extra
cloning is needed there.
https://github.com/rubygems/rubygems/commit/d088d936b8
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
ruby_core has an 'ast.rb' file that gets in the
middle and breaks this spec, so it's better we skip
this test on this workflow for now.
Also, slightly change the spec name from "run" to
"runs" and change the last assertion, it's cleaner
to check empty error.
Thanks to David Rodríguez for this!
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/ba8eaa70c3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With older versions of rubocop, the dependency on
`jaro_winkler` seems to be a pain.
However, in the later versions of rubocop, this
dependency was dropped. So we only need to use
the older version for ruby2.3.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9cd87eaee3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
because rubocop configuration inheritance is
messed up and when using `--ignore-parent-exclusion`,
even though the exit status is 0, the example
still fails because of the configuration issue.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/3e20b2738c
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.
And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` to 120, which
is the current standard. Without this, rubocop
will throw the line length offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/46d0a800a2
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/83e330fa87
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With this, it will be ensured that the generated
(skeleton) gem will have no offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/47411262e0
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Previously, we were using the old syntax like:
`task :default => :spec`, but now this commit
uses the new Ruby 1.9 hash syntax.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/b41d0fdb56
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/730b770f8a
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
since without that, evaluating the gemspec from
outside `File.expand_path( __dir__)` won't work.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9e5e52a1d9
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/e2ee0b7de3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
These offenses appear when you create a gem with
`bundle gem foo` and run `rubocop` over it.
Initially, there were around 45 offenses detected,
but with #3731 and this, the number of offenses
have been reduced to 2.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/fe9dcaa1b4
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
errors
https://github.com/rubygems/rubygems/commit/1fe24e471d
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Since we don't show this output by default, it's better to be verbose
in case we happen to need more info.
https://github.com/rubygems/rubygems/commit/baa4ccf5a6
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
File.readlines
Using File.open without a block leaves a file reference that causes issues with file operations
commands/binstubs_spec.rb
install/gems/compact_index_spec.rb
install/gems/dependency_api_spec.rb
install/gems/standalone_spec.rb
runtime/executable_spec.rb
https://github.com/rubygems/rubygems/commit/4b9a6ca156
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Windows skip
Added one skip for:
bundle binstubs <gem>
when the gem exists in the lockfile
when generating bundle binstub outside bundler
should abort
https://github.com/rubygems/rubygems/commit/b77b484889
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
'executable_stubs'
Windows normal shell requires binstubs with *.cmd extensions
https://github.com/rubygems/rubygems/commit/b46326eb1f
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Notes:
Merged: https://github.com/ruby/ruby/pull/3319
|
|
The type of RBasic::flags is VALUE, and INT2FIX(flags) does not
make sense. Use correct type to represent.
|
|
|
|
|
|
|
|
This is no longer used.
|
|
Was my bad to assume sp_inc was positive. Real criteria is the
calculated sp is non-negative. We have to assert that.
|
|
Previously, for inclusive ranges, the max would show up as the
end of the range, even though the end was not an integer and would
not be the maximum value. For exclusive ranges, max/minmax would
previously raise a TypeError, even though it is possible to get the
correct maximum.
This change to max/minmax also uncovered a similar error in cover?,
which calls max in certain cases, so adjust the code there so that
cover? still works as expected.
Fixes [Bug #17017]
Notes:
Merged: https://github.com/ruby/ruby/pull/3306
Merged-By: jeremyevans <code@jeremyevans.net>
|
|
|
|
--jit-min-calls=5 is too unstable
|
|
|
|
* RUN_OPTS needs to be specified for overriding it
* Add --jit-min-calls=5
Notes:
Merged-By: k0kubun <takashikkbn@gmail.com>
|
|
|
|
Stacks are emulated in MJIT, must not touch the original VM stack.
See also http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3061353
|
|
|
|
Instead of doubling the invokebuiltin logic here and there, use the same
insns.def definition for both MJIT/non-JIT situations.
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
This commit fixes compiler error on MSVC. %p on that platform is not
suitable to represent a compile-time constant.
https://ci.appveyor.com/project/ruby/ruby/builds/34017163/job/vj2a8uk3gwv9yxak#L24381
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
We can obtain the verbatim source code of Primitive.cexpr!. Why not
paste that content into the JITed program.
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
Noticed that struct rb_builtin_function is a purely compile-time
constant. MJIT can eliminate some runtime calculations by statically
generate dedicated C code generator for each builtin functions.
Notes:
Merged: https://github.com/ruby/ruby/pull/3305
|
|
|
|
* removed out-of-date and duplicate list
* stated that everything synced from github
|
|
|
|
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3312
|
|
|