summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-16skip inlining cexpr! that are not attr! inline卜部昌平
Requested by ko1. Notes: Merged: https://github.com/ruby/ruby/pull/3314
2020-07-16* 2020-07-16 [ci skip]git
2020-07-16Remove fiber HTTP test.Samuel Williams
The HTTP test hits a remote website which isn't always available and is not self-contained. Ideally we will rewrite this test with an internal web server. Notes: Merged: https://github.com/ruby/ruby/pull/3321
2020-07-15Check warning flags only if available to run with old versionsNobuyoshi Nakada
2020-07-15Fixed infinite loop at error in printing cause [Bug #17033]Nobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/3320
2020-07-15Close sockets if blocking to fix leaked fdsNobuyoshi Nakada
2020-07-15Import remaining changesDavid Rodríguez
The "sync with commits" scripts failed to properly import these for some reason. Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Unswallow `Gem::Package::FormatError`David Rodríguez
This error happen in a CI run, and as it is currently, it doesn't give any useful information about the underlying cause. Let's not swallow the original error. https://github.com/rubygems/rubygems/commit/8c17ba2f45 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] July man pagesDavid Rodríguez
https://github.com/rubygems/rubygems/commit/58d9a3de5b Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Tag the specs with :readlineUtkarsh Gupta
The newly added specs needs to be tagged as :readline, otherwise they fail on Windows with the backtrace: `ZeroDivisionError: divided by 0`. Such issues are already being skipped on Windows. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/391f860af4 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Add tests with different flag combinationsUtkarsh Gupta
Since this PR was made because we missed checking RuboCop offenses with different flags, therefore adding tests so that all flag combinations are tested. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d08250efc2 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Allow setting a tag prefix to be used by gem release tasksDavid Rodríguez
https://github.com/rubygems/rubygems/commit/679008f23a Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix line spacing to make Layout/EmptyLines happyUtkarsh Gupta
The Gemfile wasn't properly put in the last commit. As a result, Layout/EmptyLines inspected an offense in the Gemfile. This also fixes the spec w.r.t change in the task default. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d1418fddd3 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Add blank lines to make Bundler/OrderedGems happyUtkarsh Gupta
If the blank lines aren't used, then rubocop tries to sort them in alphabetical order within their section. Thus, adding lines so rubocop considers them as different sections and doesn't try to sort them. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/cf44b18f0f Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix Rakefile to make Style/SymbolArray happyUtkarsh Gupta
In case of multiple Rake tasks, the default tasks would look something like this: `task default: [:spec, :rubocop]` Instead, they should use %i and look something like this: `task default: %i[spec rubocop]` Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/487ecd59ce Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix remaining RuboCop issuesUtkarsh Gupta
With #3731 and #3740 merged, this covers up the remaining part of the issues. This was discovered when one tries to create a gem with a different framework. Could be reproduced with: `bundle gem foo --ext --test=test-unit` Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/51b6457150 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Avoid calling LoadError#message because of its slownessJean Boussier
Instead we can rely on `LoadError#path` https://github.com/rubygems/rubygems/commit/16d5c3b43c Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Remove unneeded trailing conditions on exitstatusDavid Rodríguez
https://github.com/rubygems/rubygems/commit/27e0e4ecb6 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Easier way to find path to ruby binaryDavid Rodríguez
https://github.com/rubygems/rubygems/commit/cdc201f5c4 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Remove unnecessary assertions on exitstatusDavid Rodríguez
Since our helpers now raise by default if the subcommand fails, these will never actually fail and are not necessary. https://github.com/rubygems/rubygems/commit/6153b9321e Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Constrain (shipped) RuboCop's versionUtkarsh Gupta
Right now, we're not specifying the version constraints on RuboCop that is shipped when a new gem is created. This can break specs which runs rubocop on a new skeleton gem as the newer versions of RuboCop are released. This commit ensures that the specs don't break by constraining the RuboCop version. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/0b47243edd Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] No need to update remotesDavid Rodríguez
Everything is already fetched locally. https://github.com/rubygems/rubygems/commit/9c304639b1 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Git clone already takes care of thisDavid Rodríguez
https://github.com/rubygems/rubygems/commit/6e0c28d3ab Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Clone rubygems from the local repoDavid Rodríguez
It simplifies things and should avoid issues like the one we had where the master branch had a bad `.gitattributes` file and changing it on a PR would be disregarded. In order for this to work, we need to make sure to fetch all tags from the repository, so that they can properly be checked out later. This does not apply to the case of testing against `RGV=..`, since no extra cloning is needed there. https://github.com/rubygems/rubygems/commit/d088d936b8 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Skip this spec on ruby_core workflowUtkarsh Gupta
ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec, so it's better we skip this test on this workflow for now. Also, slightly change the spec name from "run" to "runs" and change the last assertion, it's cleaner to check empty error. Thanks to David Rodríguez for this! Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ba8eaa70c3 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Use latest version of rubocop for RUBY_VERSION > 2.4Utkarsh Gupta
With older versions of rubocop, the dependency on `jaro_winkler` seems to be a pain. However, in the later versions of rubocop, this dependency was dropped. So we only need to use the older version for ruby2.3. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/9cd87eaee3 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Use `--config .rubocop.yml` insteadUtkarsh Gupta
because rubocop configuration inheritance is messed up and when using `--ignore-parent-exclusion`, even though the exit status is 0, the example still fails because of the configuration issue. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/3e20b2738c Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Lock rubocop version to 0.80.1Utkarsh Gupta
The later RuboCop versions don't work with ruby2.3 so we should lock the version to what works with ruby2.3 as we haven't dropped the support yet. And since we're using the older version of rubocop, also fix `Max` value of `LineLength` to 120, which is the current standard. Without this, rubocop will throw the line length offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/46d0a800a2 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix linting and make Style/RedundantInterpolation happyUtkarsh Gupta
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/83e330fa87 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix test to run rubocop on the generated gemUtkarsh Gupta
With this, it will be ensured that the generated (skeleton) gem will have no offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/47411262e0 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Make Style/HashSyntax cop happyUtkarsh Gupta
Previously, we were using the old syntax like: `task :default => :spec`, but now this commit uses the new Ruby 1.9 hash syntax. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/b41d0fdb56 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] WIP: add test to run rubocop on the generated gemUtkarsh Gupta
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/730b770f8a Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Roll back to Dir.chdir blockUtkarsh Gupta
since without that, evaluating the gemspec from outside `File.expand_path( __dir__)` won't work. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/9e5e52a1d9 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix tests pertaining to newgemUtkarsh Gupta
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/e2ee0b7de3 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Fix RuboCop offensesUtkarsh Gupta
These offenses appear when you create a gem with `bundle gem foo` and run `rubocop` over it. Initially, there were around 45 offenses detected, but with #3731 and this, the number of offenses have been reduced to 2. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/fe9dcaa1b4 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Show also output from all commands on rubygems checkout ↵David Rodríguez
errors https://github.com/rubygems/rubygems/commit/1fe24e471d Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Remove `--quiet` flag to `git checkout`David Rodríguez
Since we don't show this output by default, it's better to be verbose in case we happen to need more info. https://github.com/rubygems/rubygems/commit/baa4ccf5a6 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] Bundler specs - Windows - remove skips, File.open => ↵MSP-Greg
File.readlines Using File.open without a block leaves a file reference that causes issues with file operations commands/binstubs_spec.rb install/gems/compact_index_spec.rb install/gems/dependency_api_spec.rb install/gems/standalone_spec.rb runtime/executable_spec.rb https://github.com/rubygems/rubygems/commit/4b9a6ca156 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] bundler/spec/commands/binstubs_spec.rb - remove global ↵MSP-Greg
Windows skip Added one skip for: bundle binstubs <gem> when the gem exists in the lockfile when generating bundle binstub outside bundler should abort https://github.com/rubygems/rubygems/commit/b77b484889 Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15[rubygems/rubygems] bundler/lib/bundler/installer.rb - fix Windows ↵MSP-Greg
'executable_stubs' Windows normal shell requires binstubs with *.cmd extensions https://github.com/rubygems/rubygems/commit/b46326eb1f Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-07-15Update actions/cache from v1 to v2Sora Morimoto
Signed-off-by: Sora Morimoto <sora@morimoto.io> Notes: Merged: https://github.com/ruby/ruby/pull/3319
2020-07-15RBasci::flags (VALUE) doesn't match int.Koichi Sasada
The type of RBasic::flags is VALUE, and INT2FIX(flags) does not make sense. Use correct type to represent.
2020-07-15* 2020-07-15 [ci skip]git
2020-07-15rubygems is needed to run solo-file testKoichi Sasada
2020-07-15rubygems is needed to run solo-file testKoichi Sasada
2020-07-14ON_DEBUG: delete unused macro卜部昌平
This is no longer used.
2020-07-14_mjit_compile_invokebuiltin: sp_inc can be negative卜部昌平
Was my bad to assume sp_inc was positive. Real criteria is the calculated sp is non-negative. We have to assert that.
2020-07-13Fix Range#{max,minmax} for range with integer beginning and non-integer endJeremy Evans
Previously, for inclusive ranges, the max would show up as the end of the range, even though the end was not an integer and would not be the maximum value. For exclusive ranges, max/minmax would previously raise a TypeError, even though it is possible to get the correct maximum. This change to max/minmax also uncovered a similar error in cover?, which calls max in certain cases, so adjust the code there so that cover? still works as expected. Fixes [Bug #17017] Notes: Merged: https://github.com/ruby/ruby/pull/3306 Merged-By: jeremyevans <code@jeremyevans.net>
2020-07-14* 2020-07-14 [ci skip]git
2020-07-13Remove --jit-min-calls for nowTakashi Kokubun
--jit-min-calls=5 is too unstable
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-16 17:21:21 +0000