| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
with Travis, rather than AppVeyor.
Formerly it was made similar to AppVeyor to provide some normal set of
CI failure notification. But for some reason people preferred a shorter
variant and introduced a1d606c079f6c3d1779d885e0bf2e3991251609e and
d8d8015b93c6daa8d8433895464db3493a2056e2.
Instead of AppVeyor format, this commit chose Travis-like format to achieve
consistency and to include usual CI-failure information, while keeping
it one-liner for people who prefer short notifications.
Note that this shrinks the 40-char sha to 10-char, using the new feature
of k0kubun/action-slack@v2.0.0:
https://github.com/k0kubun/action-slack/commit/1c88a05dac664cbafa1c99a37f292ed23ac1c289
|
|
Tabs are expanded because previously the file did not have any tab indentation.
Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook.
|
|
|
|
This is implemented to close [Misc #16112] because all other options got
at least one objection, and nobody has objected to this solution.
This code is a little complicated for the purpose, but that's just
because it includes some historical code for auto-style.rb:
https://github.com/ruby/ruby-commit-hook/blob/918a7c31b69ad2f7b125608c1c6a1f4fd01ec15a/bin/auto-style.rb
Please feel free to improve this file as you like.
[Misc #16112]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
sometimes Slack notification footer becomes just " at ".
It seems like `github.event.head_commit` is missing. Let me debug the
context.
|
|
|
|
|
|
|
|
Specify just a string
set @built_at as nil before testing
https://github.com/bundler/bundler/commit/578ec96c9c
|
|
https://github.com/bundler/bundler/commit/a38161c5be
|
|
https://github.com/bundler/bundler/commit/faccc522d1
|
|
https://github.com/bundler/bundler/commit/23007cb107
|
|
https://github.com/bundler/bundler/commit/52b6b94068
|
|
Our current set of specs is the same for all supported rubies, and we
should keep it that way.
https://github.com/bundler/bundler/commit/c9dc0f6f2c
|
|
https://github.com/bundler/bundler/commit/8c7942d2c6
|
|
https://github.com/bundler/bundler/commit/36fb3287f4
|
|
|
|
rp() macro for debug also shows file location and function name
such as:
[OBJ_INFO:rb_call_inits@inits.c:73] 0x000056147741b248 ...
Notes:
Merged-By: ko1
|
|
It seems that we cannot easily apply job-level [ci skip].
Therefore this commit skips only Tests step if it's [ci skip].
|
|
Some CIs report to two channels, and some others report to only one.
This makes it consistent. Only alert channel should be alerted.
|
|
Notes:
Merged-By: amatsuda <ronnie@dio.jp>
|
|
|
|
|
|
It is defined since ruby 1.9.2.
https://github.com/rubygems/rubygems/commit/84981ca908
|
|
|
|
* These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests.
That was a bit confusing.
* Borrow trick from setproctitle specs
* A title that long doesn't get set sometimes
No idea why, but the test doesn't need that the title is that long.
* Fix most gem helper spec ruby-core failures
* Fix the rest of the gem helper failures
* Fix version spec by improving the assertion
* Remove unnecessary `BUNDLE_RUBY` environment var
We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
because bundler considers `BUNDLE_*` variables as settings.
* Rename `BUNDLE_GEM` to `GEM_COMMAND`
This is more descriptive I think, and also friendlier for bundler
because `BUNDLE_` env variables are interpreted by bundler as settings,
and this is not a bundler setting.
This fixes one bundler spec failure in config specs against ruby-core.
* Fix quality spec when run in core
Use the proper path helper.
* Fix dummy lib builder to never load default gems
If a dummy library is named as a default gem, when requiring the library
from its executable, the default gem would be loaded when running from
core, because in core all default gems share path with bundler, and thus
they are always in the $LOAD_PATH. We fix the issue by loading lib
relatively inside dummy lib executables.
* More exact assertions
Sometimes I have the problem that I do some "print debugging" inside
specs, and suddently the spec passes. This happens when the assertion is
too relaxed, and the things I print make it match, specially when they
are simple strings like "1.0" than can be easily be part of gem paths
that I print for debugging.
I fix this by making a more exact assertion.
* Detect the correct shebang when ENV["RUBY"] is set
* Relax assertion
So that the spec passes even if another paths containing "ext" are in
the load path. This works to fix a ruby-core issue, but it's a better
assertion in general. We just want to know that the extension path was
added.
* Use folder structure independent path helper
It should fix this spec for ruby-core.
* Fix the last failing spec on ruby-core
* Skip `bundle open <default_gem>` spec when no default gems
|
|
A "do" what has followed a token what has EXPR_CMDARG is for a block,
and in other cases "do" is for "while", "until" or "for".
|
|
Without doing this, enabling a TracePoint on a method could lead to use
of moved objects. This was found by running
`env RUBY_ISEQ_DUMP_DEBUG=to_binary make test-all`, which sets
orignal_iseq then runs the compaction tests and the tracepoint tests.
Please excuse the lack of tests. I was not able to figure out how to
reliably trigger a move on a specific iseq imemo to make a good
regression test.
To manually confirm the problem and this fix, you can run:
```
env RUBY_ISEQ_DUMP_DEBUG=to_binary make test-all \
TESTOPTS="test/ruby/test_gc_compact.rb \
test/gdbm/test_gdbm.rb \
test/ruby/test_settracefunc.rb"
```
Or the following script:
```ruby
tp = TracePoint.new(:line) {}
1.times do # put it in a block to not keep these objects alive
objects = 10_000.times.map { Object.new }
objects.hash
end
1.times do
# this allocation pattern can realistically happen in an app
# at load time
beek = 10_000.times.map do
eval(<<-RUBY)
def foo
a + b
1.times {
4 + 234234
}
nil + 234
end
RUBY
Object.new
Object.new
end
beek.hash
end
tp.enable(target: self.:foo) { 234 } # allocate original iseq
GC.verify_compaction_references(toward: :empty)
GC.compact
tp.enable(target: self.:foo) { 234234 } # crash
```
[Bug #16098]
Notes:
Merged: https://github.com/ruby/ruby/pull/2391
|
|
|
|
|
|
|
|
Should compare minimum required version, and with the particular
macro defined for each version. Also made the error messages
consistent.
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/2390
|
|
|
|
The second argument of ioctl seems to be int in Android.
Android is not a supported platform, but this one-line change allows
ruby to build by Android NDK r20.
|
