| Age | Commit message (Collapse) | Author |
|
https://github.com/ruby/csv/commit/936f15f3cd
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
GitHub: fix GH-120
Reported by Kyle d'Oliveira. Thanks!!!
https://github.com/ruby/csv/commit/2959483f90
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/6e83a1de9c
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
with non String
GitHub: fix GH-123
Reported by asm256. Thanks!!!
https://github.com/ruby/csv/commit/b4492139be
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This reverts commit 736174d28413a4c36630b0daf2f170c8d2fc9abe.
It doesn't solve anything.
https://github.com/ruby/csv/commit/0ee3bdd0d3
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/736174d284
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/cd670595d5
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/edc6cb9022
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
GitHub: fix #115
Reported by TOMITA Masahiro. Thanks!!!
https://github.com/ruby/csv/commit/398b3564c5
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/fb10925271
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/dbf55ef008
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
with anchors (#110)
* Do not loop forever when skip_lines regexp matches zero length with anchors
* Remove needless white spaces
* Add missing eos check in skip_needless_lines
* Simplify test
https://github.com/ruby/csv/commit/3b15d4a3e8
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
* Make CSV::Row#dup return a usable Row
Previously, calling `dup` on a `CSV::Row` object yielded an object whose
copy was too shallow. Changing the clone's fields would also change the
fields on the source. This change makes the clone more distinct from the
source, so that changes can be made to its fields without affecting the
source.
* Simplify
https://github.com/ruby/csv/commit/64a1ea06fc
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/b37df55f46
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
https://github.com/ruby/csv/commit/284ce810bc
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
This reverts commit 375cf129189f32f7be76ac525035bcde691a63e7, to
sync csv from the upstream.
Notes:
Merged: https://github.com/ruby/ruby/pull/3332
|
|
Popular Ruby libraries such as Rails and Rubocop relying on the
previous behavior, even though it is technically a bug. The
correct behavior is probably raising RangeError, since that is what
an endless range raises.
Related to [Bug #17017]
|
|
|
|
|
|
* Fix Range#max for beginless Integer ranges
* Update test/ruby/test_range.rb
* Fix formatting
https://github.com/ruby/ruby/pull/3328
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Notes:
Merged-By: nobu <nobu@ruby-lang.org>
|
|
The benchmark result is below:
| |compare-ruby|built-ruby|
|:---------------|-----------:|---------:|
|ary2.min | 39.105M| 39.442M|
| | -| 1.01x|
|ary10.min | 23.995M| 30.762M|
| | -| 1.28x|
|ary100.min | 6.249M| 10.783M|
| | -| 1.73x|
|ary500.min | 1.408M| 2.714M|
| | -| 1.93x|
|ary1000.min | 828.397k| 1.465M|
| | -| 1.77x|
|ary2000.min | 332.256k| 570.504k|
| | -| 1.72x|
|ary3000.min | 338.079k| 573.868k|
| | -| 1.70x|
|ary5000.min | 168.217k| 286.114k|
| | -| 1.70x|
|ary10000.min | 85.512k| 143.551k|
| | -| 1.68x|
|ary20000.min | 43.264k| 71.935k|
| | -| 1.66x|
|ary50000.min | 17.317k| 29.107k|
| | -| 1.68x|
|ary100000.min | 9.072k| 14.540k|
| | -| 1.60x|
|ary1000000.min | 872.930| 1.436k|
| | -| 1.64x|
compare-ruby is 9f4b7fc82e.
Notes:
Merged-By: mrkn <mrkn@ruby-lang.org>
|
|
The benchmark result is below:
| |compare-ruby|built-ruby|
|:---------------|-----------:|---------:|
|ary2.max | 38.837M| 40.830M|
| | -| 1.05x|
|ary10.max | 23.035M| 32.626M|
| | -| 1.42x|
|ary100.max | 5.490M| 11.020M|
| | -| 2.01x|
|ary500.max | 1.324M| 2.679M|
| | -| 2.02x|
|ary1000.max | 699.167k| 1.403M|
| | -| 2.01x|
|ary2000.max | 284.321k| 570.446k|
| | -| 2.01x|
|ary3000.max | 282.613k| 571.683k|
| | -| 2.02x|
|ary5000.max | 145.120k| 285.546k|
| | -| 1.97x|
|ary10000.max | 72.102k| 142.831k|
| | -| 1.98x|
|ary20000.max | 36.065k| 72.077k|
| | -| 2.00x|
|ary50000.max | 14.343k| 29.139k|
| | -| 2.03x|
|ary100000.max | 7.586k| 14.472k|
| | -| 1.91x|
|ary1000000.max | 726.915| 1.495k|
| | -| 2.06x|
Notes:
Merged-By: mrkn <mrkn@ruby-lang.org>
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3322
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3310
|
|
Requested by ko1.
Notes:
Merged: https://github.com/ruby/ruby/pull/3314
|
|
|
|
The HTTP test hits a remote website which isn't always available and is
not self-contained. Ideally we will rewrite this test with an internal
web server.
Notes:
Merged: https://github.com/ruby/ruby/pull/3321
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3320
|
|
|
|
The "sync with commits" scripts failed to properly import these for some
reason.
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
This error happen in a CI run, and as it is currently, it doesn't give
any useful information about the underlying cause. Let's not swallow the
original error.
https://github.com/rubygems/rubygems/commit/8c17ba2f45
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/58d9a3de5b
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The newly added specs needs to be tagged as
:readline, otherwise they fail on Windows with
the backtrace: `ZeroDivisionError: divided by 0`.
Such issues are already being skipped on Windows.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/391f860af4
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Since this PR was made because we missed checking
RuboCop offenses with different flags, therefore
adding tests so that all flag combinations are
tested.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/d08250efc2
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/679008f23a
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The Gemfile wasn't properly put in the last commit.
As a result, Layout/EmptyLines inspected an offense
in the Gemfile.
This also fixes the spec w.r.t change in the task
default.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/d1418fddd3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
If the blank lines aren't used, then rubocop tries to
sort them in alphabetical order within their section.
Thus, adding lines so rubocop considers them as
different sections and doesn't try to sort them.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/cf44b18f0f
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
In case of multiple Rake tasks, the default tasks would
look something like this:
`task default: [:spec, :rubocop]`
Instead, they should use %i and look something like this:
`task default: %i[spec rubocop]`
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/487ecd59ce
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With #3731 and #3740 merged, this covers up the
remaining part of the issues.
This was discovered when one tries to create a gem
with a different framework.
Could be reproduced with:
`bundle gem foo --ext --test=test-unit`
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/51b6457150
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Instead we can rely on `LoadError#path`
https://github.com/rubygems/rubygems/commit/16d5c3b43c
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/27e0e4ecb6
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/cdc201f5c4
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Right now, we're not specifying the version constraints
on RuboCop that is shipped when a new gem is created.
This can break specs which runs rubocop on a new
skeleton gem as the newer versions of RuboCop are
released.
This commit ensures that the specs don't break by
constraining the RuboCop version.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/0b47243edd
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Everything is already fetched locally.
https://github.com/rubygems/rubygems/commit/9c304639b1
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/6e0c28d3ab
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
It simplifies things and should avoid issues like the one we had where
the master branch had a bad `.gitattributes` file and changing it on a
PR would be disregarded.
In order for this to work, we need to make sure to fetch all tags from
the repository, so that they can properly be checked out later. This
does not apply to the case of testing against `RGV=..`, since no extra
cloning is needed there.
https://github.com/rubygems/rubygems/commit/d088d936b8
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
ruby_core has an 'ast.rb' file that gets in the
middle and breaks this spec, so it's better we skip
this test on this workflow for now.
Also, slightly change the spec name from "run" to
"runs" and change the last assertion, it's cleaner
to check empty error.
Thanks to David Rodríguez for this!
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/ba8eaa70c3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|