summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-01[rubygems/rubygems] Fix generated standalone script for default gemsDavid Rodríguez
The installer is actually rewriting the spec's full gem path to be the one of the newly installed gem, however the accessor was not properly working for `StubSpecification` instances, and default gems are always of this type, because they are always present locally. Fix the accessor to properly update the underlying full specification. https://github.com/rubygems/rubygems/commit/efa41babfa
2022-06-01[rubygems/rubygems] Remove code that seems unnecessaryDavid Rodríguez
This change was never covered with a spec, and we have recently covered the case of partially deleted gems with specs and it works fine (installation is "auto-healed"). https://github.com/rubygems/rubygems/commit/6e66ee4235
2022-06-01[rubygems/rubygems] Restore ability to load old marshalled gemspec that use ↵David Rodríguez
`YAML::PrivateType` This issue was not detected because when all traces of old YAML parser and emitter `Syck` were removed, this null-type.gemspec.rz marshalled gemspec was updated to no longer load `YAML::Syck::PrivateType` but load `Psych::PrivateType` instead. However, realworld old marshalled gemspecs still use the `YAML::PrivateType` constant, so this commit replaces the gemspec to be the real pry-0.4.7 marshalled gemspec, so that it catches this issue. https://github.com/rubygems/rubygems/commit/51b330b8d2
2022-06-01[rubygems/rubygems] Improve null private type testDavid Rodríguez
This test is making sure that RubyGems is able to load old marshalled gemspecs that include a field loading `YAML::PrivateType` instances in the `rubyforge_project` field instead of `nil` due to a bug in old YAML emitters. At some point, the `rubyforge_project` field was removed and this test was updated to just check another field. However, in the realworld other fields do not have this issue and the marshalled gemspec we use for testing still has this issue in the field reserved for the `rubyforge_project` field. So I think updating the test to check other field was not correct. Instead, since the `rubyforge_project` field is now ignored, we no longer need to worry about any conversion in this field. The only thing we care about is that the marshal loading still works (which requires that the constant is at least defined). So this commit updates the test to make this more clear. https://github.com/rubygems/rubygems/commit/cddfacf6d4
2022-06-01[rubygems/rubygems] Remove no longer needed `Psych::PrivateType` cleanupDavid Rodríguez
This old bug used to affect the `rubyforge_project` field in serialized gemspecs. However, this field has been removed and it's no longer present in marshaled loaded gemspecs. So, while the constant is still present in these marshalled gemspecs and we still need to make sure it exists, we no longer need to clean it up from the loaded data. https://github.com/rubygems/rubygems/commit/09df18e522
2022-06-01* 2022-06-01 [ci skip]git
2022-06-01[rubygems/rubygems] Skip duplicated dependency warning for gemspec dev depsDavid Rodríguez
Generally this warning is skipped for gemspec development dependencies. I think because it's common to override them in the Gemfile to change the source, for example. But the order of conditions was not correct and the warning was still being printed in one case. https://github.com/rubygems/rubygems/commit/da9d1d6a3f
2022-05-31[rubygems/rubygems] Give better conflict resolution adviceDavid Rodríguez
This alternative really uses only the Gemfile, and can never end up being absurd, because it will never be suggested when there's no lockfile, and it suggests deleting the lockfile. https://github.com/rubygems/rubygems/commit/5d154dd50e
2022-05-30Add information from doc/hacking.md and doc/make_cheatsheet.md back i… (#5963)Jemma Issroff
Add information from doc/hacking.md and doc/make_cheatsheet.md back into contributing docs Notes: Merged-By: peterzhu2118 <peter@peterzhu.ca>
2022-05-31Skip failing test with freebsdHiroshi SHIBATA
2022-05-31[rubygems/rubygems] Bump rb-sys in ↵dependabot[bot]
/test/rubygems/test_gem_ext_cargo_builder/custom_name Bumps [rb-sys](https://github.com/ianks/rb-sys) from v0.7.3 to v0.9.0. - [Release notes](https://github.com/ianks/rb-sys/releases) - [Commits](https://github.com/ianks/rb-sys/compare/4a5dd9782075fc6e197976eb2188231a388c3c95...https://github.com/rubygems/rubygems/commit/e4f00b9761af) --- updated-dependencies: - dependency-name: rb-sys dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> https://github.com/rubygems/rubygems/commit/874bbc96b2
2022-05-30Add yjit.o to DTRACE_DEPENDENT_OBJSJakub Kulík
In principle, we have a DTrace probe in yjit.c, so yjit.o should be in DTRACE_DEPENDENT_OBJS for DTRACE_REBUILD=yes builds. This commit adds to the list. In practice DTRACE_REBUILD=yes implies the system has a Solaris-like DTrace and YJIT doesn't support those systems. YJIT_OBJ expands to nothing, and yjit.c isn't compiled. I tested on OmniOS v11 r151034m with: $ ../src/configure --with-out-ext=psych MAKE=gmake AR=ar debugflags=-g $ gmake -j It builds before and after this change. [Bug #18480] Notes: Merged: https://github.com/ruby/ruby/pull/5891 Merged-By: XrXr
2022-05-31[rubygems/rubygems] Bump rb-sysdependabot[bot]
Bumps [rb-sys](https://github.com/ianks/rb-sys) from v0.7.3 to v0.9.0. - [Release notes](https://github.com/ianks/rb-sys/releases) - [Commits](https://github.com/ianks/rb-sys/compare/4a5dd9782075fc6e197976eb2188231a388c3c95...https://github.com/rubygems/rubygems/commit/e4f00b9761af) --- updated-dependencies: - dependency-name: rb-sys dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> https://github.com/rubygems/rubygems/commit/eb31b14a37
2022-05-30Fix use-after-free with interacting TracePointsAlan Wu
`vm_trace_hook()` runs global hooks before running local hooks. Previously, we read the local hook list before running the global hooks which led to use-after-free when a global hook frees the local hook list. A global hook can do this by disabling a local TracePoint, for example. Delay local hook list loading until after running the global hooks. Issue discovered by Jeremy Evans in GH-5862. [Bug #18730] Notes: Merged: https://github.com/ruby/ruby/pull/5865
2022-05-31* 2022-05-31 [ci skip]git
2022-05-31[ruby/fileutils] [DOC] Enhanced RDoc (https://github.com/ruby/fileutils/pull/77)Burdette Lamar
Treats: ::copy_entry ::copy_file ::copy_stream ::mv https://github.com/ruby/fileutils/commit/d6d7e5330d
2022-05-30Skip failing test with freebsdHiroshi SHIBATA
2022-05-30[rubygems/rubygems] Fix crash when commenting out a mirror in configurationDavid Rodríguez
https://github.com/rubygems/rubygems/commit/2d99277328
2022-05-30[rubygems/rubygems] Fix crash when installing gems with symlinksDavid Rodríguez
If BUNDLE_PATH is configured to a symlinked path, installing gems with symlinks would crash with an error like this: ``` Gem::Package::SymlinkError: installing symlink 'man/man0/README.markdown' pointing to parent path /usr/home/stevewi/srv/mail/lib/tools/.vendor/ruby/3.1.0/gems/binman-5.1.0/README.markdown of /srv/mail/lib/tools/.vendor/ruby/3.1.0/gems/binman-5.1.0 is not allowed ``` This commit fixes the problem by changing the bundle path to be the realpath of the configured value, right after we're sure the path has been created. https://github.com/rubygems/rubygems/commit/3cd3dd142a
2022-05-30[rubygems/rubygems] No need to use `FileUtils` to create symlinksDavid Rodríguez
https://github.com/rubygems/rubygems/commit/70ff7cee9f
2022-05-30[rubygems/rubygems] Fix failing spec on WindowsDavid Rodríguez
https://github.com/rubygems/rubygems/commit/8e68c57457
2022-05-30[rubygems/rubygems] Remove seemingly unnecessary codeDavid Rodríguez
https://github.com/rubygems/rubygems/commit/f5dd5204ca
2022-05-30[ruby/stringio] Fix extracting encoding names in the fallback codeNobuyoshi Nakada
https://github.com/ruby/stringio/commit/0fe2e0c1e5
2022-05-30[ruby/stringio] Accept external and internal encodings pairNobuyoshi Nakada
Fix https://github.com/ruby/stringio/pull/16 https://github.com/ruby/stringio/commit/c8a69e80d2
2022-05-30Also skip failing test with freebsd 12Hiroshi SHIBATA
2022-05-29Update rubyspec for stringio bug fixJeremy Evans
2022-05-30[ruby/stringio] Fix handling of chomp with paragraph separatorJeremy Evans
Try to mirror IO behavior, where chomp takes out the entire paragraph separators between entries, but does not chomp a single line separator at the end of the string. Partially Fixes [Bug #18768] https://github.com/ruby/stringio/commit/a83ddbb7f0
2022-05-30[ruby/stringio] Update ext/stringio/stringio.cJeremy Evans
https://github.com/ruby/stringio/commit/1edc88587e Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2022-05-30[ruby/stringio] Ignore chomp keyword for nil separatorJeremy Evans
nil separator means no separator at all, so nothing should be chomped. Partial fix for Ruby [Bug #18770] https://github.com/ruby/stringio/commit/feaa2ec631
2022-05-30[ruby/stringio] Fix each with multiple character string and chompJeremy Evans
Previously, this could result in an infinite loop. Always update the e pointer in this case, setting w when chomping so the chomped data is not included in the output. Fixes [Bug #18769] https://github.com/ruby/stringio/commit/4bf64d5130
2022-05-30[ruby/stringio] Fix expanding size at ungetc/ungetbyteNobuyoshi Nakada
https://github.com/ruby/stringio/commit/a35268a3ac
2022-05-30Reduce duplicate replacementsNobuyoshi Nakada
Reduce duplicate replacements so that reflect macros in command lines consitently. So that reflect macros in command lines. Others than `nmake` have no problems with nested expansions.
2022-05-30Skip failing test with freebsdHiroshi SHIBATA
2022-05-29YJIT: Relax minimum Rust version requirement to 1.58.1Alan Wu
We want to make it convenient for people to build YJIT and Rust version 1.58.1 or above is available on Ubuntu Jammy, Debian testing, and Fedora 36 through the usual package manager on those systems. This saves the need to install `rustup` for some people. Our code is already 1.58.1 compatible so this commit simply tweaks CI to make sure that we keep supporting that version. We still test against the latest Rust version in `--enable-yjit=dev` builds through the Rust version available in GitHub's CI image. Rust versions older than 1.58.1 might build YJIT today, but we might make incompatible changes in the future. Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> Notes: Merged: https://github.com/ruby/ruby/pull/5951 Merged-By: XrXr
2022-05-30* 2022-05-30 [ci skip]git
2022-05-30[rubygems/rubygems] Ignore `Errno::EROFS` errors when creating `bundler.lock`David Rodríguez
Apparently old versions of MacOS would set `GEM_HOME` to a `/System` folder, and trying to create a file there raises `Errno::EROFS`. We ignore the error. Any permission issues should be better handled further down the line. https://github.com/rubygems/rubygems/commit/ef90c071d0
2022-05-29[rubygems/rubygems] Ignore `Errno::EPERM` errors when creating `bundler.lock`David Rodríguez
This kind of error can happen when setting `GEM_HOME` to a path under MacOS System Integrity Protection. We ignore the error. Any permission issues should be better handled further down the line. https://github.com/rubygems/rubygems/commit/174cb66863
2022-05-29* 2022-05-29 [ci skip]git
2022-05-28Revert flawed doc for slice_after, slice_when, and chunk_while (#5952)Burdette Lamar
Restores doc for the methods that were cited in https://bugs.ruby-lang.org/issues/18765. Notes: Merged-By: BurdetteLamar <BurdetteLamar@Yahoo.com>
2022-05-28[rubygems/rubygems] Make code to find target update version easier to followDavid Rodríguez
https://github.com/rubygems/rubygems/commit/a7f81cc7ee
2022-05-28[rubygems/rubygems] Remove unnecessary name and platform filterDavid Rodríguez
It's already done before. https://github.com/rubygems/rubygems/commit/49d28cfde5
2022-05-28[rubygems/rubygems] Fix rubygems update when non default `--install-dir` is ↵David Rodríguez
configured https://github.com/rubygems/rubygems/commit/9f3b21192d
2022-05-28Make `Kernel#p` completely uninterruptible.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Tidy up usage of write_lock.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Improve handling of zero length writes.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Improve consistency of `io_binwritev_internal` implementaiton.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Improve error handling in `finish_writeconv`.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Better handling of `error`.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Always allocate write_lockmachty
Notes: Merged: https://github.com/ruby/ruby/pull/5419
2022-05-28Add IO write throughput/locking overhead benchmark.Samuel Williams
Notes: Merged: https://github.com/ruby/ruby/pull/5419