Age | Commit message (Collapse) | Author |
|
We think it's unlikely that `rubygems/defaults/operating_system` could be shipped with a SyntaxError so StandardError could be better choice to prevent "false positives" errors.
https://github.com/rubygems/rubygems/commit/1f73e784dd
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
For errors that could happened while loading `rubygems/defaults/operating_system`
https://github.com/rubygems/rubygems/commit/6e1e2141f8
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/58da501e5d
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/0822e1c260
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
operating_system.rb
truffleruby does not raise any error when requiring `rubygems`.
https://github.com/rubygems/rubygems/commit/21e2fcd0b2
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
rubygems/defaults/operating_system file
When loading `rubygems/defaults/operating_system`
- we want to keep it silent if the raised exception is a LoadError
- we want to print a message in other cases and ask users to report the issue to their OS support.
Ruby 3 comes with special error handling for loading `rubygems` and it will show a warning when LoadError exception raised for requiring 'rubygem'.
Because of that, we decided to leave the LoadError scenario as it is.
Reference: https://github.com/ruby/ruby/blob/d1998d8767affe58be0bd09ec536dae9198a7fbd/gem_prelude.rb#L1-L5
https://github.com/rubygems/rubygems/commit/0a97e12fe1
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/82960c262f
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/58fc31442f
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Running `bundler` specs using `bundler` is not supported.
https://github.com/rubygems/rubygems/commit/cc97b6773d
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
When setting the `RUBYGEMS_GEMDEPS` environment variable to allow
skipping `bundle exec`, `bundler` will print a warning about potential
incompatibility.
Initially the `RUBYGEMS_GEMDEPS` variable used a completely different
(re)implementation of `bundler` functionality. That implementation was
not battle tested and could potentially differ in behaviour from what
`bundler` does. That's why print a warning.
However, these days, all `rubygems` does when `RUBYGEMS_GEMDEPS` is set
is to require `bundler/setup`, so there's no risk of any
incompatibility, since that's just plain `bundler`.
https://github.com/rubygems/rubygems/commit/bbddc27016
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Given Windows doesn't have executable bit.
https://github.com/rubygems/rubygems/commit/35dc3fa845
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/4028cbc408
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/91dca11112
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
generated config
Even if it only has one entry at the moment, it makes it easier to add
new entries by doing it this way.
https://github.com/rubygems/rubygems/commit/46232fe265
Co-authored-by: NeimadTL <damientalbot26@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
config
Otherwise CI will run once for every pull request update and once for
every push.
The disavantage is that people working on a non default branch without
creating pull requests won't get CI run at all.
I think the advantages are greater than the disadvantages, it's also my
personal workflow, and it's something desired enough so that someone
opened an issue about it.
So let's do it!
https://github.com/rubygems/rubygems/commit/924d916a73
Co-authored-by: NeimadTL <damientalbot26@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/320fdc1513
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
As far as I understand, this block should only be run when
`bundler/setup` fails. The only other case where these errors could be
run is when bundler itself is required.
If bundler itself fails to be required or activated (like in old rubies
where it was not a default gem, for example), the raw error is much more
helpful than this message.
So we can move the rescue after bundler is succesfully required, and
that simplifies the list of exceptions that we need to track to just
`Bundler::Error`.
https://github.com/rubygems/rubygems/commit/3663c11e93
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Instead of having to match classes and re-raise in the exception body.
https://github.com/rubygems/rubygems/commit/5edf74b781
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
The previous behavior was to automatically require `bundler/setup`
everytime `rubygems` was required, which I think was too much.
https://github.com/rubygems/rubygems/commit/b25379a295
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/c31b8cd232
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/a2d6e10192
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
When I read, I thought the assertion was incorrect. It's doing the right
thing, though.
https://github.com/rubygems/rubygems/commit/e72c27367a
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
The commented out code causes failing tests because it's not correct.
https://github.com/rubygems/rubygems/commit/38f0eca91a
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/c7c00c280f
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/36a00144b9
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/591466d512
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/ed845d861c
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/88b7a3e7e2
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
The processed YML data is included as metadata, the source gemspec
file is unused and just confusing.
https://github.com/rubygems/rubygems/commit/f444478eac
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
between sentence breaks
https://github.com/rubygems/rubygems/commit/5cdda53382
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/d74830d00b
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
network
If the cache was missing, `bundler` would try to re-fetch it. With the
`--local` flag, it should just look at installed gems.
https://github.com/rubygems/rubygems/commit/630d29c69e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/06f5efce02
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
When printing sources inside these error messages, it's useful to only
consider the current state of the source. For example, when requiring
`bundler/setup`, the source shouldn't be configured to be able to hit
the network, so the error message should only mention "locally installed
gems" to make that more clear.
https://github.com/rubygems/rubygems/commit/30eb14f853
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/9fd39bd5a3
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Since all requirements have an explicit source now (even if it's the
default source).
https://github.com/rubygems/rubygems/commit/2c341cfc22
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
It doesn't really add much, in my opinion. We want to be helpful, but
also concise when possible.
https://github.com/rubygems/rubygems/commit/9d56009cf7
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
In the case of path sources, the path the source is pointing to should
be added directly to the `$LOAD_PATH` without any modifications.
https://github.com/rubygems/rubygems/commit/d3bba936f0
Co-authored-by: Daniel Niknam <mhmd.niknam@gmail.com>
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Under some case, this variable might not end up being used, in which
case running the script would print unused variable warnings.
https://github.com/rubygems/rubygems/commit/bf96030362
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/fcb8c3d188
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Under some case, this variable might not end up being used, in which
case running the script would print unused variable warnings.
https://github.com/rubygems/rubygems/commit/a2d6392ada
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
We can use `__dir__` directly.
https://github.com/rubygems/rubygems/commit/0e6083ca94
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Due to the `bundler` gem itself being ignored from `$LOAD_PATHS`, a
`nil` value is being introduced here, resulting in the current folder
being added to the `$LOAD_PATH` by the standalone script.
I'm pretty sure this is unintentional.
https://github.com/rubygems/rubygems/commit/df54b07b5e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
This should fix a weird flaky spec failure, given that the code
producing the error will be no longer run.
https://github.com/rubygems/rubygems/commit/a171965409
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
https://github.com/rubygems/rubygems/commit/f28ab141af
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
No need to fill up missing names from sources anymore since they should
now be properly set up correctly from the beginning.
https://github.com/rubygems/rubygems/commit/706fd28681
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
compatibility mode
Since this mode is only enabled in frozen mode, it's fine to use the
lockfile and means we don't have to "prepare" the replacement for
materialization.
https://github.com/rubygems/rubygems/commit/dda01b288e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
Rubygems source replacement was broken.
https://github.com/rubygems/rubygems/commit/3549c122f6
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
TSort was released as a library so we can install it, and also other
gems that are loaded by the spec. Also, Ruby on Windows apparently loads
fiddle 1.0.6, so we need to also install that to make that not fail.
https://github.com/rubygems/rubygems/commit/2b8dcab99e
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|
|
These gems are built and installed to system directly as default gems.
There's no need to also build a remote repo.
https://github.com/rubygems/rubygems/commit/ad9dad4c22
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
|