summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-26include/ruby/ruby.h: suppress a false-positive warning of GCCYusuke Endoh
GCC emits a lot of false positives for rb_scan_args because: * `rb_scan_args(argc, argv, "*:", NULL, &opts);` makes `n_mand == 0`, * `n_mand == argc + 1` implies `argc == -1`, and * `memcpy(ptr, argv, sizeof(VALUE)*argc);` explodes However, we know that argc is never so big, thus this is a false positive. This change suppresses it by adding a condition `n_mand > 0`. ``` In file included from /usr/include/string.h:494, from ./include/ruby/defines.h:145, from ./include/ruby/ruby.h:29, from ./include/ruby/encoding.h:27, from dir.c:14: In function 'memcpy', inlined from 'ruby_nonempty_memcpy.part.0' at ./include/ruby/ruby.h:1763:17, inlined from 'ruby_nonempty_memcpy' at ./include/ruby/ruby.h:1760:1, inlined from 'rb_scan_args_set' at ./include/ruby/ruby.h:2594:9, inlined from 'dir_s_aref' at dir.c:2774:12: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: warning: '__builtin___memcpy_chk' pointer overflow between offset 0 and size [-8, 9223372036854775807] [-Warray-bounds] return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: warning: '__builtin___memcpy_chk' specified size 18446744073709551608 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] ```
2019-09-26[ruby/io-console] Defer creating VT query stringNobuyoshi Nakada
https://github.com/ruby/io-console/commit/3d69c577a4
2019-09-26[ruby/io-console] Added IO#console_modeNobuyoshi Nakada
https://github.com/ruby/io-console/commit/77ed8d5a06
2019-09-25Add Module#ruby2_keywords for passing keywords through regular argument splatsJeremy Evans
This approach uses a flag bit on the final hash object in the regular splat, as opposed to a previous approach that used a VM frame flag. The hash flag approach is less invasive, and handles some cases that the VM frame flag approach does not, such as saving the argument splat array and splatting it later: ruby2_keywords def foo(*args) @args = args bar end def bar baz(*@args) end def baz(*args, **kw) [args, kw] end foo(a:1) #=> [[], {a: 1}] foo({a: 1}, **{}) #=> [[{a: 1}], {}] foo({a: 1}) #=> 2.7: [[], {a: 1}] # and warning foo({a: 1}) #=> 3.0: [[{a: 1}], {}] It doesn't handle some cases that the VM frame flag handles, such as when the final hash object is replaced using Hash#merge, but those cases are probably less common and are unlikely to properly support keyword argument separation. Use ruby2_keywords to handle argument delegation in the delegate library. Notes: Merged: https://github.com/ruby/ruby/pull/2477
2019-09-25Make rb_scan_args handle keywords more similar to Ruby methods (#2460)Jeremy Evans
Cfuncs that use rb_scan_args with the : entry suffer similar keyword argument separation issues that Ruby methods suffer if the cfuncs accept optional or variable arguments. This makes the following changes to : handling. * Treats as **kw, prompting keyword argument separation warnings if called with a positional hash. * Do not look for an option hash if empty keywords are provided. For backwards compatibility, treat an empty keyword splat as a empty mandatory positional hash argument, but emit a a warning, as this behavior will be removed in Ruby 3. The argument number check needs to be moved lower so it can correctly handle an empty positional argument being added. * If the last argument is nil and it is necessary to treat it as an option hash in order to make sure all arguments are processed, continue to treat the last argument as the option hash. Emit a warning in this case, as this behavior will be removed in Ruby 3. * If splitting the keyword hash into two hashes, issue a warning, as we will not be splitting hashes in Ruby 3. * If the keyword argument is required to fill a mandatory positional argument, continue to do so, but emit a warning as this behavior will be going away in Ruby 3. * If keyword arguments are provided and the last argument is not a hash, that indicates something wrong. This can happen if a cfunc is calling rb_scan_args multiple times, and providing arguments that were not passed to it from Ruby. Callers need to switch to the new rb_scan_args_kw function, which allows passing of whether keywords were provided. This commit fixes all warnings caused by the changes above. It switches some function calls to *_kw versions with appropriate kw_splat flags. If delegating arguments, RB_PASS_CALLED_KEYWORDS is used. If creating new arguments, RB_PASS_KEYWORDS is used if the last argument is a hash to be treated as keywords. In open_key_args in io.c, use rb_scan_args_kw. In this case, the arguments provided come from another C function, not Ruby. The last argument may or may not be a hash, so we can't set keyword argument mode. However, if it is a hash, we don't want to warn when treating it as keywords. In Ruby files, make sure to appropriately use keyword splats or literal keywords when calling Cfuncs that now issue keyword argument separation warnings through rb_scan_args. Also, make sure not to pass nil in place of an option hash. Work around Kernel#warn warnings due to problems in the Rubygems override of the method. There is an open pull request to fix these issues in Rubygems, but part of the Rubygems tests for their override fail on ruby-head due to rb_scan_args not recognizing empty keyword splats, which this commit fixes. Implementation wise, adding rb_scan_args_kw is kind of a pain, because rb_scan_args takes a variable number of arguments. In order to not duplicate all the code, the function internals need to be split into two functions taking a va_list, and to avoid passing in a ton of arguments, a single struct argument is used to handle the variables previously local to the function. Notes: Merged-By: jeremyevans <code@jeremyevans.net>
2019-09-26* 2019-09-26 [ci skip]git
2019-09-26Get rid of `IO.select` to fix multiline pasteNobuyoshi Nakada
2019-09-25[DOC] fixed the return value of IO#ready? [ci skip]Nobuyoshi Nakada
IO#ready? returns true or false only, since r50262(1baa57b0033).
2019-09-25check `ARY_SHARED_ROOT_P()`.Koichi Sasada
ARY_SHARED_ROOT_P(ary) is true, ARY_HEAP_CAPA(ary) should not be called.
2019-09-25introduce `obj_ary_extracapa`.Koichi Sasada
Introduce a new debug counter `obj_ary_extracapa` which counts arrays which are `len < capa`.
2019-09-25lldb_inspect: removed unnecessary newline and `end` optionNobuyoshi Nakada
2019-09-25Removed idNUMPARAM_0Nobuyoshi Nakada
2019-09-25Changed numbered parameters semanticsNobuyoshi Nakada
* `_1` (and no other numbered parameters) to work as `|x|`. * giving up `_0`. [ruby-core:95074] [Bug #16178]
2019-09-25Simplified duplicate codeNobuyoshi Nakada
2019-09-25Revert "[ruby/io-console] Skip cursor position test on Solaris"Kazuhiro NISHIYAMA
This reverts commit 5294ded681992ced2ecbd31c814b63265d2f591e.
2019-09-25Do not use of non-standard escape character '\e'Kazuhiro NISHIYAMA
2019-09-25[ruby/io-console] Unique paths to be addedNobuyoshi Nakada
https://github.com/ruby/io-console/commit/a3ad851b6c
2019-09-25[ruby/io-console] Load the current librariesNobuyoshi Nakada
https://github.com/ruby/io-console/commit/ab7653c543
2019-09-25* 2019-09-25 [ci skip]git
2019-09-25[ruby/io-console] Skip cursor position test on SolarisNobuyoshi Nakada
It results in a mysterious failure. https://github.com/ruby/io-console/commit/e3543c3da4
2019-09-24Make numbered parameters exclusive in a scopeNobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/2431
2019-09-24Changed numbered parameter prefixNobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/2431
2019-09-24Added implicit block parameterNobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/2431
2019-09-24Rename from ruby-x.y.z.ext.draft to ruby-x.y.z-draft.ext [ci skip]Kazuhiro NISHIYAMA
2019-09-24misc/lldb_cruby.py: update for python3 [ci skip]Nobuyoshi Nakada
lldb module bundled with Xcode is for Python 3 now.
2019-09-24misc/lldb_cruby.py: removed unused module `commands` [ci skip]Nobuyoshi Nakada
2019-09-24[ruby/io-console] Made cursor position 0-originNobuyoshi Nakada
https://github.com/ruby/io-console/commit/9377e37295
2019-09-24[ruby/io-console] Made cursor position consistent with `winsize`Nobuyoshi Nakada
To be consistent with `winsize`, changed the cursor position format from `[x, y]` to `[row, column]`. https://github.com/ruby/io-console/commit/d1f5ae9286
2019-09-24suppress meddlesome clang10 warrning卜部昌平
It says: vm.c:2519:34: warning: expression does not compute the number of elements in this array; element type is 'const struct __jmp_buf_tag', not 'VALUE' (aka 'unsigned long') [-Wsizeof-array-div] sizeof(ec->machine.regs) / sizeof(VALUE)); ~~~~~~~~~~~~~~~~ ^ vm.c:2519:34: note: place parentheses around the 'sizeof(VALUE)' expression to silence this warning
2019-09-24refactor delete unused variable卜部昌平
cadfaacb2533d47d52dbb5dbefe724d7bf11112e missed it.
2019-09-24* 2019-09-24 [ci skip]git
2019-09-23Make public_send and rb_f_send handle keyword argument separationJeremy Evans
Kernel#send takes a different optimized code path that was already handled. Notes: Merged: https://github.com/ruby/ruby/pull/2481
2019-09-23[ruby/io-console] Try fallback to stdout when stdinNobuyoshi Nakada
https://github.com/ruby/io-console/commit/b8017509ef
2019-09-23[ruby/io-console] Try to write DSR query to writable IONobuyoshi Nakada
https://github.com/ruby/io-console/commit/a54b6e4dd1
2019-09-23Use short wait for select(2)aycabta
It is one of the reasons why paste to IRB is slow.
2019-09-23Retrieve key-buffer that was supposed to loseaycabta
2019-09-23Adjusted directives order of a function [ci skip]Nobuyoshi Nakada
2019-09-23Lazy init thread local storageLourens Naudé
Notes: Merged: https://github.com/ruby/ruby/pull/2295
2019-09-23make-snapshot: store timestamps in UTC for zip which lacks timezoneNobuyoshi Nakada
2019-09-23* 2019-09-23 [ci skip]git
2019-09-23Add `-mtc=off` to `7z` not to store NTFS timestampsKazuhiro NISHIYAMA
https://sevenzip.osdn.jp/chm/cmdline/switches/method.htm
2019-09-22make-snapshot: Added -no7z optionNobuyoshi Nakada
It disables 7z, which seems not to have an option to stop saving extra file attributes (uid/gid and atime), in order to make zip packages stable.
2019-09-22make-snapshot: Do not save extra file attributesNobuyoshi Nakada
Extra file attributes (uid/gid and atime) make the packaged zip file unstable.
2019-09-22st.c: Use rb_st_* prefix instead of st_* (#2479)Yusuke Endoh
The original st.c was public domain hash table implementation, but Ruby's st.c is highly modified, and its data structure is not compatiblie with the original one. Therefore, when creating an extension library to wrap C code that uses the original st.c, the symbols conflict, which leads to segfault. This changes the prefix `st_*` of st.c functions to `rb_st_*` for reflecting that they are specific to Ruby's, and avoid symbol conflicts. Notes: Merged-By: mame <mame@ruby-lang.org>
2019-09-22st.c (st_add_direct_with_hash): make it "static inline"Yusuke Endoh
It was originally static inline, but seemed to be accidentally published at 8f675cdd00e2c5b5a0f143f5e508dbbafdb20ccd.
2019-09-22variable.c: Rename rb_st_copy to rb_iv_tbl_copyYusuke Endoh
This function was created as a variant of st_copy with firing write barrier. It should have more explicit name, such as st_copy_with_write_barrier. But because it is used only for copying iv_tbl, so I rename it to rb_iv_tbl_copy now. If we face other use case than iv_tbl, we may want to rename it to more general name.
2019-09-22test/bigdecimal/test_bigdecimal.rb: Use BigDecimal()Yusuke Endoh
instead of deprecated BigDecimal.new.
2019-09-22Add `if: always()` because 2.4.x's `make check` failed on snapshot [ci skip]Kazuhiro NISHIYAMA
`check-snapshot-ruby_2_4` uses `make test` instead of `make check`. https://github.com/ruby/actions/blob/95692e54f4263501db1508d51c1fb67c03b4f575/.github/workflows/snapshot.yml#L448-L449 `draft-release` use `make check` to make it simple, and actions is required regardless of success or failure. On the other hand, snapshot success can be ignored, so normally it should not fail.
2019-09-22* 2019-09-22 [ci skip]git
2019-09-21Make Kernel#{Pathname,BigDecimal,Complex} return argument if given correct typeJeremy Evans
This is how Kernel#{Array,String,Float,Integer,Hash,Rational} work. BigDecimal and Complex instances are always frozen, so this should not cause backwards compatibility issues for those. Pathname instances are not frozen, so potentially this could cause backwards compatibility issues by not returning a new object. Based on a patch from Joshua Ballanco, some minor changes by me. Fixes [Bug #7522] Notes: Merged: https://github.com/ruby/ruby/pull/2473
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-30 01:40:57 +0000