| Age | Commit message (Collapse) | Author |
|---|
|
These benchmarks should be working fine now.
|
|
to remind us of skipped benchmarks in the CI job names
|
|
|
|
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v6...v6.0.1)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v5.0.1...v6)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v5...v5.0.1)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 5.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
This reverts commit 02fd62895d9a13f56253521dedd80e39d4eafbb5.
It stopped working again.
|
|
|
|
At the moment, nothing in the notification tells you whether it was ibm
jobs or not. `matrix.os` seems like the easiest way to include that
information, so I added it in the label.
|
|
The 2 issues that we applied the workarounds for were fixed now.
|
|
Add `make-ibm` job to run ppc64le/s390x cases in the `ubuntu.yml`, and remove
`ubuntu-ibm.yml`. This commit improves removing a duplicated logic between the
`ubuntu.yml` and `ubuntu-ibm.yml`.
I am using the YAML anchors and aliases feature to avoid the duplicated logic.
The document is below.
https://docs.github.com/en/actions/reference/workflows-and-actions/reusing-workflow-configurations#yaml-anchors-and-aliases
I don't add the `make-ibm` job to the `result` job, the line `needs: [make]`
intentionally to make the `make-ibm` job's result optional to merge PRs.
|
|
ubuntu-24.04-arm jobs look working as of 2025-09-16.
|
|
|
|
|
|
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v4...v5)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
They don't start at all and they get cancelled.
https://github.com/ruby/ruby/actions/runs/17476949351/job/49639049451
To unblock PR merges, let's disable it until it's fixed.
|
|
* cp ubuntu.yml ubuntu-ibm.yml
* Revert "CI: ubuntu.yml: Skip user ground id test on ppc64le and s390x"
This reverts commit 9fa87a668836f83ab836d0cbcefb4056622a0ed6.
* Revert "CI: ubuntu.yml: Set HOME env on ppc64le and s390x"
This reverts commit 05b654b43f6d0e92fbc3e1e908d811f031d59e40.
* Revert "CI: ubuntu.yml: Add GitHub Actions s390x case"
This reverts commit 099df0b40b215b2fc5db59569d45c59ee48111a7.
* Remove duplication among copied jobs
|
|
|
|
|
|
This is a temporary workaround.
|
|
This is a temporary workaround.
|
|
Add the s390x case using GitHub Actions ppc64le/s390x service.
https://github.com/IBM/actionspz
We can run the ppc64le/s390x cases only in the registered upstream repositories.
https://github.com/IBM/actionspz/blob/main/docs/FAQ.md#what-about-forked-repos
The following matrix upstream logic is to skip the ppc64le/s390x in the
downstream (fork) repositories.
```
+ upstream:
+ - ${{ github.repository == 'ruby/ruby' }}
```
Use the "os" list to determine the excluded ppc64le/s390x cases by using the
"exclude" syntax. Because the "exclude" syntax are executed before the
"include" syntax.
Add the ubuntu-24.04-ppc64le as a comment, because the GitHub Actions ppc64le
case has the following test errors and failures.
https://bugs.ruby-lang.org/issues/21534
|
|
|
|
|
|
|
|
As Set is now a core collection class, it should have special inspect
output. Ideally, inspect output should be suitable to eval, similar
to array and hash (assuming the elements are also suitable to eval):
set = Set[1, 2, 3]
eval(set.inspect) == set # should be true
The simplest way to do this is to use the Set[] syntax.
This deliberately does not use any subclass name in the output,
similar to array and hash. It is more important that users know they
are dealing with a set than which subclass:
Class.new(Set)[]
# this does: Set[]
# not: #<Class:0x00000c21c78699e0>[]
This inspect change breaks the power_assert bundled gem tests, so
add power_assert to TEST_BUNDLED_GEMS_ALLOW_FAILURES in the workflows.
Implements [Feature #21389]
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/13651
|
|
|
|
|
|
|
|
Notes:
Merged-By: k0kubun <takashikkbn@gmail.com>
|
|
Set has been an autoloaded standard library since Ruby 3.2.
The standard library Set is less efficient than it could be, as it
uses Hash for storage, which stores unnecessary values for each key.
Implementation details:
* Core Set uses a modified version of `st_table`, named `set_table`.
than `s/st_/set_/`, the main difference is that the stored records
do not have values, making them 1/3 smaller. `st_table_entry` stores
`hash`, `key`, and `record` (value), while `set_table_entry` only
stores `hash` and `key`. This results in large sets using ~33% less
memory compared to stdlib Set. For small sets, core Set uses 12% more
memory (160 byte object slot and 64 malloc bytes, while stdlib set
uses 40 for Set and 160 for Hash). More memory is used because
the set_table is embedded and 72 bytes in the object slot are
currently wasted. Hopefully we can make this more efficient and have
it stored in an 80 byte object slot in the future.
* All methods are implemented as cfuncs, except the pretty_print
methods, which were moved to `lib/pp.rb` (which is where the
pretty_print methods for other core classes are defined). As is
typical for core classes, internal calls call C functions and
not Ruby methods. For example, to check if something is a Set,
`rb_obj_is_kind_of` is used, instead of calling `is_a?(Set)` on the
related object.
* Almost all methods use the same algorithm that the pure-Ruby
implementation used. The exception is when calling `Set#divide` with a
block with 2-arity. The pure-Ruby method used tsort to implement this.
I developed an algorithm that only allocates a single intermediate
hash and does not need tsort.
* The `flatten_merge` protected method is no longer necessary, so it
is not implemented (it could be).
* Similar to Hash/Array, subclasses of Set are no longer reflected in
`inspect` output.
* RDoc from stdlib Set was moved to core Set, with minor updates.
This includes a comprehensive benchmark suite for all public Set
methods. As you would expect, the native version is faster in the
vast majority of cases, and multiple times faster in many cases.
There are a few cases where it is significantly slower:
* Set.new with no arguments (~1.6x)
* Set#compare_by_identity for small sets (~1.3x)
* Set#clone for small sets (~1.5x)
* Set#dup for small sets (~1.7x)
These are slower as Set does not currently use the AR table
optimization that Hash does, so a new set_table is initialized for
each call. I'm not sure it's worth the complexity to have an AR
table-like optimization for small sets (for hashes it makes sense,
as small hashes are used everywhere in Ruby).
The rbs and repl_type_completor bundled gems will need updates to
support core Set. The pull request marks them as allowed failures.
This passes all set tests with no changes. The following specs
needed modification:
* Modifying frozen set error message (changed for the better)
* `Set#divide` when passed a 2-arity block no longer yields the same
object as both the first and second argument (this seems like an issue
with the previous implementation).
* Set-like objects that override `is_a?` such that `is_a?(Set)` return
`true` are no longer treated as Set instances.
* `Set.allocate.hash` is no longer the same as `nil.hash`
* `Set#join` no longer calls `Set#to_a` (it calls the underlying C
function).
* `Set#flatten_merge` protected method is not implemented.
Previously, `set.rb` added a `SortedSet` autoload, which loads
`set/sorted_set.rb`. This replaces the `Set` autoload in `prelude.rb`
with a `SortedSet` autoload, but I recommend removing it and
`set/sorted_set.rb`.
This moves `test/set/test_set.rb` to `test/ruby/test_set.rb`,
reflecting that switch to a core class. This does not move the spec
files, as I'm not sure how they should be handled.
Internally, this uses the st_* types and functions as much as
possible, and only adds set_* types and functions as needed.
The underlying set_table implementation is stored in st.c, but
there is no public C-API for it, nor is there one planned, in
order to keep the ability to change the internals going forward.
For internal uses of st_table with Qtrue values, those can
probably be replaced with set_table. To do that, include
internal/set_table.h. To handle symbol visibility (rb_ prefix),
internal/set_table.h uses the same macro approach that
include/ruby/st.h uses.
The Set class (rb_cSet) and all methods are defined in set.c.
There isn't currently a C-API for the Set class, though C-API
functions can be added as needed going forward.
Implements [Feature #21216]
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
Co-authored-by: Oliver Nutter <mrnoname1000@riseup.net>
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/13119
|
|
The following command doesn't work correctly since a backslash doesn't exist after `exec`. This PR fixes it.
```
if [ -n "${LAUNCHABLE_ORGANIZATION}" ]; then
exec
> >(tee launchable_stdout.log) \
2> >(tee launchable_stderr.log)
fi
```
Notes:
Merged-By: ono-max <onoto1998@gmail.com>
|
|
Currently, the Launchable team is developing a new feature to attach any logs. Attached log can be anything, such as system logs or stdout. Users can find these logs using any text search. Please note that this feature is a work in progress, so we can't use it yet.
I'm going to attach stdout and stderr as attached logs because they will be useful for finding interpreter bugs. When running tests, we sometimes see interpreter itself crash, and the stack is output to stderr. When debugging the cause of the issue, this feature is useful.
Notes:
Merged-By: ono-max <onoto1998@gmail.com>
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12589
|
|
Use system default 3.2.3, until setup-ruby supports Ubuntu arm64
runners.
Notes:
Merged: https://github.com/ruby/ruby/pull/12594
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12594
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12427
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12212
|
|
We have name fragmentation for this feature, including "shared GC",
"modular GC", and "external GC". This commit standardizes the feature
name to "modular GC" and the implementation to "GC library".
Notes:
Merged: https://github.com/ruby/ruby/pull/12261
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12166
|
|
Co-Authored-By: Peter Zhu <peter@peterzhu.ca>
Notes:
Merged: https://github.com/ruby/ruby/pull/12149
|
|
Instead of passing the full GC SO file name to RUBY_GC_LIBRARY, we now
only need to pass the GC name.
For example, before we needed to pass `RUBY_GC_LIBRARY=librubygc.default.so`
but now we only need to pass `RUBY_GC_LIBRARY=default`.
Notes:
Merged: https://github.com/ruby/ruby/pull/11866
|
|
Since `github.event.pull_request.labels.*.name` is an object filter,
the item to be searched in needs to be the same whole string, not a
partial string.
Notes:
Merged: https://github.com/ruby/ruby/pull/11816
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/11726
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/11723
|
