summaryrefslogtreecommitdiff
path: root/.github/CODEOWNERS
AgeCommit message (Collapse)Author
2026-01-05Add k0kubun as CODEOWNERSTakashi Kokubun
2024-04-03Revert "Migrate auto_request_review back to CODEOWNERS" (#10441)Takashi Kokubun
Revert "Migrate auto_request_review back to CODEOWNERS (#10133)" This reverts commit c5b568bab6a1401df385331e4b6ed6209fe4071d.
2024-02-28Migrate auto_request_review back to CODEOWNERS (#10133)Takashi Kokubun
2022-09-14Remove CODEOWNERS to switch to auto-request-review (#6365)Takashi Kokubun
* Remove CODEOWNERS to switch to auto-request-review * Random change to test reviews * Revert "Random change to test reviews" This reverts commit 814b10d062d82d953019ea4afadc3f8fcf638379. Notes: Merged-By: k0kubun <takashikkbn@gmail.com>
2022-08-23Add @k0kubun to CODEOWNERS for YJITMaxime Chevalier-Boisvert
2022-04-27Rust YJITAlan Wu
In December 2021, we opened an [issue] to solicit feedback regarding the porting of the YJIT codebase from C99 to Rust. There were some reservations, but this project was given the go ahead by Ruby core developers and Matz. Since then, we have successfully completed the port of YJIT to Rust. The new Rust version of YJIT has reached parity with the C version, in that it passes all the CRuby tests, is able to run all of the YJIT benchmarks, and performs similarly to the C version (because it works the same way and largely generates the same machine code). We've even incorporated some design improvements, such as a more fine-grained constant invalidation mechanism which we expect will make a big difference in Ruby on Rails applications. Because we want to be careful, YJIT is guarded behind a configure option: ```shell ./configure --enable-yjit # Build YJIT in release mode ./configure --enable-yjit=dev # Build YJIT in dev/debug mode ``` By default, YJIT does not get compiled and cargo/rustc is not required. If YJIT is built in dev mode, then `cargo` is used to fetch development dependencies, but when building in release, `cargo` is not required, only `rustc`. At the moment YJIT requires Rust 1.60.0 or newer. The YJIT command-line options remain mostly unchanged, and more details about the build process are documented in `doc/yjit/yjit.md`. The CI tests have been updated and do not take any more resources than before. The development history of the Rust port is available at the following commit for interested parties: https://github.com/Shopify/ruby/commit/1fd9573d8b4b65219f1c2407f30a0a60e537f8be Our hope is that Rust YJIT will be compiled and included as a part of system packages and compiled binaries of the Ruby 3.2 release. We do not anticipate any major problems as Rust is well supported on every platform which YJIT supports, but to make sure that this process works smoothly, we would like to reach out to those who take care of building systems packages before the 3.2 release is shipped and resolve any issues that may come up. [issue]: https://bugs.ruby-lang.org/issues/18481 Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> Co-authored-by: Noah Gibbs <the.codefolio.guy@gmail.com> Co-authored-by: Kevin Newton <kddnewton@gmail.com> Notes: Merged: https://github.com/ruby/ruby/pull/5826
2021-11-18Add --yjit-no-type-prop so we can test YJIT without type propagation (#5135)Maxime Chevalier-Boisvert
* Add --yjit-no-type-prop so we can test YJIT without type propagation * Fix typo in command line option * Leave just two test workflows enable for YJIT Notes: Merged-By: maximecb <maximecb@ruby-lang.org>
2021-11-15Add Aaron Patterson (@tenderlove) to YJIT code owners (#5119)Maxime Chevalier-Boisvert
Notes: Merged-By: maximecb <maximecb@ruby-lang.org>
2021-10-25Update YJIT code owners. Revert accidental commit.Maxime Chevalier-Boisvert
2021-10-25Add code owners for YJIT sourcesMaxime Chevalier-Boisvert
Code owners are automatically tagged as reviewers on pull requests