1 files changed, 2 insertions, 2 deletions
diff --git a/string.c b/string.c
index 7a7ccd0ef0..a4612221c5 100644
--- a/string.c
+++ b/string.c
@@ -1011,8 +1011,8 @@ rb_str_succ(orig)
 	sbeg = RSTRING(str)->ptr; s = sbeg + RSTRING(str)->len - 1;
 	c = '\001';
 	while (sbeg <= s) {
-	    *s += 1;
-	    if (*s-- != 0) break;
+           if ((*s += 1) != 0) break;
+           s--;
 	}
     }
     if (s < sbeg) {