diff options
-rw-r--r-- | parse.y | 22 | ||||
-rw-r--r-- | test/ruby/test_parse.rb | 2 | ||||
-rw-r--r-- | version.h | 2 |
3 files changed, 18 insertions, 8 deletions
@@ -5176,7 +5176,6 @@ ripper_dispatch_delayed_token(struct parser_params *parser, int t) #define parser_encoding_name() (current_enc->name) #define parser_mbclen() mbclen((lex_p-1),lex_pend,current_enc) -#define parser_precise_mbclen() rb_enc_precise_mbclen((lex_p-1),lex_pend,current_enc) #define is_identchar(p,e,enc) (rb_enc_isalnum((unsigned char)(*(p)),(enc)) || (*(p)) == '_' || !ISASCII(*(p))) #define parser_is_identchar() (!parser->eofp && is_identchar((lex_p-1),lex_pend,current_enc)) @@ -5248,6 +5247,17 @@ token_info_pop_gen(struct parser_params *parser, const char *token, size_t len) } static int +parser_precise_mbclen(struct parser_params *parser, const char *p) +{ + int len = rb_enc_precise_mbclen(p, lex_pend, current_enc); + if (!MBCLEN_CHARFOUND_P(len)) { + compile_error(PARSER_ARG "invalid multibyte char (%s)", parser_encoding_name()); + return -1; + } + return len; +} + +static int parser_yyerror(struct parser_params *parser, const char *msg) { #ifndef RIPPER @@ -6058,11 +6068,8 @@ dispose_string(VALUE str) static int parser_tokadd_mbchar(struct parser_params *parser, int c) { - int len = parser_precise_mbclen(); - if (!MBCLEN_CHARFOUND_P(len)) { - compile_error(PARSER_ARG "invalid multibyte char (%s)", parser_encoding_name()); - return -1; - } + int len = parser_precise_mbclen(parser, lex_p-1); + if (len < 0) return -1; tokadd(c); lex_p += --len; if (len > 0) tokcopy(len); @@ -7550,7 +7557,8 @@ parse_qmark(struct parser_params *parser, int space_seen) if (space_seen) { const char *start = lex_p - 1, *p = start; do { - int n = rb_enc_precise_mbclen(p, lex_pend, current_enc); + int n = parser_precise_mbclen(parser, p); + if (n < 0) return -1; p += n; } while (p < lex_pend && is_identchar(p, lex_pend, current_enc)); rb_warn2("`?' just followed by `%.*s' is interpreted as" \ diff --git a/test/ruby/test_parse.rb b/test/ruby/test_parse.rb index b4a63e369d..54610ccb12 100644 --- a/test/ruby/test_parse.rb +++ b/test/ruby/test_parse.rb @@ -512,6 +512,8 @@ class TestParse < Test::Unit::TestCase assert_raise(SyntaxError) { eval("?\v") } assert_raise(SyntaxError) { eval("?\r") } assert_raise(SyntaxError) { eval("?\f") } + assert_raise(SyntaxError) { eval("?\f") } + assert_raise(SyntaxError) { eval(" ?a\x8a".force_encoding("utf-8")) } assert_equal("\u{1234}", eval("?\u{1234}")) assert_equal("\u{1234}", eval('?\u{1234}')) end @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.4.2" #define RUBY_RELEASE_DATE "2017-07-23" -#define RUBY_PATCHLEVEL 152 +#define RUBY_PATCHLEVEL 153 #define RUBY_RELEASE_YEAR 2017 #define RUBY_RELEASE_MONTH 7 |