diff options
| -rw-r--r-- | ChangeLog | 10 | ||||
| -rw-r--r-- | compile.c | 13 |
2 files changed, 19 insertions, 4 deletions
@@ -1,3 +1,13 @@ +Wed Oct 17 08:32:46 2012 Koichi Sasada <ko1@atdot.net> + + * compile.c (compile_dstr_fragments): use `putobject' instead of + `putstring' for all of strings used by NODE_DSTR because + ruby users can not grab this string. + For example, the string object of "baz" in "foo#{bar}baz" + is located by `putobject' (users can not touch "baz" object + directly). This change reduces GC pressure. + This improvement is suggested by Aaron Patterson. + Wed Oct 17 08:02:57 2012 Koichi Sasada <ko1@atdot.net> * thread.c (rb_threadptr_interrupt_mask): fix to check interrupt @@ -2215,10 +2215,8 @@ iseq_set_sequence_stackcaching(rb_iseq_t *iseq, LINK_ANCHOR *anchor) return COMPILE_OK; } - - static int -compile_dstr_fragments(rb_iseq_t *iseq, LINK_ANCHOR *ret, NODE * node, int *cntp) +compile_dstr_fragments(rb_iseq_t *iseq, LINK_ANCHOR *ret, NODE *node, int *cntp) { NODE *list = node->nd_next; VALUE lit = node->nd_lit; @@ -2232,7 +2230,14 @@ compile_dstr_fragments(rb_iseq_t *iseq, LINK_ANCHOR *ret, NODE * node, int *cntp } while (list) { - COMPILE(ret, "each string", list->nd_head); + node = list->nd_head; + if (nd_type(node) == NODE_STR) { + hide_obj(node->nd_lit); + ADD_INSN1(ret, nd_line(node), putobject, node->nd_lit); + } + else { + COMPILE(ret, "each string", node); + } cnt++; list = list->nd_next; } |