summaryrefslogtreecommitdiff
path: root/yjit.c
diff options
context:
space:
mode:
authorPeter Zhu <peter@peterzhu.ca>2023-02-24 09:20:14 -0500
committerPeter Zhu <peter@peterzhu.ca>2023-02-24 14:10:09 -0500
commit3e098224077e8c43a1d8c2070b26ffdfda422780 (patch)
treeac701b8c89d90f3e6cd632ce22d0713d149ba945 /yjit.c
parentd2631c427ee723f6136ac1e08dd3c9c5b04c6725 (diff)
Fix incorrect line numbers in GC hook
If the previous instruction is not a leaf instruction, then the PC was incremented before the instruction was ran (meaning the currently executing instruction is actually the previous instruction), so we should not increment the PC otherwise we will calculate the source line for the next instruction. This bug can be reproduced in the following script: ``` require "objspace" ObjectSpace.trace_object_allocations_start a = 1.0 / 0.0 p [ObjectSpace.allocation_sourceline(a), ObjectSpace.allocation_sourcefile(a)] ``` Which outputs: [4, "test.rb"] This is incorrect because the object was allocated on line 10 and not line 4. The behaviour is correct when we use a leaf instruction (e.g. if we replaced `1.0 / 0.0` with `"hello"`), then the output is: [10, "test.rb"]. [Bug #19456]
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/7357
Diffstat (limited to 'yjit.c')
-rw-r--r--yjit.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/yjit.c b/yjit.c
index e00eda4581..683e8ae366 100644
--- a/yjit.c
+++ b/yjit.c
@@ -480,13 +480,6 @@ rb_insn_name(VALUE insn)
return insn_name(insn);
}
-// Query the instruction length in bytes for YARV opcode insn
-int
-rb_insn_len(VALUE insn)
-{
- return insn_len(insn);
-}
-
unsigned int
rb_vm_ci_argc(const struct rb_callinfo *ci)
{