diff options
author | Koichi Sasada <ko1@atdot.net> | 2021-12-23 15:51:13 +0900 |
---|---|---|
committer | Koichi Sasada <ko1@atdot.net> | 2021-12-23 16:49:49 +0900 |
commit | ca032d5eeaf81692f89f35c55450dcb97df59e16 (patch) | |
tree | f3c1e534a718b9459afb08e1f82ea7d54618e0f0 /vm_method.c | |
parent | 25e417b773b6f4b78c27a79e06c1277e7a5cf342 (diff) |
undef `rb_vm_lookup_overloaded_cme()`
Some callable method entries (cme) can be a key of `overloaded_cme_table`
and the keys should be pinned because the table is numtable (VALUE is a key).
Before the patch GC checks the cme is in `overloaded_cme_table` by looking up
the table, but it needs VM locking.
It works well in normal GC marking because it is protected by the VM lock,
but it doesn't work on `rb_objspace_reachable_objects_from` because it doesn't
use VM lock.
Now, the number of target cmes are small enough, I decide to pin down
all possible cmes instead of using looking up the table.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/5327
Diffstat (limited to 'vm_method.c')
-rw-r--r-- | vm_method.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/vm_method.c b/vm_method.c index b8197e14ca..38d03fbe2b 100644 --- a/vm_method.c +++ b/vm_method.c @@ -979,12 +979,13 @@ lookup_overloaded_cme(const rb_callable_method_entry_t *cme) return monly_cme; } -// used by gc.c +#if VM_CHECK_MODE > 0 MJIT_FUNC_EXPORTED const rb_callable_method_entry_t * rb_vm_lookup_overloaded_cme(const rb_callable_method_entry_t *cme) { return lookup_overloaded_cme(cme); } +#endif static void delete_overloaded_cme(const rb_callable_method_entry_t *cme) |