diff options
author | John Hawthorn <john@hawthorn.email> | 2019-12-12 15:47:59 -0800 |
---|---|---|
committer | Aaron Patterson <tenderlove@github.com> | 2019-12-17 09:19:00 -0800 |
commit | 254477248cde5bf82c4f256dca05b13d01c9774c (patch) | |
tree | 84e9676862da8fb830ef89f18dd5907d0d4c5508 /vm_method.c | |
parent | 9245462499e7c3216a468aadccdc11e69de8cd54 (diff) |
Skip optimized method check for most method IDs
Previously every time a method was defined on a module, we would
recursively walk all subclasses to see if the module was included in a
class which the VM optimizes for (such as Integer#+).
For most method definitions we can tell immediately that this won't be
the case based on the method's name. To do this we just keep a hash with
method IDs of optimized methods and if our new method isn't in that list
we don't need to check subclasses at all.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/2752
Diffstat (limited to 'vm_method.c')
-rw-r--r-- | vm_method.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/vm_method.c b/vm_method.c index bcf6b0b8c0..d2bd677e6a 100644 --- a/vm_method.c +++ b/vm_method.c @@ -500,7 +500,7 @@ rb_add_refined_method_entry(VALUE refined_class, ID mid) } static void -check_override_opt_method(VALUE klass, VALUE arg) +check_override_opt_method_i(VALUE klass, VALUE arg) { ID mid = (ID)arg; const rb_method_entry_t *me, *newme; @@ -512,7 +512,15 @@ check_override_opt_method(VALUE klass, VALUE arg) if (newme != me) rb_vm_check_redefinition_opt_method(me, me->owner); } } - rb_class_foreach_subclass(klass, check_override_opt_method, (VALUE)mid); + rb_class_foreach_subclass(klass, check_override_opt_method_i, (VALUE)mid); +} + +static void +check_override_opt_method(VALUE klass, VALUE mid) +{ + if (rb_vm_check_optimizable_mid(mid)) { + check_override_opt_method_i(klass, mid); + } } /* |