diff options
author | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-10-24 01:57:27 +0000 |
---|---|---|
committer | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-10-24 01:57:27 +0000 |
commit | f3c5239b16b983f1cea6c7710aae052f54e94ff8 (patch) | |
tree | 3f7c3a8f4e848ca514224d957a2083506db9e094 /vm.c | |
parent | 8e40a7ccb90bfbb06392c543cfa816b8cb5be8fc (diff) |
introduce new YARV insn newhashfromarray.
* insns.def (newhashfromarray): added to replace `core_hash_from_ary`
method to eliminate method call overhead.
On my environment, I got the following benchmark results:
x = {x: 1}
modified: 7864988.6 i/s
trunk: 6004098.1 i/s - 1.31x slower
x = {x: 1, y: 2}
trunk: 6127338.4 i/s
modified: 5232380.0 i/s - 1.17x slower
x = {x: 1, y: 2, z: 3}
modified: 6089553.1 i/s
trunk: 5249333.5 i/s - 1.16x slower
This trivial improvement should be reconsider because of usage of
this instruction.
* compile.c: ditto.
* defs/id.def, vm.c: remove unused functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'vm.c')
-rw-r--r-- | vm.c | 40 |
1 files changed, 0 insertions, 40 deletions
@@ -2676,8 +2676,6 @@ m_core_set_postexe(VALUE self) return Qnil; } -static VALUE core_hash_merge_ary(VALUE hash, VALUE ary); -static VALUE core_hash_from_ary(VALUE ary); static VALUE core_hash_merge_kwd(VALUE hash, VALUE kw); static VALUE @@ -2690,40 +2688,6 @@ core_hash_merge(VALUE hash, long argc, const VALUE *argv) } static VALUE -m_core_hash_from_ary(VALUE self, VALUE ary) -{ - VALUE hash; - REWIND_CFP(hash = core_hash_from_ary(ary)); - return hash; -} - -static VALUE -core_hash_from_ary(VALUE ary) -{ - VALUE hash = rb_hash_new_with_size(RARRAY_LEN(ary) / 2); - - RUBY_DTRACE_CREATE_HOOK(HASH, (Check_Type(ary, T_ARRAY), RARRAY_LEN(ary))); - return core_hash_merge_ary(hash, ary); -} - -#if 0 -static VALUE -m_core_hash_merge_ary(VALUE self, VALUE hash, VALUE ary) -{ - REWIND_CFP(core_hash_merge_ary(hash, ary)); - return hash; -} -#endif - -static VALUE -core_hash_merge_ary(VALUE hash, VALUE ary) -{ - Check_Type(ary, T_ARRAY); - core_hash_merge(hash, RARRAY_LEN(ary), RARRAY_CONST_PTR(ary)); - return hash; -} - -static VALUE m_core_hash_merge_ptr(int argc, VALUE *argv, VALUE recv) { VALUE hash = argv[0]; @@ -2864,10 +2828,6 @@ Init_VM(void) rb_define_method_id(klass, id_core_define_method, m_core_define_method, 2); rb_define_method_id(klass, id_core_define_singleton_method, m_core_define_singleton_method, 3); rb_define_method_id(klass, id_core_set_postexe, m_core_set_postexe, 0); - rb_define_method_id(klass, id_core_hash_from_ary, m_core_hash_from_ary, 1); -#if 0 - rb_define_method_id(klass, id_core_hash_merge_ary, m_core_hash_merge_ary, 2); -#endif rb_define_method_id(klass, id_core_hash_merge_ptr, m_core_hash_merge_ptr, -1); rb_define_method_id(klass, id_core_hash_merge_kwd, m_core_hash_merge_kwd, 2); rb_define_method_id(klass, idProc, rb_block_proc, 0); |